Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 324379 - dev-util/ciabot-svn: Verify and potentially improve Python-related code
Summary: dev-util/ciabot-svn: Verify and potentially improve Python-related code
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Christian Parpart (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 308257
  Show dependency tree
 
Reported: 2010-06-16 20:33 UTC by Arfrever Frehtes Taifersar Arahesis (RETIRED)
Modified: 2012-05-06 15:50 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild patch (ciabot-svn.patch,735 bytes, patch)
2011-11-17 17:57 UTC, Ian Delaney (RETIRED)
Details | Diff
revised ebuild patch (ciabot-svn.patch,730 bytes, patch)
2011-11-21 08:32 UTC, Ian Delaney (RETIRED)
Details | Diff
revised ebuild patch (ciabot-svn.patch,978 bytes, patch)
2011-11-22 10:47 UTC, Ian Delaney (RETIRED)
Details | Diff
revised ebuild patch (ciabot-svn.patch,1008 bytes, patch)
2011-11-24 23:44 UTC, Ian Delaney (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-06-16 20:33:38 UTC
- If this package can be used as a library and installs Python modules
  (*.so or *.py) into site-packages directories, then consider supporting
  installation for multiple Python versions.
  Please read section "Types of packages" in documentation [1] to decide
  if this package can support installation for multiple Python versions.

- Ensure that the ebuilds do not use deprecated functions or variables.

- Please check if Python 3 is supported by this package. You can temporarily
  set Python 3 as main active version of Python to properly test if this
  package supports Python 3.

- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
    Please read section "Specification of dependency on Python" in
    documentation [1].

  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
    python_set_active_version().

  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)
    Please read section "Shebangs in installed scripts" in documentation [1].

  - To ensure that changes applied to the ebuilds are sufficient, please
    temporarily set Python 3 as main active version of Python and test if
    this package can be properly installed and if it works at run time.

Please see documentation [1] for more details.
[1] http://www.gentoo.org/proj/en/Python/developersguide.xml
Comment 1 Ian Delaney (RETIRED) gentoo-dev 2011-11-17 17:57:11 UTC
Created attachment 292931 [details, diff]
ebuild patch
Comment 2 Arfrever Frehtes Taifersar Arahesis 2011-11-20 02:15:07 UTC
(In reply to comment #1)

This package doesn't support Python 3.
Shebang in a script needs to be fixed.
Comment 3 Ian Delaney (RETIRED) gentoo-dev 2011-11-21 08:32:12 UTC
Created attachment 293269 [details, diff]
revised ebuild patch

cannot figure the shebang, tried
Comment 4 Arfrever Frehtes Taifersar Arahesis 2011-11-21 19:42:49 UTC
(In reply to comment #3)

python_convert_shebangs() function is used to convert shebangs in scripts.
Comment 5 Ian Delaney (RETIRED) gentoo-dev 2011-11-22 10:47:51 UTC
Created attachment 293401 [details, diff]
revised ebuild patch

I figured it, perseverance wins again
>>> Emerging (1 of 1) dev-util/ciabot-svn-1.15
>>> Installing (1 of 1) dev-util/ciabot-svn-1.15
Comment 6 Arfrever Frehtes Taifersar Arahesis 2011-11-23 20:32:29 UTC
(In reply to comment #5)

Add 'python_set_active_version 2' in pkg_setup().

Since this package requires Python 2, pass "2" instead of "3" to python_convert_shebangs().

If you want to call python_convert_shebangs() at the end of src_install(), then pass "${ED}" instead of "." to python_convert_shebangs().
Comment 7 Ian Delaney (RETIRED) gentoo-dev 2011-11-24 23:44:28 UTC
Created attachment 293681 [details, diff]
revised ebuild patch
Comment 8 Pacho Ramos gentoo-dev 2012-05-06 15:50:58 UTC
+  06 May 2012; Pacho Ramos <pacho@gentoo.org> ciabot-svn-1.15.ebuild:
+  Let it work with python3 as main interpreter.
+