The patch 'vte-invisible-cursor-fix.patch' applied to =vte-0.24.1 in gnome overlay causes the cursor in x11-terms/terminal and x11-terms/terminator to disappear (in fact, with semi-transparent terminal you might notice it being black). Without the patch, both terminals work fine.
Well, that patch is a backport from git master of the fix for http://bugzilla.gnome.org/show_bug.cgi?id=602596 and it does make mc display things correctly in sakura, which is a very thin wrapper around vte.
I've just tested vte-0.25.1 and it is broken indeed. I guess that's worth reopening the old bug. IMO, unless fixed otherwise, it'd be better to drop the patches anyway. I guess users of Terminal and terminator form a larger group than those of sakura, and the upstream version at the point worked fine for them.
I've opened a new bug for that regression upstream [1]. [1] https://bugzilla.gnome.org/show_bug.cgi?id=621298
Well, primary user of vte is always gnome-terminal, so if that one works, then it's the other ones that are at fault.
Also, add one more detail - is your problem related to transparency ?
@gnome team: I see, that the mentioned patch didn't get into the tree. It's not the first time a fix from the overlay got missed. I'm still convinced that the fault lies on the side of the mentioned terminals. Should I file a new bug, *restating* the reasons I gave the people on #gentoo-desktop, that got that patch into overlay ?
I missed it intentionally since that patch causes problems, then, please, explain me why I should include it anyway even causing other breakages Thanks
1. it fixes the bug from comment 2 2. the bug reported here happens with vte 0.25.1 3. primary consumer of vte - gnome-terminal -(which I don't use) doesn't seem to be affected by the problem affected here (at least as far I understand its description) 4. midnight commander *is* affected by the Gnome bug as such, I think there's a very high probability, that the problem here lies in the apps, not the lib, the change in the lib just exposes it
(In reply to comment #8) > 1. it fixes the bug from comment 2 But, isn't the patch you are requesting to add the one is causing original invisible cursor problems reported in this bug report? > 2. the bug reported here happens with vte 0.25.1 And in 0.24.1 with the patch you are requesting to add > 3. primary consumer of vte - gnome-terminal -(which I don't use) doesn't > seem to be affected by the problem affected here (at least as far I > understand its description) > 4. midnight commander *is* affected by the Gnome bug > But it's similar to what you are saying in point "3": mc is affected only when using sakura. It's also not a regression over current stable (or that seems), while after applying that patch a new regression seems to appear. > as such, I think there's a very high probability, that the problem here > lies in the apps, not the lib, the change in the lib just exposes it As can be seen in http://bugzilla.xfce.org/show_bug.cgi?id=6423 seems that they think it's a vte problem, then, better wait for vte developers response on this
1.,2. yes, it is, but as it's a backport, those apps will need to be fixed anyway 3.,4. I use sakura, but AFAICT the gnome bug was far more general and affected gnome-terminal too (at least old posts on midnight commander mailing lists suggest so) - a few comments in the Gnome bug come from an mc dev, so the problem had to be more common than sakura
...and as for xfce bug, it seems dead ever since it was marked invalid, before the notice about vte 0.25.1 was added
(In reply to comment #8) > 2. the bug reported here happens with vte 0.25.1 Which means the new version is broken. I see no reason to break the old one too, raising a lot of false bugreports once again, confusing upstream that the bug is Gentoo-specific. > 3. primary consumer of vte - gnome-terminal -(which I don't use) doesn't > seem to be affected by the problem affected here (at least as far I > understand its description) Nor by the problem described by the original patch. > 4. midnight commander *is* affected by the Gnome bug It is affected on a single terminal. I don't think it's worth to apply a patch fixing a single application on a single terminal (which probably isn't used very widely) but making two other terminals (independently of which applications are used) practically useless. Especially that one of them is a part of DE, which means all 'unstable-keyworded' xfce users will have cursor-less terminals.
I.e. http://mail.gnome.org/archives/mc/2010-March/msg00022.html tells it was (and in 0.24.1 still is) a bug in vte, *affecting* gnome-terminal (there's probably a better post, but this was the first I found) Also, if bug 324631 gets confirmed, it will be moot anyway.
Here is the complete description: http://www.midnight-commander.org/ticket/113
+*vte-0.24.2 (23 Jun 2010) + + 23 Jun 2010; Pacho Ramos <pacho@gentoo.org> -vte-0.24.1-r1.ebuild, + +vte-0.24.2.ebuild, +files/vte-0.24.2-invisible-cursor.patch, + +files/vte-0.24.2-invisible-cursor2.patch: + Version bump with translations updates. This also provides patches to fix + upstream bug #602596 as demanded by some people, but they are not being + applied yet since they cause other problems (bug #323443). Finally, this + no longer applies second patch to solve ugly artifacts bug with + gnome-terminal since it also causes problems with x11-terms/terminal (bug + #324631) and the other patches seem to be enough for now. What does this mean? - I still don't apply "invisible" patches as they still cause cursor to become invisible with x11-terms/terminal (just reproduced by myself) - On the other hand, I have committed them anyway and, then, people wanting to use them will simply need to uncomment relevant "epatch" lines in the new ebuild. I know it's not perfect, but I haven't found a better solution for now I also CC xfce team since maybe they know how to "push" a bit xfce upstream (I have already contacted with vte one)
(In reply to comment #15) > I also CC xfce team since maybe they know how to "push" a bit xfce upstream (I > have already contacted with vte one) Besides filing a bug at bugzilla.xfce.org, I have no relationship with upstream xfce. For this specific case, I don't have the level of understanding to open a bug report.
This was fixed by vte upstream in master: https://bugzilla.gnome.org/show_bug.cgi?id=621298#c6 x11-libs/vte-0.24.3 will be kept as-is since some more changes were applied to master regarding this issue
