Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 322779 - app-backup/amanda version bump to 3.1.2
Summary: app-backup/amanda version bump to 3.1.2
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Robin Johnson
URL:
Whiteboard:
Keywords:
: 322777 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-06-04 18:09 UTC by Dustin J. Mitchell
Modified: 2010-09-10 19:43 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
new release, new ebuild for 3.1.1 (amanda-3.1.1.ebuild,16.94 KB, text/plain)
2010-07-01 09:25 UTC, Stefan G. Weichinger
Details
config.log with --with-ipv6 (config.log,289.55 KB, text/plain)
2010-08-04 03:11 UTC, Jeroen Roovers (RETIRED)
Details
ebuild for amanda-3.1.2 (amanda-3.1.2.ebuild,16.94 KB, text/plain)
2010-08-15 18:33 UTC, Stefan G. Weichinger
Details
corrected ebuild for 3.1.2 (amanda-3.1.2.ebuild,14.09 KB, text/plain)
2010-08-15 20:01 UTC, Stefan G. Weichinger
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dustin J. Mitchell 2010-06-04 18:09:24 UTC
Amanda 3.1.0 was released last week - it would be great to have it available in gentoo testing..

Reproducible: Always

Steps to Reproduce:
Comment 1 Dustin J. Mitchell 2010-06-04 18:11:56 UTC
*** Bug 322777 has been marked as a duplicate of this bug. ***
Comment 2 Stefan G. Weichinger 2010-07-01 09:25:12 UTC
Created attachment 237115 [details]
new release, new ebuild for 3.1.1
Comment 3 Dustin J. Mitchell 2010-07-01 14:55:42 UTC
Looks like 3.1.0 got missed in portage :)
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2010-08-04 03:04:53 UTC
Comment on attachment 237115 [details]
new release, new ebuild for 3.1.1

Looks like it was based on something older than the 2.6.1_p2ebuild. Please attach a diff next time or nothing if there is no difference and you just copied over an old ebuild.
Comment 5 Dustin J. Mitchell 2010-08-04 03:07:44 UTC
FYI, 3.1.2 should be out at the end of this week, so 3.1.1 (or at least 3.1.0) should get into testing soon.
Comment 6 Jeroen Roovers (RETIRED) gentoo-dev 2010-08-04 03:11:40 UTC
Created attachment 241363 [details]
config.log with --with-ipv6

--- amanda-2.6.1_p2.ebuild      2010-05-08 21:48:53.000000000 +0200
+++ amanda-3.1.1.ebuild 2010-08-04 03:55:57.668039175 +0200
@@ -217,10 +217,6 @@
        myconf="${myconf} --with-bsdudp-security"
        myconf="${myconf} --with-bsdtcp-security"
 
-       # kerberos-security mechanism version 4
-       # always disable, per bug #173354
-       myconf="${myconf} --without-krb4-security"
-
        # kerberos-security mechanism version 5
        myconf="${myconf} `use_with kerberos krb5-security`"
 

The above gets rid of a minor issue. The bigger issue that keeps me from committing this ebuild is that with USE=ipv6, the configure script actually expects to be able to bind to an IPv6 socket, instead of checking that compile time support is present as it should.

config/amanda/ipv6.m4 even spits out "Target system has functional IPv6 support", while we haven't even told configure what the target system is.
Comment 7 Dustin J. Mitchell 2010-08-04 03:26:10 UTC
The term "target" there should be "host" - Amanda definitely does not support cross-compiling!  I'll fix that up (in trunk only, so you won't see the change in 3.1.2).

We test this way because it's the only way to effectively determine whether a system can really support an IPv6 installation.  Without this check, Amanda can build on systems (like yours) with compiler support for IPv6 but without kernel support.  Because many such systems have ::1 in /etc/hosts, Amanda ends up trying to use an IPv6 socket even for inter-process communication, and things fail, badly.

There are obviously better fixes - in particular, Amanda could retry failures with AF_INET6 again with AF_INET.  In many places, it does so.  The problem is that "fixing" these sorts of problems has consistently introduced bugs for IPv4 users (arguably 100% of Amanda's users) and only benefit the IPv6 users (0%).  So we've stuck with a conservative approach of just not building IPv6 support if it looks like it might not work at runtime.

I wrote about related issues recently:
  http://code.v.igoro.us/archives/61-IPv6-and-Amanda.html

I'd be more than happy to upstream any patches you provide!

To the point at hand, though:

1. this exact same code is present in 2.6.1, so it's really orthogonal to bumping 3.1.1, and probably deserves its own bug

2. if your system has compile-time support for IPv6, but no kernel support, then it really doesn't have IPv6 support, right?  So why are you passing USE=ipv6?

I suppose a good fix is to skip the bind-to-a-socket test if --with-ipv6 was supplied, and just assume the user knows what they're doing.

What do you think?
Comment 8 Dustin J. Mitchell 2010-08-04 03:31:43 UTC
Fix "Target":
http://github.com/zmanda/amanda/commit/2126a109369204747ea4bc65ef5bfce8624b0e60
Comment 9 Dustin J. Mitchell 2010-08-14 19:08:31 UTC
Bumping the version-number target.  3.1.2 was released last week.
Comment 10 Stefan G. Weichinger 2010-08-15 18:33:51 UTC
Created attachment 243085 [details]
ebuild for amanda-3.1.2
Comment 11 Dustin J. Mitchell 2010-08-15 19:52:41 UTC
Stefan: did you upload the wrong file, by chance?  That's byte-for-byte identical to attachment 237115 [details].  Or did you not make any changes?

In comment #4, Jeroen pointed out that this is based on an older ebuild than the 2.6.0_p2-r4 that's currently in the tree.  In particular, the tree has copyright 1999-2009, while your patch has copyright 1999-2008.  There are significant differences between the ebuilds, and I suspect most of them were not your changes, but are regressions.  Can you upload a newer ebuild based on the most recent in portage?
Comment 12 Stefan G. Weichinger 2010-08-15 20:01:32 UTC
Created attachment 243105 [details]
corrected ebuild for 3.1.2

shame on me ... new ebuild now, based on current ebuild for 2.6.1p2 in portage, and regarding the corrections by Dustin (from the thread on amanda-users).
Comment 13 Stefan G. Weichinger 2010-09-08 21:55:08 UTC
(In reply to comment #12)
> Created an attachment (id=243105) [details]
> corrected ebuild for 3.1.2
> 
> shame on me ... new ebuild now, based on current ebuild for 2.6.1p2 in portage,
> and regarding the corrections by Dustin (from the thread on amanda-users).

Reminder to maybe speed up getting this into portage ...... hello? thanks ...
Comment 14 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2010-09-10 19:43:06 UTC
3.1.2 in tree.