Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 322349 - dev-python/PyQt4 needs a patch for ARM
Summary: dev-python/PyQt4 needs a patch for ARM
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: ARM Linux
: High normal (vote)
Assignee: Qt Bug Alias
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 322351
  Show dependency tree
 
Reported: 2010-06-01 09:43 UTC by Alexander Holler
Modified: 2010-06-16 17:39 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch from Ubuntu (qreal_float_support.diff,6.31 KB, patch)
2010-06-01 09:44 UTC, Alexander Holler
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Holler 2010-06-01 09:43:05 UTC
PyQt4 needs a patch in order to build other packages (e.g. pykde4).

Reproducible: Always




The patch was found in Ubuntus Launchpad bug #308814.
Comment 1 Alexander Holler 2010-06-01 09:44:36 UTC
Created attachment 233763 [details, diff]
Patch from Ubuntu
Comment 2 Alexander Holler 2010-06-01 09:46:23 UTC
To apply the patch I've changed the following:

--- /usr/portage/dev-python/PyQt4/PyQt4-4.7.3.ebuild    2010-05-25 12:35:43.000000000 +0200
+++ PyQt4-4.7.3.ebuild  2010-05-31 16:39:50.048733374 +0200
@@ -48,6 +48,7 @@
 PATCHES=(
        "${FILESDIR}/${PN}-4.6.1-configure-multilib.patch"
        "${FILESDIR}/${PN}-4.7.2-configure.py.patch"
+       "${FILESDIR}/qreal_float_support.diff"
 )
 
 src_prepare() {
Comment 3 Davide Pesavento gentoo-dev 2010-06-01 10:43:54 UTC
Is upstream aware of the issue?
Comment 4 Alexander Holler 2010-06-01 10:58:32 UTC
I don't know.
Comment 5 Davide Pesavento gentoo-dev 2010-06-01 14:25:47 UTC
Could you inform them please?
Comment 6 Alexander Holler 2010-06-07 08:01:57 UTC
I've informed them, but it seems they don't like the patch.

The problem has come through a change in the definition of qreal on ARM:

http://doc.trolltech.com/4.0/qtglobal.html#qreal-typedef

against

http://doc.trolltech.com/4.6/qtglobal.html#qreal-typedef

So if something which uses PyQt uses double instead of qreal this fails now.

So this patch is something which offers downward compatibility.
Comment 7 Alexander Holler 2010-06-07 08:31:41 UTC
Upstream will not apply this patch, which is understandable, because it isn't a problem of PyQt.

But as long as there is no patch for kde4 which fixes the problem there, my suggestion is to apply this patch.
Comment 8 Tomás Touceda (RETIRED) gentoo-dev 2010-06-16 01:45:26 UTC
Since both PyQt and KDE upstream don't leave us with any other choice, I've applied the patch provided for ARM arch.

This needs a little more testing before closing.
Comment 9 Tomás Touceda (RETIRED) gentoo-dev 2010-06-16 17:39:36 UTC
I'm closing this, if anything comes up with the testing we'll reopen.

Thanks Alexander for reporting.