Bug 318185 – media-sound/alsa-headers-1.0.23: Prefix changes

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Jonathan Callen (RETIRED) 2010-05-02 18:13:01 UTC]

Please review the following changes to the media-sound/alsa-headers-1.0.23 ebuild.  These changes may be applied either directly to the version in-tree or as a revbump.

--- /home/portage/media-sound/alsa-headers/alsa-headers-1.0.23.ebuild   2010-04-16 18:12:06.000000000 -0400
+++ alsa-headers-1.0.23.ebuild  2010-05-02 13:39:51.525924489 -0400
@@ -2,6 +2,8 @@
 # Distributed under the terms of the GNU General Public License v2
 # $Header: /var/cvsroot/gentoo-x86/media-sound/alsa-headers/alsa-headers-1.0.23.ebuild,v 1.1 2010/04/16 22:12:06 chainsaw Exp $

+EAPI="3"
+
 inherit eutils

 MY_PN=${PN/headers/driver}
@@ -14,7 +16,7 @@ SRC_URI="mirror://alsaproject/driver/${M

 LICENSE="GPL-2"
 SLOT="0"
-KEYWORDS="~alpha ~amd64 ~arm ~hppa ~ia64 ~mips ~ppc ~ppc64 ~sh ~sparc ~x86"
+KEYWORDS="~alpha ~amd64 ~arm ~hppa ~ia64 ~mips ~ppc ~ppc64 ~sh ~sparc ~x86 ~amd64-linux ~x86-linux ~ppc-macos"
 IUSE=""

 DEPEND=""
@@ -24,18 +26,17 @@ RESTRICT="binchecks strip"

 # Remove the sound symlink workaround...
 pkg_setup() {
-       if [[ -L "${ROOT}/usr/include/sound" ]]; then
-               rm      "${ROOT}/usr/include/sound"
+       if [[ -L "${EROOT}/usr/include/sound" ]]; then
+               rm      "${EROOT}/usr/include/sound"
        fi
 }

-src_unpack() {
-       unpack ${A}
-
-       cd "${S}"
+src_prepare() {
        epatch "${FILESDIR}/${PN}-1.0.6a-user.patch"
 }

+src_configure() { :; }
+
 src_compile() { :; }

 src_install() {

[Comment 1 Tony Vroon (RETIRED) 2010-05-03 21:39:33 UTC]

Please use the base eclass to apply that one patch.

[Comment 2 Jonathan Callen (RETIRED) 2010-05-04 01:13:24 UTC]

(In reply to comment #1)
> Please use the base eclass to apply that one patch.
> 

We didn't add it. It's already in the gentoo-x86 tree that way. (The change can be made, but that's a separate issue.)

[Comment 3 Tony Vroon (RETIRED) 2010-05-04 10:33:13 UTC]

(In reply to comment #2)
> We didn't add it. It's already in the gentoo-x86 tree that way. (The change can
> be made, but that's a separate issue.)

Please address the review comments made. Once you do, you are clear to commit.

[Comment 4 Jeremy Olexa (darkside) (RETIRED) 2010-05-22 22:18:27 UTC]

*** Bug 321031 has been marked as a duplicate of this bug. ***

[Comment 5 Jonathan Callen (RETIRED) 2010-05-24 01:28:01 UTC]

Now that I got a machine that will commit again, fixed.