Bug 318139 – games-sports/trophy: fails with forced --as-needed

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Diego Elio Pettenò (RETIRED) 2010-05-02 11:34:47 UTC]

I'm reporting this bug because the package in summary fails to build when forcing --as-needed on through spec files (check out http://blog.flameeyes.eu/2008/11/14/problems-and-mitigation-strategies-for-as-needed for details).

Please note that this bug _might_ apply to -Wl,--as-needed in LDFLAGS as well; in both cases it should be fixed. Also, if this is due to the package in question not respecting user-defined LDFLAGS, you should get to fix that too.

Check the attached build log.

Thanks,
Diego

[Comment 1 Diego Elio Pettenò (RETIRED) 2010-05-02 11:35:04 UTC]

Created attachment 230019 [details]
Build log

[Comment 2 Kevin Pyle 2010-05-02 18:23:06 UTC]

This appears to be the standard mistake of specifying libraries via LDFLAGS instead of LIBS.  The LDFLAGS variable references the libraries via a `pkg-config --libs` expression instead of listing them explicitly.  Moving the pkg-config call to the right variable should push it down to the end of the line and solve the problem.

[Comment 3 Kacper Kowalik (Xarthisius) (RETIRED) 2010-05-04 21:27:30 UTC]

Created attachment 230359 [details, diff]
adding epatch and autotools

[Comment 4 Kacper Kowalik (Xarthisius) (RETIRED) 2010-05-04 21:27:48 UTC]

Created attachment 230361 [details, diff]
fixing as-needed issues

[Comment 5 Mr. Bones. (RETIRED) 2010-05-04 23:19:29 UTC]

in portage.  thanks for the patch.