Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 317091 - Please review Prefix changes for dev-lang/python 2.5.4-r4 and 2.6.5-r1
Summary: Please review Prefix changes for dev-lang/python 2.5.4-r4 and 2.6.5-r1
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Gentoo Prefix
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: prefix-gx86
  Show dependency tree
 
Reported: 2010-04-25 09:38 UTC by Fabian Groffen
Modified: 2011-04-24 12:32 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
python-2.5.4-r4 prefix changes (python-2.5.4-r4.ebuild-prefix.patch,5.77 KB, patch)
2010-04-25 09:39 UTC, Fabian Groffen
Details | Diff
python-2.6.5-r1 prefix changes (python-2.6.5-r1.ebuild-prefix.patch,14.69 KB, patch)
2010-04-25 09:45 UTC, Fabian Groffen
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fabian Groffen gentoo-dev 2010-04-25 09:38:08 UTC
This is a non-trivial change for which we apologise upfront.  Since porting Python to non-Linux is a daunting and very time-consuming task, Python 3 is still a no-go for Prefix.  Changes necessary to the 2.7 and 3.x ebuilds will be in the same order of magnitudes like the 2.6 ebuild, and only worth the time once they become mainstream and necessary, as each and every minor version requires again a substantial amount of time to get them going.

We decided to drop Python 2.4 given it's expected EOL in Gentoo, although we have all working patches available.

I will attach the diffs to the ebuilds.  Please find all referenced patches in our overlay:
http://overlays.gentoo.org/proj/alt/browser/trunk/prefix-overlay/dev-lang/python/files
Comment 1 Fabian Groffen gentoo-dev 2010-04-25 09:39:06 UTC
Created attachment 229063 [details, diff]
python-2.5.4-r4 prefix changes
Comment 2 Fabian Groffen gentoo-dev 2010-04-25 09:45:40 UTC
Created attachment 229065 [details, diff]
python-2.6.5-r1 prefix changes

Note that this patch introduces USE=aqua for OSX users.  It is necessary to make certain applications (e.g. wxPython) work, but we cannot give up on the traditional UNIX install, so we build a hybrid version.
Comment 3 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-05-01 16:08:26 UTC
These patches are not possible to maintain in current form. Please convince upstream to apply these patches and backport them to 2.6 branch. You don't have too much time, because 2.6 branch will be frozen to only security fixes when Python 2.7 is released in about 2 months.

I will apply s/${D}/${ED}/ changes.

WONTFIX for 2.5 slot (except ${ED}).
Comment 4 Fabian Groffen gentoo-dev 2010-05-01 16:17:42 UTC
It is impossible to get upstream to apply the patches.

Since python-2.5 is frozen, there is not much maintenance burden for the python team here.
Since python-2.6 will be frozen soon, there is not much maintenance burden to be expected for the python team here either.
Apart from that, the maintenance burden will always be on the Prefix team, so the additional burden for the python team is really minimal here.

Please understand that simply rejecting this bug because upstream is not willing to fix their problems is effectively thwarting the entire Prefix project.  Obviously this is not well appreciated.

So please come up with reasonable comments/requests or allow us to progress.
Comment 5 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-05-02 20:42:26 UTC
(In reply to comment #4)
> It is impossible to get upstream to apply the patches.

Python upstream developers accept properly written patches. In case of larger patches, contributor agreement should be signed.
http://bugs.python.org/user11723 says "Contributor Form Received  No"
If contributor agreement has been signed and sent, then you can join #python-dev and ask administrators of Python bug tracker to update data in database.

> Apart from that, the maintenance burden will always be on the Prefix team, so
> the additional burden for the python team is really minimal here.

Only changes in KEYWORDS and some trivial changes (e.g. s/${D}/${ED}/) can be made by non-maintainers.
Comment 6 Fabian Groffen gentoo-dev 2010-05-11 15:00:57 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > It is impossible to get upstream to apply the patches.
> 
> Python upstream developers accept properly written patches. In case of larger
> patches, contributor agreement should be signed.
> http://bugs.python.org/user11723 says "Contributor Form Received  No"
> If contributor agreement has been signed and sent, then you can join
> #python-dev and ask administrators of Python bug tracker to update data in
> database.

Stuart, can you tell us what happened to the IRIX bugs on the Python bugtracker?

> > Apart from that, the maintenance burden will always be on the Prefix team, so
> > the additional burden for the python team is really minimal here.
> 
> Only changes in KEYWORDS and some trivial changes (e.g. s/${D}/${ED}/) can be
> made by non-maintainers.

It is, and remains, unacceptable to let a single team be responsible for arches they don't even have access to, let alone expect them to fix issues.  The Prefix team will always (have to) provide the necessary information and patches that are necessary.  As such they will also maintain them upon need.  It seems like a very unappropriate thought of the python team to me here to think that they should maintain the sometimes draconic patches that we need.

We ask for recognition of our work and userbase, and do not intend to "throw some patches over the hedge".
Comment 7 Stuart Shelton 2010-05-11 16:42:41 UTC
I can't remember the exact details right now, but there was some problem with the document which the Python maintainers now demand be signed, and I was unable to return it.  I'll try to dig up details - but I personally think it's insane to require anyone who wants to contribute to the success of the project to have to jump through hoops like this, it'll just result in less-common bugs never being fixed (in-tree, at least).
Comment 8 Fabian Groffen gentoo-dev 2011-04-24 12:32:06 UTC
python-2.5 and 2.6 are gone from prefix, close this drama for now.