Bug 315863 – net-p2p/deluge: Verify and potentially improve Python-related code

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-04-18 02:31:48 UTC]

- If this package can be used as a library and installs Python modules
  (*.so or *.py) into site-packages directories, then consider supporting
  installation for multiple Python versions.
  Please read section "Types of packages" in documentation [1] to decide
  if this package can support installation for multiple Python versions.

- Ensure that the ebuilds do not use deprecated functions or variables.

- Please check if Python 3 is supported by this package. You can temporarily
  set Python 3 as main active version of Python to properly test if this
  package supports Python 3.

- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
    Please read section "Specification of dependency on Python" in
    documentation [1].

  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
    python_set_active_version().

  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)
    Please read section "Shebangs in installed scripts" in documentation [1].

  - To ensure that changes applied to the ebuilds are sufficient, please
    temporarily set Python 3 as main active version of Python and test if
    this package can be properly installed and if it works at run time.

Please see documentation [1] for more details.
[1] http://www.gentoo.org/proj/en/Python/developersguide.xml

[Comment 1 Pacho Ramos 2010-11-21 13:44:32 UTC]

Created attachment 255011 [details, diff]
deluge-1.3.1.ebuild.diff

This works for me but I am unsure about the proper way to replace:
|| ( >=virtual/python-2.6 dev-python/simplejson )

[Comment 2 Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-11-28 01:18:32 UTC]

(In reply to comment #1)

|| ( dev-lang/python:2.7 dev-lang/python:2.6 dev-python/simplejson )

[Comment 3 Pacho Ramos 2010-11-28 12:28:39 UTC]

Thanks

net-p2p team, if you are ok with this, feel free to give me the ok to commit ;-)

[Comment 4 Raúl Porcel (RETIRED) 2010-11-28 16:01:55 UTC]

(In reply to comment #3)
> Thanks
> 
> net-p2p team, if you are ok with this, feel free to give me the ok to commit
> ;-)
> 

go ahead, thanks

[Comment 5 Pacho Ramos 2010-11-28 22:49:13 UTC]

+  28 Nov 2010; Pacho Ramos <[e-mail]> deluge-1.3.1.ebuild:
+  Let this compile and work when python3 is the main interpreter (bug #315863).
+