Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 315855 - net-nntp/inn: Verify and potentially improve Python-related code
Summary: net-nntp/inn: Verify and potentially improve Python-related code
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Gentoo Net-news project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 308257
  Show dependency tree
 
Reported: 2010-04-18 02:29 UTC by Arfrever Frehtes Taifersar Arahesis (RETIRED)
Modified: 2013-02-06 10:30 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild patch (inn.patch,3.65 KB, patch)
2011-11-19 21:36 UTC, Ian Delaney (RETIRED)
Details | Diff
revised ebuild patch (inn.patch,3.57 KB, patch)
2011-11-20 22:29 UTC, Ian Delaney (RETIRED)
Details | Diff
revised ebuild patch (inn.patch,3.52 KB, patch)
2011-11-21 08:41 UTC, Ian Delaney (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-04-18 02:29:50 UTC
- If this package can be used as a library and installs Python modules
  (*.so or *.py) into site-packages directories, then consider supporting
  installation for multiple Python versions.
  Please read section "Types of packages" in documentation [1] to decide
  if this package can support installation for multiple Python versions.

- Ensure that the ebuilds do not use deprecated functions or variables.

- Please check if Python 3 is supported by this package. You can temporarily
  set Python 3 as main active version of Python to properly test if this
  package supports Python 3.

- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
    Please read section "Specification of dependency on Python" in
    documentation [1].

  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
    python_set_active_version().

  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)
    Please read section "Shebangs in installed scripts" in documentation [1].

  - To ensure that changes applied to the ebuilds are sufficient, please
    temporarily set Python 3 as main active version of Python and test if
    this package can be properly installed and if it works at run time.

Please see documentation [1] for more details.
[1] http://www.gentoo.org/proj/en/Python/developersguide.xml
Comment 1 Ian Delaney (RETIRED) gentoo-dev 2011-11-19 21:36:40 UTC
Created attachment 293141 [details, diff]
ebuild patch
Comment 2 Arfrever Frehtes Taifersar Arahesis 2011-11-20 07:19:13 UTC
(In reply to comment #1)

Don't change DESTDIR="${D}/" to DESTDIR="${ED}/".
Comment 3 Ian Delaney (RETIRED) gentoo-dev 2011-11-20 22:29:55 UTC
Created attachment 293237 [details, diff]
revised ebuild patch
Comment 4 Arfrever Frehtes Taifersar Arahesis 2011-11-21 00:24:32 UTC
(In reply to comment #3)

This patch still changes DESTDIR="${D}/" to DESTDIR="${ED}/" in inn-2.5.2-r1.ebuild.
Comment 5 Ian Delaney (RETIRED) gentoo-dev 2011-11-21 08:41:33 UTC
Created attachment 293271 [details, diff]
revised ebuild patch
Comment 6 Michael Palimaka (kensington) gentoo-dev 2013-02-06 10:30:45 UTC
Thanks, fixed in CVS.

+  06 Feb 2013; Michael Palimaka <kensington@gentoo.org>
+  +files/inn-2.5.3-tests.patch, +inn-2.5.3-r1.ebuild:
+  Migrate to EAPI 5. Add missing dependencies. Migrate to python-r1 wrt bug
+  #315855. Add a test fix wrt bug #348490. Do not install /var/run wrt bug
+  #454182.