Bug 31542 – holdremote for dial-up [done for -r14]

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Kurt Hindenburg 2003-10-19 14:19:04 UTC]

It would be nice to allow dial-up users to use the qmail-hold-1.03.pat.gz patch
which uses qmail/contol/holdremote to prevent sending of mail.  The patch
applies cleanly for qmail-1.03-r10.  The change to the ebuild is miminal.

-       http://www.suspectclass.com/~sgifford/qmail/qmail-0.0.0.0.patch"
+       http://www.suspectclass.com/~sgifford/qmail/qmail-0.0.0.0.patch
+       http://www.leverton.org/qmail-hold-1.03.pat.gz"

        epatch ${FILESDIR}/${PV}-${PR}/errno.patch
+
+       epatch ${FILESDIR}/${PV}-${PR}/qmail-hold-1.03.pat.gz

However, I would sugest using an 'if use dialup' condition for this patch.  If
you are interested I could provide a complete patch.


Reproducible: Always
Steps to Reproduce:
1.
2.
3.




Portage 2.0.49-r13-2 (default-x86-1.4, gcc-3.2.3, glibc-2.3.2-r1, 2.4.20-gentoo-r7)
=================================================================
System uname: 2.4.20-gentoo-r7 i586 AMD-K6tm w/ multimedia extensions
Gentoo Base System version 1.4.3.10
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CFLAGS="-O2 -mcpu=i586 -funroll-loops -pipe -fomit-frame-pointer"
CHOST="i586-pc-linux-gnu"
COMPILER="gcc3"
CONFIG_PROTECT="/etc /var/qmail/control /usr/share/config
/usr/kde/2/share/config /usr/kde/3/share/config"
CONFIG_PROTECT_MASK="/etc/gconf /etc/env.d"
CXXFLAGS="-O2 -mcpu=i686 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="sandbox ccache autoaddcvs"
GENTOO_MIRRORS="http://gentoo.noved.org/"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="x86 oss apm arts avi crypt cups encode foomaticdb gif imlib jpeg libg++
libwww mad mikmod motif mpeg ncurses oggvorbis opengl pdflib png qt quicktime
sdl spell svga truetype xml2 xmms xv zlib gdbm berkdb slang readline ruby gpm
tcpd pam perl python -java -gtk -gtk2 -gnome -kde -alsa -X -esd -nls ssl ssh"

[Comment 1 Robin Johnson 2003-10-26 22:02:54 UTC]

could you please provide the complete patch against -r12 or -r13 of qmail
in the tree presently, and verify that it still works with all the other
patches that are in place.

[Comment 2 Kurt Hindenburg 2003-10-27 09:45:44 UTC]

Created attachment 19856 [details, diff]
Diff for r12 for holdremote patch.

The diff is straight-forward.  None of the other patches for -r12 patch
qmail-send.c which is what the qmail-hold patches.  I chose USE="holdremote"
for the use command.  It compiles with and with-out the holdremote patch.

[Comment 3 Robin Johnson 2003-11-30 00:20:51 UTC]

fixed in -r14
I've taken the route of always having the patch in place
and as long as holdremote/holdlocal don't exist, there is not effect.

[Comment 4 Robin Johnson 2004-01-23 23:57:19 UTC]

closing old bugs.