Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 315325 - net-libs/xulrunner: Verify and potentially improve Python-related code
Summary: net-libs/xulrunner: Verify and potentially improve Python-related code
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 308257
  Show dependency tree
 
Reported: 2010-04-14 21:05 UTC by Arfrever Frehtes Taifersar Arahesis (RETIRED)
Modified: 2010-04-20 20:11 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
xulrunner-1.9.2.3-r1:20100418-194108.log (xulrunner-1.9.2.3-r1:20100418-194108.log,80.51 KB, text/plain)
2010-04-18 19:46 UTC, Arfrever Frehtes Taifersar Arahesis (RETIRED)
Details
xulrunner-1.9.2.3-r1.ebuild.patch (xulrunner-1.9.2.3-r1.ebuild.patch,1.21 KB, patch)
2010-04-18 19:57 UTC, Arfrever Frehtes Taifersar Arahesis (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-04-14 21:05:36 UTC
- If this package can be used as a library and installs Python modules
  (*.so or *.py) into site-packages directories, then consider supporting
  installation for multiple Python versions.
  Please read section "Types of packages" in documentation [1] to decide
  if this package can support installation for multiple Python versions.

- Ensure that the ebuilds do not use deprecated functions or variables.

- Please check if Python 3 is supported by this package. You can temporarily
  set Python 3 as main active version of Python to properly test if this
  package supports Python 3.

- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
    Please read section "Specification of dependency on Python" in
    documentation [1].

  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
    python_set_active_version().

  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)
    Please read section "Shebangs in installed scripts" in documentation [1].

  - To ensure that changes applied to the ebuilds are sufficient, please
    temporarily set Python 3 as main active version of Python and test if
    this package can be properly installed and if it works at run time.

Please see documentation [1] for more details.
[1] http://www.gentoo.org/proj/en/Python/developersguide.xml
Comment 1 Jory A. Pratt gentoo-dev 2010-04-18 17:17:11 UTC
we do not need to worry about this at all. We only use python for a few calls over python scripts. We do not care about python version all are supported.
Comment 2 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-04-18 19:44:02 UTC
The scripts used by build system don't support Python 3.

configure.in contains the following code:
MOZ_PATH_PROGS(PYTHON, $PYTHON python2.5 python2.4 python)
if test -z "$PYTHON"; then
    AC_MSG_ERROR([python was not found in \$PATH])
fi

When python2.5 or python2.4 are present, then they are used instead of active version of Python (which might be python3.1). The ebuild should export PYTHON variable, so that active version of Python is used.
Comment 3 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-04-18 19:46:06 UTC
Created attachment 228323 [details]
xulrunner-1.9.2.3-r1:20100418-194108.log

This is the build log of installation without any custom changes to the ebuild and when python2.5 and python2.4 are absent.
Comment 4 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-04-18 19:57:19 UTC
Created attachment 228327 [details, diff]
xulrunner-1.9.2.3-r1.ebuild.patch

The patch exports PYTHON="$(PYTHON)", so that active version of Python is checked before python2.5 and python2.4, as was explained in comment #2.

'python_set_active_version 2' causes that PYTHON() function (and other functions not used in this ebuild) print values for active version of Python 2, instead of main active version of Python.
Comment 5 Jory A. Pratt gentoo-dev 2010-04-20 12:58:53 UTC
(In reply to comment #4)
> Created an attachment (id=228327) [details]
> xulrunner-1.9.2.3-r1.ebuild.patch
> 
> The patch exports PYTHON="$(PYTHON)", so that active version of Python is
> checked before python2.5 and python2.4, as was explained in comment #2.
> 
> 'python_set_active_version 2' causes that PYTHON() function (and other
> functions not used in this ebuild) print values for active version of Python 2,
> instead of main active version of Python.
> 

ack feel free to commit it. 
Comment 6 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-04-20 20:11:57 UTC
Fixed.