Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 315321 - net-libs/rb_libtorrent: Verify and potentially improve Python-related code
Summary: net-libs/rb_libtorrent: Verify and potentially improve Python-related code
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Gentoo net-p2p team
URL:
Whiteboard:
Keywords:
: 347367 (view as bug list)
Depends on:
Blocks: 308257
  Show dependency tree
 
Reported: 2010-04-14 21:03 UTC by Arfrever Frehtes Taifersar Arahesis (RETIRED)
Modified: 2011-04-15 20:14 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
make it depend on python-2* instead of 2.6 (rb_libtorrent-python-2.patch,484 bytes, patch)
2010-09-10 09:26 UTC, John Smith
Details | Diff
rb_libtorrent.ebuild.diff (rb_libtorrent.ebuild.diff,1.06 KB, patch)
2011-02-25 20:07 UTC, Pacho Ramos
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-04-14 21:03:28 UTC
- If this package can be used as a library and installs Python modules
  (*.so or *.py) into site-packages directories, then consider supporting
  installation for multiple Python versions.
  Please read section "Types of packages" in documentation [1] to decide
  if this package can support installation for multiple Python versions.

- Ensure that the ebuilds do not use deprecated functions or variables.

- Please check if Python 3 is supported by this package. You can temporarily
  set Python 3 as main active version of Python to properly test if this
  package supports Python 3.

- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
    Please read section "Specification of dependency on Python" in
    documentation [1].

  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
    python_set_active_version().

  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)
    Please read section "Shebangs in installed scripts" in documentation [1].

  - To ensure that changes applied to the ebuilds are sufficient, please
    temporarily set Python 3 as main active version of Python and test if
    this package can be properly installed and if it works at run time.

Please see documentation [1] for more details.
[1] http://www.gentoo.org/proj/en/Python/developersguide.xml
Comment 1 John Smith 2010-09-10 09:26:35 UTC
Created attachment 246670 [details, diff]
make it depend on python-2* instead of 2.6

rb_libtorrent works with 2.7 too, so what's the point of hard 2.6 dependency?
Comment 2 Sylvia 2010-12-02 12:56:39 UTC
*** Bug 347367 has been marked as a duplicate of this bug. ***
Comment 3 Pacho Ramos gentoo-dev 2011-02-25 20:07:54 UTC
Created attachment 263839 [details, diff]
rb_libtorrent.ebuild.diff

This patch is needed to let it compile when python3 is the main interpreter. I can commit it if you agree...
Comment 4 Pacho Ramos gentoo-dev 2011-02-25 20:08:21 UTC
(CCing maintainer per metadata.xml)
Comment 5 Markos Chandras (RETIRED) gentoo-dev 2011-02-26 09:27:39 UTC
Pacho please commit it. Thank you
Comment 6 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2011-04-15 20:14:22 UTC
  15 Apr 2011; Pacho Ramos <pacho@gentoo.org> rb_libtorrent-0.15.6.ebuild:
  Needs python2 to compile ok (bug #315321 with Markos Chandras permission).