- If this package can be used as a library and installs Python modules (*.so or *.py) into site-packages directories, then consider supporting installation for multiple Python versions. Please read section "Types of packages" in documentation [1] to decide if this package can support installation for multiple Python versions. - Ensure that the ebuilds do not use deprecated functions or variables. - Please check if Python 3 is supported by this package. You can temporarily set Python 3 as main active version of Python to properly test if this package supports Python 3. - If this package does not support Python 3: - Specify dependency on Python 2. You can use PYTHON_DEPEND helper variable, which should be set before inheriting of python eclass. Please read section "Specification of dependency on Python" in documentation [1]. - If this package cannot support installation for multiple versions of Python, then set active version of Python using python_set_active_version(). - Ensure that shebangs in installed scripts specify correct version of Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you can use python_convert_shebangs() to convert shebangs. (Wrapper scripts generated by python_generate_wrapper_scripts() do not require any changes.) Please read section "Shebangs in installed scripts" in documentation [1]. - To ensure that changes applied to the ebuilds are sufficient, please temporarily set Python 3 as main active version of Python and test if this package can be properly installed and if it works at run time. Please see documentation [1] for more details. [1] http://www.gentoo.org/proj/en/Python/developersguide.xml
+*hamlib-1.2.12-r2 (22 Dec 2010) + + 22 Dec 2010; Thomas Beierlein <tomjbe@gentoo.org> +hamlib-1.2.12-r2.ebuild: + Verify and potentially improve Python-related code, #313257 +
Please replace PYTHON_DEPEND="2" and 'python? ( <dev-lang/python-3 )' in RDEPEND with PYTHON_DEPEND="python? 2". Don't call python_mod_optimize() and python_mod_cleanup() with whole $(python_get_sitedir). Please pass paths to modules installed by this package. In EAPI <=2, you can use: python_mod_optimize $(python_get_sitedir)/{module1.py,module2.py,module3.py} In EAPI >=3, you can use: python_mod_optimize module1.py module2.py module3.py
(In reply to comment #2) > Please replace PYTHON_DEPEND="2" and 'python? ( <dev-lang/python-3 )' in > RDEPEND with PYTHON_DEPEND="python? 2". > > Don't call python_mod_optimize() and python_mod_cleanup() with whole > $(python_get_sitedir). Please pass paths to modules installed by this package. > In EAPI <=2, you can use: > python_mod_optimize $(python_get_sitedir)/{module1.py,module2.py,module3.py} > In EAPI >=3, you can use: > python_mod_optimize module1.py module2.py module3.py > Thanks for pointing that out. Done. + 22 Dec 2010; Thomas Beierlein <tomjbe@gentoo.org> hamlib-1.2.12-r2.ebuild: + Fix last python related changes a suggested by Arfrever +
