Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 313455 - gnome-extra/deskbar-applet: Verify and potentially improve Python-related code
Summary: gnome-extra/deskbar-applet: Verify and potentially improve Python-related code
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High enhancement (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 308257 313471
  Show dependency tree
 
Reported: 2010-04-06 17:04 UTC by Arfrever Frehtes Taifersar Arahesis (RETIRED)
Modified: 2010-10-29 21:57 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-04-06 17:04:26 UTC
- If this package can be used as a library and installs Python modules
  (*.so or *.py) into site-packages directories, then consider supporting
  installation for multiple Python versions.
  Please read section "Types of packages" in documentation [1] to decide
  if this package can support installation for multiple Python versions.

- Ensure that the ebuilds do not use deprecated functions or variables.

- Please check if Python 3 is supported by this package. You can temporarily
  set Python 3 as main active version of Python to properly test if this
  package supports Python 3.

- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
    Please read section "Specification of dependency on Python" in
    documentation [1].

  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
    python_set_active_version().

  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)
    Please read section "Shebangs in installed scripts" in documentation [1].

  - To ensure that changes applied to the ebuilds are sufficient, please
    temporarily set Python 3 as main active version of Python and test if
    this package can be properly installed and if it works at run time.

Please see documentation [1] for more details.
[1] http://www.gentoo.org/proj/en/Python/developersguide.xml
Comment 1 Pacho Ramos gentoo-dev 2010-10-29 21:28:46 UTC
Fixed in 2.32
Comment 2 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-10-29 21:49:12 UTC
python_mod_optimize() and python_mod_cleanup() support multiple arguments:
  python_mod_optimize deskbar /usr/libexec/deskbar-applet/deskbar-applet /usr/libexec/deskbar-applet/modules-2.20-compatible

/usr/libexec/deskbar-applet/deskbar-applet probably should be passed also to python_mod_cleanup().
Comment 3 Pacho Ramos gentoo-dev 2010-10-29 21:57:19 UTC
(In reply to comment #2)
> python_mod_optimize() and python_mod_cleanup() support multiple arguments:
>   python_mod_optimize deskbar /usr/libexec/deskbar-applet/deskbar-applet
> /usr/libexec/deskbar-applet/modules-2.20-compatible
> 

I have left it as-is since it looks to me like a bit more readable and will be probably a bit better for debugging in case python_mod_optimize fails for one of them (this looks a bit to me like "epatch" case, that also supports multiple arguments but it's not used too much in the tree)


> /usr/libexec/deskbar-applet/deskbar-applet probably should be passed also to
> python_mod_cleanup().
> 

Thanks a lot, just fixed