Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 313423 - Version bump: app-admin/smolt-1.4.3
Summary: Version bump: app-admin/smolt-1.4.3
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Sebastian Pipping
URL:
Whiteboard:
Keywords:
: 362687 (view as bug list)
Depends on:
Blocks: 313389
  Show dependency tree
 
Reported: 2010-04-06 15:35 UTC by Samuli Suominen (RETIRED)
Modified: 2011-04-12 22:48 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
proposed smolt-1.4.3 ebuild (smolt-1.4.3.ebuild,2.34 KB, text/plain)
2011-03-29 06:40 UTC, Alexandre Rostovtsev (RETIRED)
Details
diff between smolt-1.4.2.ebuild and smolt-1.4.3.ebuilt (smolt-1.4.3.ebuild.diff,1.27 KB, patch)
2011-03-29 06:42 UTC, Alexandre Rostovtsev (RETIRED)
Details | Diff
smolt-1.4.3-Makefile-py-files.patch (smolt-1.4.3-Makefile-py-files.patch,1.30 KB, patch)
2011-03-29 06:44 UTC, Alexandre Rostovtsev (RETIRED)
Details | Diff
smolt-1.4.3-hwdata-dir.patch (smolt-1.4.3-hwdata-dir.patch,1.90 KB, patch)
2011-03-29 06:48 UTC, Alexandre Rostovtsev (RETIRED)
Details | Diff
Make /etc/smolt/hw-uuid readonly and always display UUID (smolt-1.4.3.ebuild,2.38 KB, text/plain)
2011-03-30 16:19 UTC, Vikraman (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Samuli Suominen (RETIRED) gentoo-dev 2010-04-06 15:35:43 UTC
please mask and remove smolt, it harddeps on hal
Comment 1 Sebastian Pipping gentoo-dev 2010-04-07 05:45:05 UTC
where's the problem?

are you aware smolt is powering
http://smolt.hartwork.org:45678/static/stats/gentoo.html
?
Comment 2 Thilo Bangert (RETIRED) (RETIRED) gentoo-dev 2010-04-07 06:14:27 UTC
hal is to be removed, since it has been deprecated by upstream. we need a smolt release which doesnt use hal. do you know how far upstream is in this regard?
Comment 3 Sebastian Pipping gentoo-dev 2010-04-07 06:20:58 UTC
(In reply to comment #2)
> hal is to be removed, since it has been deprecated by upstream.
> we need a smolt release which doesnt use hal.

somewhere in the future, right.  why the hurry?


> do you know how far upstream is in this regard?

no plans to migrate that i knew of, yet.
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2010-04-07 07:41:37 UTC
(In reply to comment #3)
> (In reply to comment #2)
> > hal is to be removed, since it has been deprecated by upstream.
> > we need a smolt release which doesnt use hal.
> somewhere in the future, right.  why the hurry?

no hurry, hal will be around long as e.g. kde's solid still needs it, X.org 1.8.0 is in tree. the bug is to track the process, might as well change the summary to "track smolt's migration to udev" if you wish.
Comment 5 Sebastian Pipping gentoo-dev 2010-04-07 08:23:41 UTC
i'll take that offer, sounds less dangerous :-)
Comment 6 Sebastian Pipping gentoo-dev 2010-04-07 15:54:56 UTC
update: upstream is considering using python-gudev in the future.
Comment 7 Samuli Suominen (RETIRED) gentoo-dev 2010-12-19 01:33:54 UTC
well, it's been half an year.   it's soon time to start considering on the removal.. :/
Comment 8 Sebastian Pipping gentoo-dev 2010-12-19 13:41:32 UTC
upstream is working on the udev migration by now, see here:
http://git.fedorahosted.org/git/?p=smolt.git;a=commitdiff;h=0def348a3adb796a493d81e579a64c213941e002
Comment 9 Alexandre Rostovtsev (RETIRED) gentoo-dev 2011-03-29 06:40:13 UTC
Created attachment 267625 [details]
proposed smolt-1.4.3 ebuild

Upstream has released smolt-1.4.3 which uses udev instead of hal. The proposed ebuild (successfully tested by me) is attached.

The changes (compared to the 1.4.2 ebuild in the tree):
* depends on pciutils, usbutils, and udev instead of hal.
* the code does not work with python3. Accordingly, we need to set PYTHON_DEPEND and do python_convert_shebangs
* the patches applied by the 1.4.2 ebuild have been integrated by upstream.
* on the other hand, we need to apply some new patches (to install some files upstream's makefile omits and without which smolt fails to run, and to make smolt use Gentoo's /usr/share/misc/{pci,usb}.ids.gz).
* we need to install the distro-specific directory, otherwise smolt will barf a lot of errors.
Comment 10 Alexandre Rostovtsev (RETIRED) gentoo-dev 2011-03-29 06:42:14 UTC
Created attachment 267627 [details, diff]
diff between smolt-1.4.2.ebuild and smolt-1.4.3.ebuilt

diff between the smolt-1.4.2.ebuild in the tree and the above smolt-1.4.3.ebuild (to make it easier to see what changed)
Comment 11 Alexandre Rostovtsev (RETIRED) gentoo-dev 2011-03-29 06:44:15 UTC
Created attachment 267629 [details, diff]
smolt-1.4.3-Makefile-py-files.patch

Patch used by above ebuild. Without it, devicelist.py and hwdata.py do not get installed and smolt will not run.
Comment 12 Alexandre Rostovtsev (RETIRED) gentoo-dev 2011-03-29 06:48:20 UTC
Created attachment 267631 [details, diff]
smolt-1.4.3-hwdata-dir.patch

Patch used by the above ebuild to allow smolt to read gzip-compressed pci and usb ids, and to look for them in a directory other than the Fedora-specific /usr/share/hwdata
Comment 13 Alexandre Rostovtsev (RETIRED) gentoo-dev 2011-03-29 07:26:24 UTC
Note: I have submitted the above two patches upstream at https://fedorahosted.org/smolt/ticket/88 and https://fedorahosted.org/smolt/ticket/89
Comment 14 Vikraman (RETIRED) gentoo-dev 2011-03-30 16:19:29 UTC
Created attachment 267845 [details]
Make /etc/smolt/hw-uuid readonly and always display UUID

Slight enhancement, make /etc/smolt/hw-uuid readonly, and display the UUID even if it already exists
Comment 15 Sebastian Pipping gentoo-dev 2011-04-01 21:59:25 UTC
Thanks for your effort sso far!  I will need more time to get to this in detail, though.
Comment 16 Samuli Suominen (RETIRED) gentoo-dev 2011-04-09 09:43:56 UTC
*** Bug 362687 has been marked as a duplicate of this bug. ***
Comment 17 Samuli Suominen (RETIRED) gentoo-dev 2011-04-09 09:44:28 UTC
(In reply to comment #15)
> Thanks for your effort sso far!  I will need more time to get to this in
> detail, though.

Are the ebuilds fine for committing, or should I package.mask smolt?
Comment 18 Sebastian Pipping gentoo-dev 2011-04-09 17:56:42 UTC
(In reply to comment #9)
> The changes (compared to the 1.4.2 ebuild in the tree):
> * depends on pciutils, usbutils, and udev instead of hal.
> [..]
> * on the other hand, we need to apply some new patches (to install some files
> upstream's makefile omits and without which smolt fails to run, and to make
> smolt use Gentoo's /usr/share/misc/{pci,usb}.ids.gz).

First of all good catch on the hwdata stuff!

Your patches seem to add gzip support for *.gz files in /usr/share/hwdata, not /usr/share/misc/.  Is that by intention?  Also, it seems there is both pci.ids.gz and pci.ids - why not use the plan text one?  After decompression, contents are equal.

For /usr/share/hwdata/* it seems we need to depend on either sys-apps/hwdata-gentoo or sys-apps/hwdata-redhat.  (These two packages are in conflict for /usr/share/hwdata/MonitorsDB).

Content of sys-apps/hwdata-gentoo
- /usr/share/hwdata
- /usr/share/hwdata/Cards
- /usr/share/hwdata/MonitorsDB     *
- /usr/share/hwdata/blacklist
- /usr/share/hwdata/pcitable

Files from sys-apps/hwdata-redhat
- /usr/share/hwdata/MonitorsDB     *
- /usr/share/hwdata/oui.txt
- /usr/share/hwdata/pci.ids          **
- /usr/share/hwdata/upgradelist
- /usr/share/hwdata/usb.ids          **
- /usr/share/hwdata/videodrivers

If we need usb.ids and pci.ids we can choose from sys-apps/hwdata-redhat or both of pciutils and usbutils.  Fromer seems to be less up to date.  Neither packages is up to date with <http://www.linux-usb.org/usb.ids>.

I still have to check what Smolt is actually doing with that content.

Alexandre, what do you think?


(In reply to comment #17)
> Are the ebuilds fine for committing, or should I package.mask smolt?

Not ready yet.  Please don't mask before Monday 08:00 UTC.  There's a chance I have bumped it by then.
Comment 19 Alexandre Rostovtsev (RETIRED) gentoo-dev 2011-04-09 18:13:48 UTC
(In reply to comment #18)
> Your patches seem to add gzip support for *.gz files in /usr/share/hwdata, not
> /usr/share/misc/.  Is that by intention?  Also, it seems there is both
> pci.ids.gz and pci.ids - why not use the plan text one?  After decompression,
> contents are equal.

My patch adds support for .gz files in HWDATA_DIR, which is set to /usr/share/hwdata by default (so that the patch gets accepted by upstream) but can be changed in /etc/smolt/config.py; and my ebuild seds config.py to set HWDATA_DIR=\"${ROOT}/usr/share/misc

Also, I believe that pci.ids in Gentooo is going away at some point soon.
Comment 20 Alexandre Rostovtsev (RETIRED) gentoo-dev 2011-04-09 18:15:52 UTC
(In reply to comment #19)

err, I meant HWDATA_DIR="${ROOT}/usr/share/misc"
Comment 21 Sebastian Pipping gentoo-dev 2011-04-10 18:35:34 UTC
+*smolt-1.4.3 (10 Apr 2011)
+
+  10 Apr 2011; Sebastian Pipping <sping@gentoo.org> +smolt-1.4.3.ebuild,
+  +files/smolt-1.4.3-disable-distro-data.patch,
+  +files/smolt-1.4.3-hwdata-dir.patch,
+  +files/smolt-1.4.3-makefile-py-files.patch:
+  Bump to 1.4.3 which is using udev, not HAL. Add dependencies udev, usbutils,
+  pciutils, sed. Collection of gentoo-specific data is disabled until the
+  server machine can actually handle such data. Many thanks to Alexandre
+  Rostovtsev for research and patches. (bug #313423)
+
Comment 22 Sebastian Pipping gentoo-dev 2011-04-12 22:48:43 UTC
@Alexandre
Your patches are now upstream.