Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 313129 - gnome-base/gnome-applets-2.30.0 hal USE flag only pertinent for battstat
Summary: gnome-base/gnome-applets-2.30.0 hal USE flag only pertinent for battstat
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High trivial (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: gnome2.30
  Show dependency tree
 
Reported: 2010-04-04 20:07 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2010-07-14 11:29 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2010-04-04 20:07:19 UTC 
The only use of HAL in gnome-applets is if battstat applet is built, and it should thus be put under conditional for apm, acpi or ppc.
Comment 1 Gilles Dartiguelongue (RETIRED) gentoo-dev 2010-04-06 12:49:09 UTC 
we should actually remove apm & acpi use flag since they are not used for anything else than global use flag context analysis.
Comment 2 Priit Laes (IRC: plaes) 2010-05-20 05:57:35 UTC 
I made following change to ebuild and pushed to gnome-overlay:

HALDEPEND=" hal? ( >=sys-apps/hal-0.5.3 ) "
DEPEND="...
    apm? ( sys-apps/apmd $HALDEPEND )
    acpi? ( $HALDEPEND )
    ..."
Comment 3 Pacho Ramos gentoo-dev 2010-06-16 11:51:21 UTC 
Any more change is needed on this?
Comment 4 Pacho Ramos gentoo-dev 2010-06-27 12:11:58 UTC 
Is this enough or we should drop acpi and apm flags?
Comment 5 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-06-27 12:22:27 UTC 
I'm fine with plaes's change, but I guess you might replace all of them with a battery USE flag or something... but it's not my place to say.
Comment 6 Pacho Ramos gentoo-dev 2010-07-12 13:14:38 UTC 
Fixed
Comment 7 rafnov 2010-07-14 07:20:32 UTC 
After updating this ebuild on my laptop there is NO battery applet.
Comment 8 Pacho Ramos gentoo-dev 2010-07-14 11:29:03 UTC 
+*gnome-applets-2.30.0-r1 (14 Jul 2010)
+
+  14 Jul 2010; Pacho Ramos <pacho@gentoo.org> -gnome-applets-2.30.0.ebuild,
+  +gnome-applets-2.30.0-r1.ebuild:
+  Revision bump to really install battstat applet when requested since
+  configure doesn't honor use_enable (thanks to rafnov for noticing). Also
+  drop doc USE flag since it is not used at all.

Should be fixed now