Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 312827 - media-video/dirac-1.0.2 installs unit test application and does not use it for testing
Summary: media-video/dirac-1.0.2 installs unit test application and does not use it fo...
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on: 386965
Blocks:
  Show dependency tree
 
Reported: 2010-04-02 15:05 UTC by Hans de Graaff
Modified: 2018-03-01 11:10 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
diff -u dirac-1.0.2.ebuild dirac-1.0.2-r1.ebuild (dirac-1.0.2-r1.ebuild,1.92 KB, patch)
2010-12-27 21:59 UTC, Martin Walch
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hans de Graaff gentoo-dev Security 2010-04-02 15:05:22 UTC
media-video/dirac-1.0.2 install /usr/bin/dirac_unittest which appears to be an application specific to running the unit tests. Instead of installing it, the ebuild should run its tests (all of which pass, I'm happy to say).
Comment 1 Martin Walch 2010-12-27 21:56:54 UTC
This happens only if dev-util/cppunit is installed. I guess Dirac should handle tests explicitely with a flag in IUSE etc. Furthermore create_dirac_testfile.pl needs perl. And there are more things:

- have a test flag in IUSE
- depend on dev-util/cppunit and dev-lang/perl if FEATURES=="test"
- then also run the tests instead of installing the binary
- explicitely neither build nor run the tests if not FEATURES=="test"
- HOMEPAGE and SRC_URI might better point to diracvideo.org
- mmx use flag is not being respected. The produced configure file fails to handle a compiler name like x86_64-pc-linux-gnu-g++
- sort IUSE etc. alphabetically
Comment 2 Martin Walch 2010-12-27 21:59:07 UTC
Created attachment 258218 [details, diff]
diff -u dirac-1.0.2.ebuild dirac-1.0.2-r1.ebuild

This patch does not handle all the problems. I do not know how to fix properly:

- the broken handling of mmx support
- making the testing stuff optional and to separate it from the other parts