Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 312179 - dev-libs/clearsilver: Verify and potentially improve Python-related code
Summary: dev-libs/clearsilver: Verify and potentially improve Python-related code
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Gentoo Web Application Packages Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 308257
  Show dependency tree
 
Reported: 2010-03-30 19:35 UTC by Arfrever Frehtes Taifersar Arahesis (RETIRED)
Modified: 2012-03-16 02:33 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild patch (clearsilver.patch,2.03 KB, patch)
2011-11-13 10:07 UTC, Ian Delaney (RETIRED)
Details | Diff
revised ebuild patch (clearsilver.patch,2.09 KB, patch)
2011-11-18 17:03 UTC, Ian Delaney (RETIRED)
Details | Diff
revised ebuild patch (clearsilver.patch,2.10 KB, patch)
2011-11-21 14:04 UTC, Ian Delaney (RETIRED)
Details | Diff
revised ebuild patch (clearsilver.patch,2.10 KB, patch)
2011-11-24 19:58 UTC, Ian Delaney (RETIRED)
Details | Diff
revised ebuild patch (lash.patch,1.35 KB, patch)
2011-11-25 20:18 UTC, Ian Delaney (RETIRED)
Details | Diff
revised ebuild patch (clearsilver.patch,2.08 KB, patch)
2011-11-26 12:49 UTC, Ian Delaney (RETIRED)
Details | Diff
clearsilver-0.10.5-r1.ebuild.patch (clearsilver-0.10.5-r1.ebuild.patch,1.65 KB, patch)
2011-11-27 19:03 UTC, Arfrever Frehtes Taifersar Arahesis
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-03-30 19:35:43 UTC
- If this package can be used as a library and installs Python modules
  (*.so or *.py) into site-packages directories, then consider supporting
  installation for multiple Python versions.
  Please read section "Types of packages" in documentation [1] to decide
  if this package can support installation for multiple Python versions.

- Ensure that the ebuilds do not use deprecated functions or variables.

- Please check if Python 3 is supported by this package. You can temporarily
  set Python 3 as main active version of Python to properly test if this
  package supports Python 3.

- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
    Please read section "Specification of dependency on Python" in
    documentation [1].

  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
    python_set_active_version().

  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)
    Please read section "Shebangs in installed scripts" in documentation [1].

  - To ensure that changes applied to the ebuilds are sufficient, please
    temporarily set Python 3 as main active version of Python and test if
    this package can be properly installed and if it works at run time.

Please see documentation [1] for more details.
[1] http://www.gentoo.org/proj/en/Python/developersguide.xml
Comment 1 Ian Delaney (RETIRED) gentoo-dev 2011-11-13 10:07:43 UTC
Created attachment 292371 [details, diff]
ebuild patch

Tested for usual {2.6 2.7 3.1 3.2},  all ok.  Usual bump to EAPI 3.
Comment 2 Arfrever Frehtes Taifersar Arahesis 2011-11-14 17:16:40 UTC
Use PYTHON_DEPEND="python? 2".
python_pkg_setup() and python_convert_shebangs() should be called only with USE="python".

Maybe call python_set_active_version():

pkg_setup() {
	if use python; then
		python_set_active_version 2
		python_pkg_setup
	fi
}
Comment 3 Ian Delaney (RETIRED) gentoo-dev 2011-11-18 17:03:24 UTC
Created attachment 292995 [details, diff]
revised ebuild patch

ok done
Comment 4 Arfrever Frehtes Taifersar Arahesis 2011-11-20 03:34:17 UTC
(In reply to comment #3)

python_convert_shebangs() should be called only with USE="python".

Don't change DESTDIR="${D}" to DESTDIR="${ED}".
Comment 5 Ian Delaney (RETIRED) gentoo-dev 2011-11-21 14:04:16 UTC
Created attachment 293313 [details, diff]
revised ebuild patch
Comment 6 Arfrever Frehtes Taifersar Arahesis 2011-11-23 17:56:35 UTC
(In reply to comment #5)

Delete 'python? ( dev-lang/python )' from DEPEND.
Comment 7 Ian Delaney (RETIRED) gentoo-dev 2011-11-24 19:58:10 UTC
Created attachment 293635 [details, diff]
revised ebuild patch

This took an unexpected turn.  The initial build failure took place from emerging in a different gentoo.  After much investigating, the lack of current ruby support invokes an install failure, access violation.  finally determined system that would emerge it had NO ruby installed, other did. For the bug that isn't, 
if {{ system has dev-lang/ruby ]], throw a warning and bail out.  Perhaps there's another preferred option, but that's what I used here.

AND, the shebang fixer did call die with the adjusted python.eclass, removed from this patch.
How's that for value?
Comment 8 Arfrever Frehtes Taifersar Arahesis 2011-11-25 19:16:35 UTC
(In reply to comment #7)

This patch is identical to previous patch.
Comment 9 Ian Delaney (RETIRED) gentoo-dev 2011-11-25 20:18:55 UTC
Created attachment 293757 [details, diff]
revised ebuild patch

sorry, getting mixed up between systems and versions,. double checked this 1.
Comment 10 Arfrever Frehtes Taifersar Arahesis 2011-11-25 23:38:20 UTC
(In reply to comment #9)

This patch is for media-sound/lash.
Comment 11 Ian Delaney (RETIRED) gentoo-dev 2011-11-26 12:49:59 UTC
Created attachment 293831 [details, diff]
revised ebuild patch
Comment 12 Arfrever Frehtes Taifersar Arahesis 2011-11-27 19:03:15 UTC
Created attachment 293967 [details, diff]
clearsilver-0.10.5-r1.ebuild.patch