Bug 312133 – dev-libs/Ice: Verify and potentially improve Python-related code

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-03-30 16:57:18 UTC]

- If this package can be used as a library and installs Python modules
  (*.so or *.py) into site-packages directories, then consider supporting
  installation for multiple Python versions.
  Please read section "Types of packages" in documentation [1] to decide
  if this package can support installation for multiple Python versions.

- Ensure that the ebuilds do not use deprecated functions or variables.

- Please check if Python 3 is supported by this package. You can temporarily
  set Python 3 as main active version of Python to properly test if this
  package supports Python 3.

- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
    Please read section "Specification of dependency on Python" in
    documentation [1].

  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
    python_set_active_version().

  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)
    Please read section "Shebangs in installed scripts" in documentation [1].

  - To ensure that changes applied to the ebuilds are sufficient, please
    temporarily set Python 3 as main active version of Python and test if
    this package can be properly installed and if it works at run time.

Please see documentation [1] for more details.
[1] http://www.gentoo.org/proj/en/Python/developersguide.xml

[Comment 1 Tiziano Müller (RETIRED) 2010-06-09 20:24:37 UTC]

Done in 3.3.1-r2 and 3.4.0.

[Comment 2 Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-06-09 21:09:18 UTC]

The ebuild doesn't support installation for multiple Python ABIs (e.g. 2.5 and 2.6) simultaneously, but it seems to be easy to support it.

[Comment 3 Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-06-09 21:10:52 UTC]

Created attachment 234783 [details, diff]
Ice-3.4.0.ebuild.patch

I'm attaching untested patch, which probably works correctly.

[Comment 4 Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-06-09 21:26:58 UTC]

(In reply to comment #3)

With this patch, EAPI="3" wouldn't need to be set in pkg_postinst()/pkg_postrm().

[Comment 5 Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-06-10 13:53:24 UTC]

Created attachment 234853 [details, diff]
Ice-3.4.0.ebuild.patch

I'm attaching updated patch.

[Comment 6 Martin von Gagern 2010-06-12 09:13:46 UTC]

(In reply to comment #5)
> I'm attaching updated patch.

That patch solves most aspects of bug #323653 as well.

[Comment 7 Tiziano Müller (RETIRED) 2010-06-13 16:14:54 UTC]

Done, thanks.