Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 311789 - app-portage/portato: Verify and potentially improve Python-related code
Summary: app-portage/portato: Verify and potentially improve Python-related code
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Markus Ullmann (RETIRED)
Depends on:
Blocks: 308257
  Show dependency tree
Reported: 2010-03-28 16:12 UTC by Arfrever Frehtes Taifersar Arahesis (RETIRED)
Modified: 2010-04-13 14:57 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Ebuild patch (portato-0.13.1.ebuild.diff,1.83 KB, patch)
2010-04-10 19:10 UTC, René 'Necoro' Neumann
Details | Diff
Fixed ebuild patch (portato-0.13.1.ebuild.diff,1.81 KB, patch)
2010-04-13 01:29 UTC, René 'Necoro' Neumann
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-03-28 16:12:14 UTC
- If this package can be used as a library and installs Python modules
  (*.so or *.py) into site-packages directories, then consider supporting
  installation for multiple Python versions.
  Please read section "Types of packages" in documentation [1] to decide
  if this package can support installation for multiple Python versions.

- Ensure that the ebuilds do not use deprecated functions or variables.

- Please check if Python 3 is supported by this package. You can temporarily
  set Python 3 as main active version of Python to properly test if this
  package supports Python 3.

- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
    Please read section "Specification of dependency on Python" in
    documentation [1].

  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using

  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)
    Please read section "Shebangs in installed scripts" in documentation [1].

  - To ensure that changes applied to the ebuilds are sufficient, please
    temporarily set Python 3 as main active version of Python and test if
    this package can be properly installed and if it works at run time.

Please see documentation [1] for more details.
Comment 1 René 'Necoro' Neumann 2010-04-10 19:10:23 UTC
Created attachment 227293 [details, diff]
Ebuild patch

Here is the patch for the ebuild. I would also vote for a revbump of the package.
Comment 2 René 'Necoro' Neumann 2010-04-13 01:29:25 UTC
Created attachment 227543 [details, diff]
Fixed ebuild patch

Fixed the patch. For some reason, python_pkg_setup is not exported for EAPI=2 and I haven't realized it.
Comment 3 René 'Necoro' Neumann 2010-04-13 01:35:20 UTC
Ignore my last comment ... the reason that python_pkg_setup is not exported, is that I didn't declare PYTHON_USE_WITH... As I do not need it, the fix is still valid and necessary.

Conclusion: The fixed ebuild is really fixed ... but the comment about why is wrong :)
Comment 4 Christian Ruppert (idl0r) gentoo-dev 2010-04-13 14:57:46 UTC
Fixed in CVS, thanks René.