Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 310435 - media-video/dvdstyler-1.8.0.2 - Version bump
Summary: media-video/dvdstyler-1.8.0.2 - Version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Daniel Black (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-20 21:04 UTC by Daniel Pielmeier
Modified: 2010-04-28 19:02 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
dvdstyler-1.8.0.2.diff (dvdstyler-1.8.0.2.diff,1004 bytes, patch)
2010-03-21 13:23 UTC, Daniel Pielmeier
Details | Diff
dvdstyler-1.8.0.2-autoconf.patch (dvdstyler-1.8.0.2-autoconf.patch,689 bytes, patch)
2010-03-21 13:24 UTC, Daniel Pielmeier
Details | Diff
dvdstyler-1.8.0.2-autoconf.patch (dvdstyler-1.8.0.2-autoconf.patch,1.02 KB, patch)
2010-03-21 16:58 UTC, Daniel Pielmeier
Details | Diff
dvdstyler-1.8.1_beta1.diff (dvdstyler-1.8.1_beta1.diff,1.27 KB, patch)
2010-04-12 20:46 UTC, Daniel Pielmeier
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Pielmeier gentoo-dev 2010-03-20 21:04:24 UTC
Released 2010-03-16.
Comment 1 Daniel Black (RETIRED) gentoo-dev 2010-03-21 02:49:57 UTC
Daniel,

If you want to add it go for it.

Daniel
Comment 2 Daniel Pielmeier gentoo-dev 2010-03-21 13:23:57 UTC
Created attachment 224493 [details, diff]
dvdstyler-1.8.0.2.diff

Before I commit I will add my changes here for discussion.


Moved virtual/cdrtools >=media-video/dvdauthor-0.6.14 >=app-cdr/dvd+rw-tools-7.1 to COMMON_DEPEND as configure checks for them at compile time.

Added app-arch/zip to DEPEND as configure checks for it.

New autoconf patch as the previous one was not fully applied. docsdir is still redefined in docs/Makefile.am and mktemp is only used once. I guess you are in contact with upstream so you probably know why this part is missing.
Comment 3 Daniel Pielmeier gentoo-dev 2010-03-21 13:24:25 UTC
Created attachment 224495 [details, diff]
dvdstyler-1.8.0.2-autoconf.patch
Comment 4 Daniel Pielmeier gentoo-dev 2010-03-21 16:58:35 UTC
Created attachment 224553 [details, diff]
dvdstyler-1.8.0.2-autoconf.patch

It looks like upstream forgot to add the templates dir in the top Makefile.am. Updated patch so templates get installed else dvdstyler crashes if the files are missing and you want to use the provided templates.
Comment 5 Daniel Black (RETIRED) gentoo-dev 2010-03-22 05:26:08 UTC
looks ok.

remember upstream took part of the patch. forget what they said about mktemp - its probably written on a sourceforge bug.

I'm really happy if you take this package over or at least comaintained it.
Comment 6 Daniel Pielmeier gentoo-dev 2010-03-22 19:46:00 UTC
(In reply to comment #5)
> looks ok.

Good :)

> remember upstream took part of the patch. forget what they said about mktemp -
> its probably written on a sourceforge bug.

I found your patch on SF. The only additional comment was that it has been applied. I asked the upstream author about it and also informed him about the templates issue.

> I'm really happy if you take this package over or at least comaintained it.

Hey I can not take all your packages :) Lets see if I add myself as co-maintainer.
Comment 7 Daniel Pielmeier gentoo-dev 2010-04-12 20:46:09 UTC
Created attachment 227535 [details, diff]
dvdstyler-1.8.1_beta1.diff

The attached beta version includes only minor changes and does now install the templates which were missing in 1.8.0.2.

The html% part does not really need mktemp as this is only used for updating the websites help content.

Docdir is respected but the help_lang.zip files are still placed at
/usr/share/dvdstyler/docs because dvdstyler is searching them there.
Using a --docdir for the complete documentation is on the upstream to-do list.

So I would say patching is not needed at the moment and the remaining issue about the doc patch will be fixed upstream in the next versions.

@Daniel are you okay with the new diff?
Comment 8 Daniel Pielmeier gentoo-dev 2010-04-28 19:02:51 UTC
Bumped to dvdstyler-1.8.1_beta1.