Bug 309039 – gnome-python-common.eclass: Support installation for multiple Python ABIs

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-03-11 19:16:43 UTC]

The patch for gnome-python-common.eclass adds support for installation for multiple Python ABIs, adds support for EAPI >=2 (all ebuilds in gentoo-x86 using this eclass currently use EAPI 0 or 1) and removes deprecation warnings.

[Comment 1 Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-03-11 19:17:47 UTC]

Created attachment 223185 [details, diff]
gnome-python-common.eclass.patch

[Comment 2 Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-03-13 15:08:20 UTC]

Created attachment 223419 [details, diff]
Updated gnome-python-common.eclass.patch

[Comment 3 Priit Laes (IRC: plaes) 2010-03-26 21:17:30 UTC]

(In reply to comment #2)
> Created an attachment (id=223419) [details]
> Updated gnome-python-common.eclass.patch
> 

Committed to GNOME overlay.

[Comment 4 Rafał Mużyło 2010-05-10 16:29:34 UTC]

*** Bug 319117 has been marked as a duplicate of this bug. ***

[Comment 5 Gilles Dartiguelongue (RETIRED) 2010-05-16 09:23:30 UTC]

*** Bug 319079 has been marked as a duplicate of this bug. ***

[Comment 6 Gilles Dartiguelongue (RETIRED) 2010-05-16 09:23:39 UTC]

*** Bug 319081 has been marked as a duplicate of this bug. ***

[Comment 7 Gilles Dartiguelongue (RETIRED) 2010-05-19 08:04:14 UTC]

*** Bug 320453 has been marked as a duplicate of this bug. ***

[Comment 8 Gilles Dartiguelongue (RETIRED) 2010-05-19 08:05:27 UTC]

*** Bug 320451 has been marked as a duplicate of this bug. ***

[Comment 9 Gilles Dartiguelongue (RETIRED) 2010-05-19 08:07:30 UTC]

*** Bug 320455 has been marked as a duplicate of this bug. ***

[Comment 10 Rémi Cardona (RETIRED) 2010-05-22 11:34:16 UTC]

*** Bug 320883 has been marked as a duplicate of this bug. ***

[Comment 11 Rafał Mużyło 2010-05-24 13:53:59 UTC]

*** Bug 321305 has been marked as a duplicate of this bug. ***

[Comment 12 Gilles Dartiguelongue (RETIRED) 2010-05-27 12:33:59 UTC]

Created attachment 233119 [details, diff]
Updated gnome-python-common.eclass.patch wrt. #309041

Here is an updated patch according to your comments in #309041.

[Comment 13 Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-05-27 12:54:34 UTC]

Please export pkg_postinst() and pkg_postrm() also in EAPI >=2. They are currently exported in all EAPIs, but this patch causes exporting of them only in EAPI <2.

I suggest to call python_pkg_setup() in gnome-python-common_pkg_setup() for compatibility with planned changes in python.eclass in EAPI >=4.

[Comment 14 Gilles Dartiguelongue (RETIRED) 2010-05-27 13:46:01 UTC]

Created attachment 233133 [details, diff]
Updated eclass per comment #13

> Please export pkg_postinst() and pkg_postrm() also in EAPI >=2. They are
> currently exported in all EAPIs, but this patch causes exporting of them only
> in EAPI <2.

oops, fixed

> I suggest to call python_pkg_setup() in gnome-python-common_pkg_setup() for
> compatibility with planned changes in python.eclass in EAPI >=4.

done

[Comment 15 Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-05-27 13:52:27 UTC]

To improve readability, I suggest to pass phase names to EXPORT_FUNCTIONS() in the order, in which given phases are executed, i.e. src_prepare before src_configure :) .

All other changes look good.

[Comment 16 Gilles Dartiguelongue (RETIRED) 2010-05-27 15:11:25 UTC]

Ok, I'll do this with the copyright/inherit changes you did in your patch before commiting.

[Comment 17 Gilles Dartiguelongue (RETIRED) 2010-05-31 21:04:19 UTC]

Changes to the eclass have been commited. Please reopen if anything is still wrong. Thanks for your contributions.

[Comment 18 Gilles Dartiguelongue (RETIRED) 2010-09-15 18:20:18 UTC]

*** Bug 326873 has been marked as a duplicate of this bug. ***