Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 308353 - app-doc/doxygen: Verify and potentially improve Python-related code
Summary: app-doc/doxygen: Verify and potentially improve Python-related code
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Highest normal (vote)
Assignee: Steve Arnold
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 308257
  Show dependency tree
 
Reported: 2010-03-07 17:53 UTC by Arfrever Frehtes Taifersar Arahesis (RETIRED)
Modified: 2012-02-15 11:30 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild patch (doxygen.patch,2.22 KB, patch)
2011-11-12 10:31 UTC, Ian Delaney (RETIRED)
Details | Diff
ebuild patch revised (doxygen.patch,2.22 KB, patch)
2011-11-14 08:41 UTC, Ian Delaney (RETIRED)
Details | Diff
revised ebuild patch (doxygen.patch,1.78 KB, patch)
2011-11-15 06:12 UTC, Ian Delaney (RETIRED)
Details | Diff
revised ebuild patch (doxygen.patch,2.78 KB, patch)
2011-11-17 01:24 UTC, Ian Delaney (RETIRED)
Details | Diff
revised ebuild patch (doxygen.patch,2.30 KB, patch)
2011-11-18 10:18 UTC, Ian Delaney (RETIRED)
Details | Diff
revised ebuild patch (doxygen.patch,2.30 KB, patch)
2011-11-18 10:39 UTC, Ian Delaney (RETIRED)
Details | Diff
revised ebuild patch (doxygen.patch,2.62 KB, patch)
2011-11-21 09:22 UTC, Ian Delaney (RETIRED)
Details | Diff
revised ebuild patch (doxygen.patch,2.62 KB, patch)
2011-11-24 20:15 UTC, Ian Delaney (RETIRED)
Details | Diff
revised ebuild patch (doxygen.patch,1.13 KB, patch)
2011-11-24 21:18 UTC, Ian Delaney (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-03-07 17:53:17 UTC
- If this package could support installation for multiple versions of Python,
  then please try to adjust the ebuilds to support it.
- Ensure that the ebuilds do not use deprecated functions or variables.
- Please check if Python 3 is supported by this package.
- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
    python_set_active_version().
  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)

Please see documentation [1] for more details.
[1] http://www.gentoo.org/proj/en/Python/developersguide.xml
Comment 1 Ian Delaney (RETIRED) gentoo-dev 2011-11-12 10:31:35 UTC
Created attachment 292265 [details, diff]
ebuild patch

emerge doesn't seem to work on python 2.5, so can never be included.  Used python 2.6 2.6 3.1 3.2, emerging all AOK.  EAPI originally set at 3.
Comment 2 Arfrever Frehtes Taifersar Arahesis 2011-11-13 02:01:46 UTC
Portage itself requires Python >=2.6 and it has no relation to Python version required by other packages. If you install sys-apps/portage with USE="python3", then you will be able to set active version of Python 2 to 2.4 or 2.5 and still use Portage (Portage will use active version of Python 3 regardless of active version of Python 2).

Use PYTHON_DEPEND="2".
Such pkg_setup() is not needed.
python_convert_shebangs() internally calls die().
Comment 3 Ian Delaney (RETIRED) gentoo-dev 2011-11-14 08:41:14 UTC
Created attachment 292483 [details, diff]
ebuild patch revised

I missed a couple of "  || die" s
done
Comment 4 Arfrever Frehtes Taifersar Arahesis 2011-11-14 19:26:30 UTC
(In reply to comment #3)

This patch is identical to the previous patch.
Comment 5 Ian Delaney (RETIRED) gentoo-dev 2011-11-15 06:12:11 UTC
Created attachment 292591 [details, diff]
revised ebuild patch

oh dear, need more practice..done
Comment 6 Arfrever Frehtes Taifersar Arahesis 2011-11-16 18:43:08 UTC
This package doesn't install any Python scripts, so 'python_convert_shebangs -r 2 "${ED}"' is not needed.

This package should only have build-time dependency on Python 2 with USE="doc".

pkg_setup() {
	if use doc; then
		python_set_active_version 2
		python_pkg_setup
	fi
}
Comment 7 Ian Delaney (RETIRED) gentoo-dev 2011-11-17 01:24:18 UTC
Created attachment 292829 [details, diff]
revised ebuild patch
Comment 8 Arfrever Frehtes Taifersar Arahesis 2011-11-18 01:10:46 UTC
(In reply to comment #7)

This patch adds call to 'ython_set_active_version' instead of 'python_set_active_version'.

Please read first and second suggestion from comment #6.
Comment 9 Ian Delaney (RETIRED) gentoo-dev 2011-11-18 10:18:22 UTC
Created attachment 292977 [details, diff]
revised ebuild patch

sheeeeeeesh; practice  practice practice

also for latest, a minor extra

ecompressdir: bzip2 -9 /usr/share/man

 * QA Notice: Files built without respecting LDFLAGS have been detected
 *  Please include the following list of files in your report:
 * /usr/bin/doxywizard
Comment 10 Ian Delaney (RETIRED) gentoo-dev 2011-11-18 10:39:35 UTC
Created attachment 292981 [details, diff]
revised ebuild patch

I wonder
PYTHON_DEPEND="doc? 2"
Comment 11 Arfrever Frehtes Taifersar Arahesis 2011-11-20 02:55:31 UTC
(In reply to comment #9 and comment #10)

Don't use PYTHON_DEPEND, which specifies build-time and run-time dependency.
PYTHON_BDEPEND specifies only build-time dependency, but is not yet supported in gentoo-x86. See bug #323311.

Use 'doc? ( =dev-lang/python-2* )' instead of 'doc? ( dev-lang/python )', and in DEPEND, not RDEPEND.
Comment 12 Ian Delaney (RETIRED) gentoo-dev 2011-11-21 09:22:19 UTC
Created attachment 293285 [details, diff]
revised ebuild patch

this has got to be it
Comment 13 Arfrever Frehtes Taifersar Arahesis 2011-11-23 17:03:11 UTC
(In reply to comment #12)

Don't change DESTDIR="${D}" to DESTDIR="${ED}".
Comment 14 Ian Delaney (RETIRED) gentoo-dev 2011-11-24 20:15:27 UTC
Created attachment 293639 [details, diff]
revised ebuild patch

ditto
Comment 15 Ian Delaney (RETIRED) gentoo-dev 2011-11-24 21:18:05 UTC
Created attachment 293649 [details, diff]
revised ebuild patch

changed systems via chroot, forgot change of local location for prior version, sorry  for the noise
Comment 16 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev 2012-02-14 14:06:50 UTC
+  14 Feb 2012; Kacper Kowalik <xarthisius@gentoo.org> doxygen-1.7.6.1.ebuild:
+  Improve Python-related code wrt #308353 by Arfrever Frehtes Taifersar
+  Arahesis. Thanks to Ian Delaney <johneed@hotmail.com> for the patch
+
Comment 17 Arfrever Frehtes Taifersar Arahesis 2012-02-15 11:26:44 UTC
(In reply to comment #16)

PYTHON_DEPEND adds build-time and run-time dependency on Python, but app-doc/doxygen optionally needs Python only at build time. Patch from comment #15 was better.
Comment 18 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev 2012-02-15 11:30:21 UTC
+  15 Feb 2012; Kacper Kowalik <xarthisius@gentoo.org> doxygen-1.7.6.1.ebuild:
+  Don't RDEPEND on python, thanks to Arfrever Frehtes Taifersar Arahesis
+  <arfrever.fta@gmail.com>