Bug 308343 – app-dicts/ispell-lt: Verify and potentially improve Python-related code

• Status: RESOLVED WONTFIX
• Product: Gentoo Linux

[Description Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-03-07 17:46:31 UTC]

- If this package could support installation for multiple versions of Python,
  then please try to adjust the ebuilds to support it.
- Ensure that the ebuilds do not use deprecated functions or variables.
- Please check if Python 3 is supported by this package.
- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
    python_set_active_version().
  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)

Please see documentation [1] for more details.
[1] http://www.gentoo.org/proj/en/Python/developersguide.xml

[Comment 1 Michael Palimaka (kensington) 2011-08-27 16:27:38 UTC]

Created attachment 284803 [details]
build log

Fails to build with python-3.2


Portage 2.1.10.11 (default/linux/amd64/10.0, gcc-4.5.3-asneeded, glibc-2.13-r4, 2.6.39-gentoo-r3-libre x86_64)
=================================================================
System uname: Linux-2.6.39-gentoo-r3-libre-x86_64-06-17-with-gentoo-2.0.3
Timestamp of tree: Sat, 27 Aug 2011 14:15:01 +0000
app-shells/bash:          4.2_p10
dev-java/java-config:     2.1.11-r3
dev-lang/python:          2.7.1-r1, 3.2-r2
dev-util/pkgconfig:       0.26
sys-apps/baselayout:      2.0.3
sys-apps/openrc:          0.8.3-r1
sys-apps/sandbox:         2.5
sys-devel/autoconf:       2.68
sys-devel/automake:       1.9.6-r3, 1.10.3, 1.11.1-r1
sys-devel/binutils:       2.21.1-r1
sys-devel/gcc:            4.5.3-r1
sys-devel/gcc-config:     1.4.1-r1
sys-devel/libtool:        2.4-r1
sys-devel/make:           3.82-r1
sys-kernel/linux-headers: 2.6.39 (virtual/os-headers)
sys-libs/glibc:           2.13-r4
Repositories: gentoo x-portage
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-march=native -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="assume-digests binpkg-logs buildpkg collision-protect distlocks ebuild-locks fixlafiles fixpackages multilib-strict news parallel-fetch protect-owned sandbox sfperms strict test unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync"
FFLAGS=""
GENTOO_MIRRORS="ftp://mirror.internode.on.net/pub/gentoo/"
LDFLAGS="-Wl,--hash-style=gnu -Wl,--as-needed"
LINGUAS="en"
MAKEOPTS="-j5"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.au.gentoo.org/gentoo-portage"
USE="amd64 multilib" ELIBC="glibc" KERNEL="linux" LINGUAS="en" USERLAND="GNU"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

[Comment 2 Ian Delaney (RETIRED) 2011-11-11 17:29:56 UTC]

Created attachment 292203 [details]
adjusted ebuild

tested, works

archtester ispell-it # eselect python list
Available Python interpreters:
  [1]   python2.6 *
  [2]   python2.7
Fails with selection of python 3.x

[Comment 3 Markos Chandras (RETIRED) 2011-11-11 19:32:38 UTC]

Comment on attachment 292203 [details]
adjusted ebuild

The bug is about ispell-lt not ispell-it

[Comment 4 Ian Delaney (RETIRED) 2011-11-11 19:37:21 UTC]

Created attachment 292213 [details, diff]
ispell-lt.patch

patch for both 1.1 && 1.2.1 ebuild.
Tested and works.  The importing of python eclass makes is able to work with python-3.2,  fails without it

[Comment 5 Arfrever Frehtes Taifersar Arahesis 2011-11-11 19:42:58 UTC]

python_set_active_version(), python_pkg_setup(), python_convert_shebangs() internally call die().

[Comment 6 Ian Delaney (RETIRED) 2011-11-19 15:08:37 UTC]

Created attachment 293095 [details, diff]
revised ebuild patch

[Comment 7 Arfrever Frehtes Taifersar Arahesis 2011-11-20 07:04:31 UTC]

This package probably should have only build-time dependency on Python.
(RDEPEND="${DEPEND}" when RDEPEND is not explicitly set in older EAPIs.)

[Comment 8 Ian Delaney (RETIRED) 2011-11-21 13:16:16 UTC]

Created attachment 293301 [details, diff]
revised ebuild patch

[Comment 9 Arfrever Frehtes Taifersar Arahesis 2011-11-23 17:33:00 UTC]

(In reply to comment #8)

Re-read comment #7.

[Comment 10 Ian Delaney (RETIRED) 2011-11-24 21:14:54 UTC]

Created attachment 293645 [details, diff]
revised ebuild patch

[Comment 11 Arfrever Frehtes Taifersar Arahesis 2011-11-25 19:21:54 UTC]

(In reply to comment #10)

RDEPEND="app-text/ispell"
DEPEND="${RDEPEND}
	=dev-lang/python-2*"

python_convert_shebangs() is probably not needed.

[Comment 12 Ian Delaney (RETIRED) 2011-11-25 21:08:29 UTC]

Created attachment 293767 [details, diff]
revised ebuild patch

[Comment 13 Arfrever Frehtes Taifersar Arahesis 2011-11-25 23:45:18 UTC]

(In reply to comment #12)

Re-read first suggestion from comment #11.

[Comment 14 Ian Delaney (RETIRED) 2011-11-26 13:05:33 UTC]

Created attachment 293835 [details, diff]
revised ebuild patch

[Comment 15 Pacho Ramos 2012-07-21 14:00:01 UTC]

dropped