Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 308339 - app-crypt/openvpn-blacklist: Verify and potentially improve Python-related code
Summary: app-crypt/openvpn-blacklist: Verify and potentially improve Python-related code
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Highest normal (vote)
Assignee: Hanno Böck
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 308257
  Show dependency tree
 
Reported: 2010-03-07 17:45 UTC by Arfrever Frehtes Taifersar Arahesis (RETIRED)
Modified: 2015-10-03 09:27 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild patch (openvpn-blacklist.patch,2.90 KB, patch)
2011-11-11 20:57 UTC, Ian Delaney (RETIRED)
Details | Diff
r (openvpn-blacklist.patch,2.65 KB, patch)
2011-11-19 14:58 UTC, Ian Delaney (RETIRED)
Details | Diff
revised ebuild patch (openvpn-blacklist.patch,2.46 KB, patch)
2011-11-21 16:33 UTC, Ian Delaney (RETIRED)
Details | Diff
revised ebuild patch (openvpn-blacklist.patch,1.45 KB, patch)
2011-11-25 13:41 UTC, Ian Delaney (RETIRED)
Details | Diff
revised ebuild patch (openvpn-blacklist.patch,1.45 KB, patch)
2011-11-26 12:38 UTC, Ian Delaney (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-03-07 17:45:27 UTC
- If this package could support installation for multiple versions of Python,
  then please try to adjust the ebuilds to support it.
- Ensure that the ebuilds do not use deprecated functions or variables.
- Please check if Python 3 is supported by this package.
- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
    python_set_active_version().
  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)

Please see documentation [1] for more details.
[1] http://www.gentoo.org/proj/en/Python/developersguide.xml
Comment 1 Ian Delaney (RETIRED) gentoo-dev 2011-11-11 20:57:48 UTC
Created attachment 292221 [details, diff]
ebuild patch

python 2.6.6-r2, 2.7.2-r3, 3.1, 3.2

All tested and correct.  bumped to EAPI 3.
Comment 2 Arfrever Frehtes Taifersar Arahesis 2011-11-11 21:32:19 UTC
(In reply to comment #1)

Use PYTHON_DEPEND="2". Remove dev-lang/python from DEPEND set in ebuilds. Such pkg_setup() is not needed.
Comment 3 Ian Delaney (RETIRED) gentoo-dev 2011-11-19 14:58:55 UTC
Created attachment 293093 [details, diff]
r
Comment 4 Arfrever Frehtes Taifersar Arahesis 2011-11-20 06:57:59 UTC
(In reply to comment #3)

Read second suggestion from comment #2.
Comment 5 Ian Delaney (RETIRED) gentoo-dev 2011-11-21 16:33:51 UTC
Created attachment 293339 [details, diff]
revised ebuild patch
Comment 6 Arfrever Frehtes Taifersar Arahesis 2011-11-23 20:27:55 UTC
(In reply to comment #5)

python_convert_shebangs() is probably still needed.
Comment 7 Ian Delaney (RETIRED) gentoo-dev 2011-11-25 13:41:48 UTC
Created attachment 293709 [details, diff]
revised ebuild patch
Comment 8 Arfrever Frehtes Taifersar Arahesis 2011-11-25 23:18:55 UTC
(In reply to comment #7)

${ED} should be quoted.
Comment 9 Ian Delaney (RETIRED) gentoo-dev 2011-11-26 12:38:49 UTC
Created attachment 293827 [details, diff]
revised ebuild patch
Comment 10 Pacho Ramos gentoo-dev 2015-10-03 09:27:57 UTC
This approach was changed by the -r1 python eclasses