Bug 308293 – app-arch/createrepo: Verify and potentially improve Python-related code

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-03-07 17:07:03 UTC]

- If this package could support installation for multiple versions of Python,
  then please try to adjust the ebuilds to support it.
- Ensure that the ebuilds do not use deprecated functions or variables.
- Please check if Python 3 is supported by this package.
- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
    python_set_active_version().
  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)

Please see documentation [1] for more details.
[1] http://www.gentoo.org/proj/en/Python/developersguide.xml

[Comment 1 David Abbott (RETIRED) 2010-05-02 23:03:04 UTC]

Created attachment 230091 [details]
createrepo-0.9.8-r1.ebuild

Installs with 2 or 3 but will only work with 2 because of old style print statements.

[Comment 2 Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-05-03 16:47:01 UTC]

You can also remove dev-lang/python from RDEPEND, because PYTHON_DEPEND="2" already changes DEPEND/RDEPEND.

[Comment 3 David Abbott (RETIRED) 2010-05-03 20:37:03 UTC]

Created attachment 230201 [details]
createrepo-0.9.8-r1.ebuild

[Comment 4 Ian Delaney (RETIRED) 2011-11-12 08:05:09 UTC]

Created attachment 292257 [details, diff]
ebuild patch

re-tested
python2 2.5 2.6 2.7 3.1 3.2.  Fails on python 2.5
Adjusted to EAPI 3, minor change D -> ED

[Comment 5 Ian Delaney (RETIRED) 2011-11-12 08:07:22 UTC]

re-assigned.  python team please review.

[Comment 6 Ian Delaney (RETIRED) 2011-11-12 08:42:09 UTC]

correction

@@ -2,7 +2,12

-RDEPEND="dev-lang/python
+RDEPEND=">=dev-python/urlgrabber-2.9.0
-        >=dev-python/urlgrabber-2.9.0

Had not read comment 2

[Comment 7 Maxim Koltsov (RETIRED) 2011-11-12 19:35:57 UTC]

Fixed, thanks Ian.

[Comment 8 Arfrever Frehtes Taifersar Arahesis 2011-11-13 02:39:46 UTC]

(In reply to comment #4 and comment #7)

Portage itself requires Python >=2.6 and it has no relation to Python version
required by other packages. If you install sys-apps/portage with USE="python3",
then you will be able to set active version of Python 2 to 2.4 or 2.5 and still
use Portage (Portage will use active version of Python 3 regardless of active
version of Python 2).

Use PYTHON_DEPEND="2".