Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 308283 - app-admin/syslog-summary: Verify and potentially improve Python-related code
Summary: app-admin/syslog-summary: Verify and potentially improve Python-related code
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Highest normal (vote)
Assignee: Paweł Hajdan, Jr. (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 308257
  Show dependency tree
 
Reported: 2010-03-07 17:03 UTC by Arfrever Frehtes Taifersar Arahesis (RETIRED)
Modified: 2010-03-12 10:22 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-03-07 17:03:04 UTC
- If this package could support installation for multiple versions of Python,
  then please try to adjust the ebuilds to support it.
- Ensure that the ebuilds do not use deprecated functions or variables.
- Please check if Python 3 is supported by this package.
- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
    python_set_active_version().
  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)

Please see documentation [1] for more details.
[1] http://www.gentoo.org/proj/en/Python/developersguide.xml
Comment 1 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2010-03-12 10:22:21 UTC
Thanks, made the following changes to the ebuild:

Index: syslog-summary-1.14.ebuild
===================================================================
RCS file: /var/cvsroot/gentoo-x86/app-admin/syslog-summary/syslog-summary-1.14.ebuild,v
retrieving revision 1.1
diff -u -B -r1.1 syslog-summary-1.14.ebuild
--- syslog-summary-1.14.ebuild	8 Feb 2010 12:38:01 -0000	1.1
+++ syslog-summary-1.14.ebuild	12 Mar 2010 10:18:52 -0000
@@ -3,7 +3,7 @@
 # $Header: /var/cvsroot/gentoo-x86/app-admin/syslog-summary/syslog-summary-1.14.ebuild,v 1.1 2010/02/08 12:38:01 phajdan.jr Exp $
 
 EAPI=2
-NEED_PYTHON="2.5"
+PYTHON_DEPEND="2:2.5"
 
 inherit eutils python
 
@@ -19,6 +19,10 @@
 DEPEND=""
 RDEPEND=""
 
+pkg_setup() {
+	python_set_active_version 2
+}
+
 src_prepare() {
 	python_convert_shebangs 2 syslog-summary