Bug 305105 – media-video/vlc[png] fails to compile against media-libs/libpng-1.4.0

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Lars Wendler (Polynomial-C) (RETIRED) 2010-02-14 18:43:48 UTC]

libtool: compile:  x86_64-pc-linux-gnu-gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../../include -DSYS_LINUX -D_FILE_OFFSET_BITS=64 -D__USE_UNIX98 -D_LARGEFILE64_SOURCE -D_REENTRANT -D_THREAD_SAFE -D__LIBVLC__ -D__PLUGIN__ -DMODULE_NAME=png -DMODULE_NAME_IS_png -DMODULE_STRING=\"png\" -O0 -march=core2 -mtune=core2 -O2 -pipe -Wall -Wextra -Wsign-compare -Wundef -Wpointer-arith -Wbad-function-cast -Wcast-align -Wwrite-strings -Wmissing-prototypes -Wvolatile-register-var -Werror-implicit-function-declaration -MT libpng_plugin_la-png.lo -MD -MP -MF .deps/libpng_plugin_la-png.Tpo -c png.c  -fPIC -DPIC -o .libs/libpng_plugin_la-png.o                                                                    
png.c: In function ‘DecodeBlock’:                                               
png.c:158: error: ‘png_infopp_NULL’ undeclared (first use in this function)     
png.c:158: error: (Each undeclared identifier is reported only once             
png.c:158: error: for each function it appears in.)                             
make[5]: *** [libpng_plugin_la-png.lo] Error 1                                  
make[5]: *** Waiting for unfinished jobs....                                    
mv -f .deps/liblibmpeg2_plugin_la-libmpeg2.Tpo .deps/liblibmpeg2_plugin_la-libmpeg2.Plo                                                                         
make[5]: Leaving directory `/var/tmp/portage/media-video/vlc-1.0.5/work/vlc-1.0.5/modules/codec'                                                                
make[4]: *** [all-recursive] Error 1                                            
make[4]: Leaving directory `/var/tmp/portage/media-video/vlc-1.0.5/work/vlc-1.0.5/modules/codec'                                                                
make[3]: *** [all] Error 2                                                      
make[3]: Leaving directory `/var/tmp/portage/media-video/vlc-1.0.5/work/vlc-1.0.5/modules/codec'                                                                
make[2]: *** [all-recursive] Error 1                                            
make[2]: Leaving directory `/var/tmp/portage/media-video/vlc-1.0.5/work/vlc-1.0.5/modules'                                                                      
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/media-video/vlc-1.0.5/work/vlc-1.0.5'
make: *** [all] Error 2


Reproducible: Always

Steps to Reproduce:

[Comment 1 Lars Wendler (Polynomial-C) (RETIRED) 2010-02-14 18:45:41 UTC]

Created attachment 219675 [details, diff]
vlc-1.0.x.ebuild.diff

quick'n'dirty fix

[Comment 2 Alexis Ballier 2010-02-14 19:29:44 UTC]

Please make a proper patch for upstream and follow the instructions for sending it [1]. This basically sums up as git checkout, patch, commit and git send-email.


[1] http://wiki.videolan.org/Git#Submitting_patches_to_the_vlc-devel_or_x264-devel

[Comment 3 Hanno Böck 2010-02-23 01:07:35 UTC]

Patch from upstream:
http://git.videolan.org/?p=vlc.git;a=commitdiff_plain;h=ffa6a2fa83452afe6a6ec67c4a3e8a5f1a6aaeef

[Comment 4 Alexis Ballier 2010-02-23 10:24:17 UTC]

applied to >=1.0.5, thanks