Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 304975 - qt4-r2.eclass:eqmake4() should set QMAKE_LIBDIR_*
Summary: qt4-r2.eclass:eqmake4() should set QMAKE_LIBDIR_*
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Qt Bug Alias
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: portage-multilib
  Show dependency tree
 
Reported: 2010-02-13 22:17 UTC by Nathan Phillip Brink (binki) (RETIRED)
Modified: 2010-03-18 11:43 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
qt4-r2.eclass-qmake_libdir.patch (qt4-r2.eclass-qmake_libdir.patch,772 bytes, text/plain)
2010-02-13 22:23 UTC, Nathan Phillip Brink (binki) (RETIRED)
Details
qt4-r2.eclass-qmake_libdir.patch (qt4-r2.eclass-qmake_libdir.patch,764 bytes, text/plain)
2010-02-13 23:19 UTC, Nathan Phillip Brink (binki) (RETIRED)
Details
qt4-eclasses-libdir.patch (qt4-eclasses-libdir.patch,1.38 KB, text/plain)
2010-02-23 18:32 UTC, Nathan Phillip Brink (binki) (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nathan Phillip Brink (binki) (RETIRED) gentoo-dev 2010-02-13 22:17:46 UTC
I took a small survey of my /usr/share/qt4/mkspecs (see bug 304971 ) and found that ``/usr/lib64'' is hardcoded into these files at certain important points. There are a few important variables that affect the compilation of many Qt apps:

QMAKE_RPATHDIR QMAKE_LIBDIR_QT4 QMAKE_LIBDR_X11 QMAKE_LIBDIR_OPENGL

On an amd64 system, just use ``grep -R lib64 /usr/share/qt4/mkspecs'' to find this listing of variables. Now, ``grep -R lib/ /usr/share/qt4/mkspecs'' returns many more variables but these for the most part are uncommon and, if used, would deserver their own multilib.eclass/$(get_libdir) bugs. But the variables listed above---and especially QMAKE_LIBDIR_QT4--are vital to the compilation of many Qt apps.

Thus, mostly for the multilib future, these variables should be overridden along with things like QMAKE_CXXFLAGS_RELEASE and passed to qmake4 in the eqmake4() function. This is primarily for the sake of programs using qmake, <suppressed expression of dislike towards qmake goes here ;-)>.
Comment 1 Nathan Phillip Brink (binki) (RETIRED) gentoo-dev 2010-02-13 22:23:22 UTC
Created attachment 219529 [details]
qt4-r2.eclass-qmake_libdir.patch

This is what I want ;-)
Comment 2 Nathan Phillip Brink (binki) (RETIRED) gentoo-dev 2010-02-13 23:19:22 UTC
Created attachment 219541 [details]
qt4-r2.eclass-qmake_libdir.patch

This version uses /usr instead of /usr/X11. This error of mine was caught by ferret_ and abcd.
Comment 3 Nathan Phillip Brink (binki) (RETIRED) gentoo-dev 2010-02-23 18:32:44 UTC
Created attachment 220873 [details]
qt4-eclasses-libdir.patch

This patch takes into consideration recent modification to qt4-r2.eclass and also patches qt4.eclass for the sake of unconverted ebuilds such at doxygen[qt4].
Comment 4 Markos Chandras (RETIRED) gentoo-dev 2010-03-17 17:54:59 UTC
This patch should be applied asap since it breaks multilib-portage enabled systems
Comment 5 Ben de Groot (RETIRED) gentoo-dev 2010-03-17 18:36:30 UTC
multilib-portage is not officially supported, and afaik nothing that we do officially support is broken, so this does not warrant a critical severity, just an enhancement.

We should review this (at first sight it looks good) and then apply this to qt4-r2.eclass. As qt4.eclass is now deprecated it should not be patched.
Comment 6 Markos Chandras (RETIRED) gentoo-dev 2010-03-18 11:43:24 UTC
Patch applied only to qt4-r2 eclass

Please report here is eqmake4 works now as expected