304153 – app-cdr/backlite-1.0.0 introduces unnecessary qt3support dependency

Bug 304153 - app-cdr/backlite-1.0.0 introduces unnecessary qt3support dependency

Summary: app-cdr/backlite-1.0.0 introduces unnecessary qt3support dependency

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Daniel Pielmeier

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2010-02-09 18:17 UTC by Matthew Turnbull
Modified:	2010-05-25 17:10 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
remove qPixmapFromMimeSource from ui files (backlite-1.0.0-pixmapfunction.patch,8.40 KB, text/plain) 2010-02-09 18:18 UTC, Matthew Turnbull	Details
ebuild patch (backlite-1.0.0-r1.ebuild.patch,347 bytes, text/plain) 2010-02-09 18:18 UTC, Matthew Turnbull	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Matthew Turnbull 2010-02-09 18:17:41 UTC

backlite-1.0.0 introduces a dependence on qt3support by having "<pixmapfunction>qPixmapFromMimeSource</pixmapfunction>" in some of the Qt .ui files.

From what I've read, this can be removed without consequence to the program. This patch removes qPixmapFromMimeSource from the pixmapfunction tags, leaving them empty. I'm not sure if the pixmapfunction can be outright removed.

I've tested this and I didn't notice any missing pixmaps, so it looks like it works fine.

Reproducible: Always

Steps to Reproduce:

Comment 1 Matthew Turnbull 2010-02-09 18:18:11 UTC

Created attachment 219015 [details]
remove qPixmapFromMimeSource from ui files

Comment 2 Matthew Turnbull 2010-02-09 18:18:24 UTC

Created attachment 219017 [details]
ebuild patch

Comment 3 Rafał Mużyło 2010-02-10 01:28:07 UTC

It depends.
It doesn't matter, if the app was correctly migrated
to use rc files for its icons.

Better contact upstream about it.

Comment 4 Daniel Pielmeier gentoo-dev

2010-02-11 16:10:27 UTC

I contacted upstream so the developer of backlite is aware of this bug.

Comment 5 Daniel Pielmeier gentoo-dev

2010-05-25 17:10:05 UTC

+*backlite-1.0.0-r1 (25 May 2010)
+
+  25 May 2010; Daniel Pielmeier <billie@gentoo.org>
+  +backlite-1.0.0-r1.ebuild, +files/backlite-1.0.0-qt3support.patch:
+  Revision bump. Add a patch to fix bug #304153. Thanks Matthew Turnbull for
+  reporting.

Should be fixed now, please reopen if there are any issues remaining.