Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 302929 - www-client/epiphany-extensions-2.26.1 fails to compile with xulrunner-1.9.2
Summary: www-client/epiphany-extensions-2.26.1 fails to compile with xulrunner-1.9.2
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: gnome2.28
  Show dependency tree
 
Reported: 2010-01-31 00:55 UTC by Albert W. Hopkins
Modified: 2010-03-13 19:31 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to epiphany-extensions build for optional java support (epiphany-extensions-java-useflag.patch,1.48 KB, patch)
2010-01-31 00:55 UTC, Albert W. Hopkins
Details | Diff
New patch, just realized I misnamed the java-console plugin (epiphany-extensions-java-useflag.patch,1.49 KB, patch)
2010-01-31 00:57 UTC, Albert W. Hopkins
Details | Diff
epiphany-extensions-2.26.1-r1.ebuild (epiphany-extensions-2.26.1-r1.ebuild,4.04 KB, text/plain)
2010-03-10 21:13 UTC, Hicham HAOUARI
Details
patch to fix issues with the gmail-notifier extension (epiphany-gmail-notifier.patch,10.24 KB, patch)
2010-03-10 21:14 UTC, Hicham HAOUARI
Details | Diff
Cleaned up ebuild (epiphany-extensions-2.26.1-r1.ebuild,3.00 KB, text/plain)
2010-03-11 19:39 UTC, Hicham HAOUARI
Details
Cleaned up patch (epiphany-gmail-notifier.patch,11.61 KB, patch)
2010-03-11 19:39 UTC, Hicham HAOUARI
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Albert W. Hopkins 2010-01-31 00:55:00 UTC
I have -java in xulrunner-1.9.2-r1 and when (re)compiling epiphany-extensions it fails trying to find java headers:

libtool: compile:  x86_64-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I../../.. -I.. -I../../../include -I/u
sr/include/xulrunner-1.9.2/unstable/. -I/usr/include/xulrunner-1.9.2/unstable/java -I/usr/include/xulr
unner-1.9.2/unstable/oji -I/usr/include/xulrunner-1.9.2/unstable/xpcom -DSHARE_DIR=\"/usr/share/epipha
ny-extensions\" -DG_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED -DGDK_PIXBUF_DISABLE_DEPRECATED -DGCON
F_DISABLE_DEPRECATED -DLIBGLADE_DISABLE_DEPRECATED -DPANGO_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED -DGNOME_DISABLE_DEPRECATED -UGTK_DISABLE_DEPRECATED -DXPCOM_GLUE_USE_NSPR -DXPCOM_GLUE -fshort-wchar -I/usr/include/xulrunner-1.9.2 -I/usr/include/nspr -DORBIT2=1 -pthread -I/usr/include/libxml2 -I/usr/include/libglade-2.0 -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/gconf/2 -I/usr/include/orbit-2.0 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/epiphany/2.26 -fno-rtti -fshort-wchar -O2 -march=core2 -pipe -Wall -Wno-unused -Wall -Wconversion -Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -O2 -march=core2 -pipe -MT libjavaconsolemozilla_la-java-console.lo -MD -MP -MF .deps/libjavaconsolemozilla_la-java-console.Tpo -c java-console.cpp  -fPIC -DPIC -o .libs/libjavaconsolemozilla_la-java-console.o
In file included from /usr/include/xulrunner-1.9.2/gtkmozembed_glue.cpp:42,
                 from java-console.cpp:27:
/usr/include/xulrunner-1.9.2/gtkmozembed.h:57:1: warning: "NS_HIDDEN" redefined
In file included from /usr/include/xulrunner-1.9.2/nsXPCOMGlue.h:42,
                 from java-console.cpp:26:
/usr/include/xulrunner-1.9.2/nscore.h:119:1: warning: this is the location of the previous definition
In file included from /usr/include/xulrunner-1.9.2/gtkmozembed_glue.cpp:42,
                 from java-console.cpp:27:
/usr/include/xulrunner-1.9.2/gtkmozembed.h:63:1: warning: "NS_EXPORT_" redefined
In file included from /usr/include/xulrunner-1.9.2/nsXPCOMGlue.h:42,
                 from java-console.cpp:26:
/usr/include/xulrunner-1.9.2/nscore.h:212:1: warning: this is the location of the previous definition
In file included from /usr/include/xulrunner-1.9.2/gtkmozembed_glue.cpp:42,
                 from java-console.cpp:27:
/usr/include/xulrunner-1.9.2/gtkmozembed.h:64:1: warning: "NS_IMPORT_" redefined
In file included from /usr/include/xulrunner-1.9.2/nsXPCOMGlue.h:42,
                 from java-console.cpp:26:
/usr/include/xulrunner-1.9.2/nscore.h:210:1: warning: this is the location of the previous definition
java-console.cpp:31:27: error: nsIJVMManager.h: No such file or directory
java-console.cpp: In function 'gboolean java_console_is_available()':
java-console.cpp:39: error: 'nsIJVMManager' was not declared in this scope
java-console.cpp:39: error: template argument 1 is invalid
java-console.cpp:39: error: invalid type in declaration before '=' token
java-console.cpp:39: error: cannot convert 'const nsGetServiceByContractID' to 'int' in initialization
java-console.cpp:43: error: base operand of '->' is not a pointer
java-console.cpp: In function 'void java_console_show()':
java-console.cpp:52: error: 'nsIJVMManager' was not declared in this scope
java-console.cpp:52: error: template argument 1 is invalid
java-console.cpp:52: error: invalid type in declaration before '=' token
java-console.cpp:52: error: cannot convert 'const nsGetServiceByContractID' to 'int' in initialization
java-console.cpp:55: error: base operand of '->' is not a pointer
make[4]: *** [libjavaconsolemozilla_la-java-console.lo] Error 1


Well it probably should not be trying to compile the java console extension since there is no java support in xulrunner.

I tried patching the ebuild for epiphany-extensions giving it a java use flag.  It seems to work (for me).
Comment 1 Albert W. Hopkins 2010-01-31 00:55:44 UTC
Created attachment 217959 [details, diff]
Patch to epiphany-extensions build for optional java support
Comment 2 Albert W. Hopkins 2010-01-31 00:57:46 UTC
Created attachment 217961 [details, diff]
New patch, just realized I misnamed the java-console plugin
Comment 3 Gilles Dartiguelongue gentoo-dev 2010-01-31 09:19:12 UTC
looks like epiphany extensions's configure is being silent about disabling java then because I never had java support enabled yet e-e always built fine. Otherwise the patch sounds fine.
Comment 4 Pacho Ramos gentoo-dev 2010-03-05 19:10:17 UTC
Anyway I doubt epiphany{,-extensions} will build against xulrunner-1.9.2 :-|
Comment 5 Nirbheek Chauhan (RETIRED) gentoo-dev 2010-03-08 10:40:55 UTC
Even if the attached patch works, epiphany itself won't compile/work, and I doubt epiphany-extensions will work properly even after compiling.
Comment 6 Hicham HAOUARI 2010-03-10 16:02:53 UTC
epiphany-2.26-r3 builds fine with 1.9.2, and the extensions too (including the old gmail-notifier ). It works ok with the official extensions, but i still have a random deadlock with gmail-notifier.

see : 
http://bugs.gentoo.org/show_bug.cgi?id=303583#c20
http://bugs.gentoo.org/show_bug.cgi?id=303583#c21
http://bugs.gentoo.org/show_bug.cgi?id=303583#c22
http://bugs.gentoo.org/show_bug.cgi?id=303583#c23
Comment 7 Hicham HAOUARI 2010-03-10 21:13:12 UTC
Created attachment 223065 [details]
epiphany-extensions-2.26.1-r1.ebuild

Modified ebuild with gmail useflag ( to build the gmail-notifier extension )
Comment 8 Hicham HAOUARI 2010-03-10 21:14:10 UTC
Created attachment 223067 [details, diff]
patch to fix issues with the gmail-notifier extension
Comment 9 Hicham HAOUARI 2010-03-11 19:39:02 UTC
Created attachment 223191 [details]
Cleaned up ebuild
Comment 10 Hicham HAOUARI 2010-03-11 19:39:39 UTC
Created attachment 223193 [details, diff]
Cleaned up patch
Comment 11 Pacho Ramos gentoo-dev 2010-03-12 10:12:50 UTC
I don't think addding gmail-notifier extensions make sense since:
1. It's an unofficial extension
2. Seems that it's not going to be ported to newer epiphany versions (with webkit), then, I don't think makes sense to offer our users a new extensions that will disappear again in the future

About java-console extension... it still fails to build here :-(, Are you sure you have tried to enable it?
Comment 12 Pacho Ramos gentoo-dev 2010-03-12 10:20:39 UTC
(In reply to comment #11)
> About java-console extension... it still fails to build here :-(, Are you sure
> you have tried to enable it?
> 
Seems that it's because xulrunner-1.9.2 no longer includes nsIJVMManager.h

Comment 13 Pacho Ramos gentoo-dev 2010-03-12 10:35:58 UTC
An I have just checked that galeon (in fedora) is simply disabling java-console extension due this:
http://cvs.fedoraproject.org/viewvc/devel/galeon/galeon-2.0.7-nojavaconsole.patch?revision=1.1&view=markup
Comment 14 Pacho Ramos gentoo-dev 2010-03-12 11:08:03 UTC
+*epiphany-extensions-2.26.1-r1 (12 Mar 2010)
+
+  12 Mar 2010; Pacho Ramos <pacho@gentoo.org>
+  +epiphany-extensions-2.26.1-r1.ebuild:
+  Disable java-console since it cannot build against xul-1.9.2, see bug
+  302929. Feel free to reopen if you know how to fix it.
+
Comment 15 Hicham HAOUARI 2010-03-13 01:50:32 UTC
(In reply to comment #11)
> I don't think addding gmail-notifier extensions make sense since:
> 1. It's an unofficial extension
> 2. Seems that it's not going to be ported to newer epiphany versions (with
> webkit), then, I don't think makes sense to offer our users a new extensions
> that will disappear again in the future
> 
1. I agree, but since it requires epiphany-extensions source tree anyway, i thought, it is best to add it as a use flag.
2. You are probably aware that only few extensions of the previous official ones work with 2.28, so I think that this is not an issue.
3. It is just a use flag which is disabled by default, so users won't get it by default unless they specify so.

Comment 16 Pacho Ramos gentoo-dev 2010-03-13 10:18:47 UTC
(In reply to comment #15)
> 2. You are probably aware that only few extensions of the previous official
> ones work with 2.28, so I think that this is not an issue.

Yes, I know but take care that some more extensions have been already ported for epiphany-2.30 (this is one of the reasons epiphany-2.28 won't probably go to stable ever)

> 3. It is just a use flag which is disabled by default, so users won't get it by
> default unless they specify so.
> 

But I still think there is no point in offering that single extensions to our users if it will be only available for some time for a single epiphany version that is currently a dead end since it's not developed at all by upstream and we are still providing it because epiphany-2.28 is not ready to go stable yet
Comment 17 Hicham HAOUARI 2010-03-13 15:09:20 UTC
Even if epiphany >= 2.28 goes stable, I don't think users will use it because it is stable, but rather for satisfying their needs.

Currently the webkit backend is still missing some functionalities, for me :
- Font selection per language.
- Certificates management.
- Full page zoom.
- Python interface ( it is removed, so all previous python extensions are dead now ).
- Rendering fails on some websites while it works perfectly with gecko.

Epiphany's case reminds of gdm, see gdm-2.20 is still used by a lot of distributions ( including gentoo, debian, mandriva ... ), because later versions contains huge features regressions.
Comment 18 Hicham HAOUARI 2010-03-13 15:11:25 UTC
adding to the list of reasons :

- Some mozilla plugins do not work yet.
Comment 19 Albert W. Hopkins 2010-03-13 19:13:35 UTC
+1 on keeping Epiphany 2.26* in the tree as long as possible.  I've also given my list of reasons in bug #303583 (comment #18).

I even tried the latest 2.28* a few days ago.  It's still very lacking and I still cannot use it to go to, e.g., lenovo.com, something I reported upstream many months ago.

I agree with comment #17; this is another gdm.  You still have to go out of your way on some distros (e.g. Ubuntu) do install the older gdm if you actually want to use features like XDMCP.
Comment 20 Pacho Ramos gentoo-dev 2010-03-13 19:31:56 UTC
But epiphany-gmail-notifier upstream seems to be inactive, as I have seen in its bug tracker, also, it doesn't release versioned tarballs that is a bit problematic (well, I think you will know it since you reported it upstream ;-))

I would suggest you to try to ping upstream to check it he is still maintaining it. Also, would be better to keep epiphany-extensions ebuild with "official" ones and, then, I would open a separate bug report with an ebuild to install that extension only. Once it's done, you could even maintain your ebuild in sunrise overlay.