Bug 302456 – net-dialup/slmodem removal request (was: 2.9.11_pre20090222-r1 fails to build with linux >= 2.6.32.4)

• Status: RESOLVED WONTFIX
• Product: Gentoo Linux

[Description Martin Mokrejš 2010-01-27 14:03:45 UTC]

make[1]: Entering directory `/var/tmp/portage/net-dialup/slmodem-2.9.11_pre20090222-r1/work/slmodem-2.9.11-20090222/drivers'
        obj-m=slamr.o
        slamr-objs=amrmo_init.o sysdep_amr.o amrlibs.o
make modules -C /lib/modules/2.6.32.4/build M=/var/tmp/portage/net-dialup/slmodem-2.9.11_pre20090222-r1/work/slmodem-2.9.11-20090222/drivers
make[2]: Entering directory `/usr/src/linux-2.6.32.4'
  CC [M]  /var/tmp/portage/net-dialup/slmodem-2.9.11_pre20090222-r1/work/slmodem-2.9.11-20090222/drivers/amrmo_init.o
/var/tmp/portage/net-dialup/slmodem-2.9.11_pre20090222-r1/work/slmodem-2.9.11-20090222/drivers/amrmo_init.c: In function ‘amrmo_update_status’:
/var/tmp/portage/net-dialup/slmodem-2.9.11_pre20090222-r1/work/slmodem-2.9.11-20090222/drivers/amrmo_init.c:381: error: ‘TASK_NORMAL’ undeclared (first use in this function)
/var/tmp/portage/net-dialup/slmodem-2.9.11_pre20090222-r1/work/slmodem-2.9.11-20090222/drivers/amrmo_init.c:381: error: (Each undeclared identifier is reported only once
/var/tmp/portage/net-dialup/slmodem-2.9.11_pre20090222-r1/work/slmodem-2.9.11-20090222/drivers/amrmo_init.c:381: error: for each function it appears in.)
make[3]: *** [/var/tmp/portage/net-dialup/slmodem-2.9.11_pre20090222-r1/work/slmodem-2.9.11-20090222/drivers/amrmo_init.o] Error 1
make[2]: *** [_module_/var/tmp/portage/net-dialup/slmodem-2.9.11_pre20090222-r1/work/slmodem-2.9.11-20090222/drivers] Error 2
make[2]: Leaving directory `/usr/src/linux-2.6.32.4'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/var/tmp/portage/net-dialup/slmodem-2.9.11_pre20090222-r1/work/slmodem-2.9.11-20090222/drivers'
make: *** [all] Error 2
 * ERROR: net-dialup/slmodem-2.9.11_pre20090222-r1 failed:
 *   Unable to emake HOSTCC=i686-pc-linux-gnu-gcc CROSS_COMPILE=i686-pc-linux-gnu- LDFLAGS=  KERNEL_DIR=/lib/modules/2.6.32.4/build all
 * 
 * Call stack:
 *     ebuild.sh, line   54:  Called src_compile
 *   environment, line 3565:  Called linux-mod_src_compile
 *   environment, line 2721:  Called die
 * The specific snippet of code:
 *               eval "emake HOSTCC=\"$(tc-getBUILD_CC)\"                                               CROSS_COMPILE=${CHOST}-                                                 LDFLAGS=\"$(get_abi_LDFLAGS)\"                       ${BUILD_FIXES}                                           ${BUILD_PARAMS}                                                 ${BUILD_TARGETS} " || die "Unable to emake HOSTCC="$(tc-getBUILD_CC)" CROSS_COMPILE=${CHOST}- LDFLAGS="$(get_abi_LDFLAGS)" ${BUILD_FIXES} ${BUILD_PARAMS} ${BUILD_TARGETS}";

[Comment 1 Martin Mokrejš 2010-01-27 14:04:21 UTC]

Created attachment 217595 [details]
build.log

[Comment 2 Martin Mokrejš 2010-01-27 14:27:22 UTC]

There is no issue against 2.6.31.12, 2.6.30.10, 2.6.27.44. Problem starts with initial 2.6.32.

[Comment 3 Jouni Rinne 2010-07-29 18:32:03 UTC]

Slmodem fails to build with 2.6.34, too. There are updated versions of slmodem in http://linmodems.technion.ac.il/packages/smartlink/ ; I haven't tested the yet, maybe the slmodem maintainer cares to update the package...

[Comment 4 Lech Perczak 2010-08-26 00:29:02 UTC]

Created attachment 244621 [details]
New ebuild for 20100718 release. 

Got it to compile with 2.6.35-gentoo-r2 kernel. slmodem dated 20100718, ungrab-winmodem dated 20090716.
Removed the check for CONFIG_PCI_LEGACY due to removal of the flag in recent kernels.

[Comment 5 Jouni Rinne 2010-08-26 01:56:14 UTC]

Yes, I can confirm it works with 2.6.34-r1, too

[Comment 6 Martin Mokrejš 2010-08-28 10:22:25 UTC]

slmodem-2.9.11_pre20100718.ebuild compiles also against 2.6.31.14. Thanks.

[Comment 7 Lech Perczak 2010-08-28 12:17:18 UTC]

Could anybody please add this to Portage?

[Comment 8 Jouni Rinne 2011-01-08 15:37:39 UTC]

Okay, even slmodem-2.9.11_pre20100718 does not compile any more with kernel 2.6.36-r5...

[Comment 9 Lech Perczak 2011-01-08 16:05:24 UTC]

Created attachment 259296 [details, diff]
fix for compilation in 2.6.36+ kernels

This patch fixes compilation of slamr module with 2.6.36 and 2.6.37 kernels.

[Comment 10 Lech Perczak 2011-01-08 16:06:25 UTC]

Created attachment 259297 [details]
New ebuild that applies 2.6.36 kernel patch when needed

[Comment 11 Jouni Rinne 2011-01-09 03:41:42 UTC]

Thanks Lech, works again! Now, can we get this update to portage ASAP... please, Gentoo devs???

[Comment 12 Samuli Suominen (RETIRED) 2011-02-01 19:08:05 UTC]

Maintainer timeout. Masked for removal in 30 days.

[Comment 13 Martin Mokrejš 2011-03-17 19:59:48 UTC]

(In reply to comment #12)
> Maintainer timeout. Masked for removal in 30 days.

Please keep the package for those of us who occasionally have an archaic access to the internet. What is the point in removing a working package. Many of use use "old" kernels before 2.6.32 and personally I will not switch to some newer with my old, stable hardware. Let the bug opened so people can find the patches and apply them if they run affected kernel version. For many of us running older kernel we do not sometimes even need them but when recompiling kernel we need the sources/the package available in the tree. This only causes nuisance so people have to move current ebuild into their own overlay, and complain about Gentoo. It just does not help anybody, really.

[Comment 14 Samuli Suominen (RETIRED) 2011-04-29 14:17:59 UTC]

no more slmodem in portage, closing