Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 302146 - app-text/notecase 1.9.8 background color settings not restored on re-start
Summary: app-text/notecase 1.9.8 background color settings not restored on re-start
Status: RESOLVED CANTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Raúl Porcel (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-25 08:33 UTC by C W Rose
Modified: 2010-12-05 16:57 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description C W Rose 2010-01-25 08:33:15 UTC
Notecase 1.9.8, running on Gnome 2.24 and 2.26, can set a colored background
on both the text and the tree windows, but the text background reverts to white
after Notecase is stopped and restarted.  However, opening and closing the
Edit => Configure Notecase => Display window restores the colored background
in both the tree and text windows.

This doesn't look like a bug in the Notecase code, but some sort of race
condition within the GTK+ window initialising code itself.  The easiest
cure seems to be to delay changing the background until the window is
established, which is a fairly minimal alteration, so I've attached
a uuencoded patch to the standard 1.9.8 sources to do just that.

The attached diffs contain patches for five files, Makefile, config.h,
MainWnd.cpp, and main.cpp.

The Makefile and config.h patches simply bump the revision number to 1.9.8.1,
because I got confused when testing two versions, so those patches can be
dropped.

The MainWnd.cpp patch ifdef's out the GTK+ bug fix on startup, since it
seems to be no longer needed.  I left the fix in OptionsDialog.cpp since
there was no point in removing it, but that could be commented out as well.

The only essential changes are in main.cpp, where I've added some comments
to clarify the program logic, and added calls to modify the window colors
after the return from the main window building functions.  The string ###
marks the major changes, which are bracketed by #ifdef 1.

I've sent this patch to the author, but the program's no longer maintained,
so I thought I'd post it here in case anyone needed it.  The changes to
the ebuild are trivial, just an extra patch and patch files.

8<===============8<===============8<===============8<===============

begin 644 notecase-1.9.8-background.patch
M9&EF9B`M=7).(&YO=&5C87-E+3$N.2XX+F]R:6<O36%K969I;&4@;F]T96-A
M<V4M,2XY+C@O36%K969I;&4*+2TM(&YO=&5C87-E+3$N.2XX+F]R:6<O36%K
M969I;&4),C`P."TQ,BTP.2`Q,#HP-SHP-BXP,#`P,#`P,#`@*S`P,#`**RLK
M(&YO=&5C87-E+3$N.2XX+TUA:V5F:6QE"3(P,3`M,#$M,3@@,C,Z,#`Z-#4N
M,#`P,#`P,#`P("LP,#`P"D!`("TW+#<@*S<L."!`0`H@(R!4:&ES(&UA:V5F
M:6QE('=A<R!T97-T960@;VX@3&EN=7@@*&=C8R]G*RLI+"!7:6YD;W=S("A-
M:6YG=R]-<WES*2P@3U-8+"!/<&5N4V]L87)I<R!A;F0@1G)E94)31`H@(R!5
M<V4@(F=M86ME(B!T;R!C;VUP:6QE(&]N($]36"!A;F0@1G)E94)31`H@(PHM
M5D524TE/3CTQ+CDN.`HK(R!/=F5R<FED97,@8V]N9FEG+F@**U9%4E-)3TX]
M,2XY+C@N,0H@"B`C(&1E9FEN92!I;G-T86QL('1A<F=E="!D:7)S"B!P<F5F
M:7@]+W5S<@ID:69F("UU<DX@;F]T96-A<V4M,2XY+C@N;W)I9R]S<F,O8V]N
M9FEG+F@@;F]T96-A<V4M,2XY+C@O<W)C+V-O;F9I9RYH"BTM+2!N;W1E8V%S
M92TQ+CDN."YO<FEG+W-R8R]C;VYF:6<N:`DR,#`X+3$R+3`Y(#$P.C$Q.C(Q
M+C`P,#`P,#`P,"`K,#`P,`HK*RL@;F]T96-A<V4M,2XY+C@O<W)C+V-O;F9I
M9RYH"3(P,3`M,#$M,3@@,C(Z,3$Z-#@N,#`P,#`P,#`P("LP,#`P"D!`("TQ
M,"PW("LQ,"PW($!`"B`C9&5F:6YE($-/3D9)1U](7U\-"B`-"B`C9&5F:6YE
M($%04%].04U%7U-44B`B3F]T94-A<V4B#0HM(V1E9FEN92!!4%!?5D527U-4
M4B`B,2XY+C@B"BLC9&5F:6YE($%04%]615)?4U12("(Q+CDN."XQ(@H@#0H@
M(V1E9FEN92!004-+04=%(")N;W1E8V%S92()+R].3%,@<&%C:V%G92!D969I
M;FET:6]N#0H@(V1E9FEN92!53D1/7TQ)4U1?4TE:12`Q,`T*9&EF9B`M=7).
M(&YO=&5C87-E+3$N.2XX+F]R:6<O<W)C+VUA:6XN8W!P(&YO=&5C87-E+3$N
M.2XX+W-R8R]M86EN+F-P<`HM+2T@;F]T96-A<V4M,2XY+C@N;W)I9R]S<F,O
M;6%I;BYC<'`),C`P."TQ,"TR-"`Q.3HU-#HU,"XP,#`P,#`P,#`@*S`Q,#`*
M*RLK(&YO=&5C87-E+3$N.2XX+W-R8R]M86EN+F-P<`DR,#$P+3`Q+3$R(#$X
M.C`Y.C,Y+C`P,#`P,#`P,"`K,#`P,`I`0"`M-S8L-B`K-S8L-R!`0`H@:6YT
M("!L;V%D7V9I;&4H8V]N<W0@8VAA<B`J9FEL96YA;64L(&-O;G-T(&-H87(@
M*G-Z4&%S<W=O<F0@/2!.54Q,+"!I;G0@;D-U<DYO9&5)9'@@/2`M,2D[#0H@
M:6YT("!L;V%D7V9I;&5?96UB961D960H:6YT(&Y#=7).;V1E261X(#T@+3$I
M.PT*('9O:60@97AP;W)T7V1O8W5M96YT*&-O;G-T($YO=&5$;V-U;65N="`F
M9&]C=6UE;G0L(&EN="!N17AP;W)T36]D92P@8V]N<W0@<W1D.CIS=')I;F<@
M)G-T<D5X<&]R=$9I;&4L(&-O;G-T('-T9#HZ<W1R:6YG("9S=')0;W-T4')O
M8V5S<U-C<FEP="P@8V]N<W0@<W1D.CIS=')I;F<@)G-T<D-34RP@:6YT(&Y%
M;6)E9$-34R`]("TQ+"!B;V]L(&)#:&5C:T]V97)W<FET92`]('1R=64L(&)O
M;VP@8D5X<&]R=$QI;FME9"`](&9A;'-E+"!I;G0@;D9O<FUA="`]($9/4DU!
M5%].3TY%+"!I;G0@;D5X<&]R=$)R86YC:$ED>#TM,2D[#0HK=F]I9"!2969R
M97-H5&5X=%9I97=#87)E=$-O;&]R*$=D:T-O;&]R("9":T-O;&]R*3L-"B`-
M"B!C;&%S<R!/<$QI<W1,86YG(#H@<'5B;&EC(%1H<F5A9`T*('L-"D!`("TU
M-S8L,C4@*S4W-RPR-2!`0`H@"0D)"0EG7W-T<DQO861$;V-U;65N=%!A<W,@
M/2!S=')087-S=V]R9#L-"B`)"0D)"6=?;DQO861$;V-U;65N=$YO9&5)1"`]
M(&Y#=7).;V1E261X.PT*(`D)"0E]#0HM"0D)"6EF*"%G7W=N9"YM7W!7:61G
M970I(&=?=VYD+D-R96%T92@I.PT**PD)"0DO+R`C(R,@:68H(6=?=VYD+FU?
M<%=I9&=E="D@9U]W;F0N0W)E871E*"D[#0H@"0D)?0T*+0D)"65L<V5[#0HK
M"0D)96QS97L@+R\@87)G8R`]/2`Q#0H@"0D)"2\O8VAE8VL@(G)E;&]A9"!L
M87-T(&9I;&4B(&]P=&EO;@T*(`D)"0EG7V]B:DU252Y,;V%D*"D[#0H@#0H@
M"0D)"6)O;VP@8DQO861,87-T1&]C.PT*+0D)"0EI9BAG7V]B:DEN:2Y'9716
M86QU92@B4W1A<G1U<"(L(")296QO861,87-T1&]C=6UE;G0B+"!B3&]A9$QA
M<W1$;V,I*0T**PD)"0EI9BAG7V]B:DEN:2Y'971686QU92@B4W1A<G1U<"(L
M(")296QO861,87-T1&]C=6UE;G0B+"!B3&]A9$QA<W1$;V,I*7L-"B`)"0D)
M"6EF*&),;V%D3&%S=$1O8R`F)B`H9U]O8FI-4E4N1V5T4VEZ92@I(#X@,"DI
M>PT*(`D)"0D)"6=?8DEN:71I86Q,;V%D(#T@=')U93L-"B`)"0D)"0EG7V)5
M<&1A=&5-4E4@/2!T<G5E.PT*(`D)"0D)"6=?<W1R3&]A9$1O8W5M96YT1FEL
M92`](&=?;V)J35)5+D=E=$9I;&4H,"D[#0H@"0D)"0D)9U]N3&]A9$1O8W5M
M96YT3F]D94E$(#T@;D-U<DYO9&5)9'@[#0H@"0D)"0E]#0HM#0HM"0D)"6EF
M*"%G7W=N9"YM7W!7:61G970I(&=?=VYD+D-R96%T92@I.PDO+R!T:&ES('=I
M;&P@;&]A9"!-4E4-"BL)"0D)?0T**PD)"0DO+R`C(R,@:68H(6=?=VYD+FU?
M<%=I9&=E="D@9U]W;F0N0W)E871E*"D["2\O('1H:7,@=VEL;"!L;V%D($U2
M50T*(`D)"7T-"BT)"7T-"BT)?0T**PD)?2`O+R`A8D)A8VMU<$QO861E9`T*
M*PE]("\O("%B4W1A;F1A;&]N90T*(`EE;'-E#0H@"7L-"B`)"2\O5$]&25@@
M<F5A9"!C;VUM86YD(&QI;F4@9F]R(&5M8F5D9&5D(&1O8R!A;'-O(#\-"D!`
M("TV,#(L,3$@*S8P,RPT."!`0`H@"0EG7V));FET:6%L3&]A9"`]('1R=64[
M#0H@"0EG7V),;V%D16UB961D960@/2!T<G5E.PT*(`T*+0D):68H(6=?=VYD
M+FU?<%=I9&=E="D@9U]W;F0N0W)E871E*"D[#0HK"0DO+R`C(R,@:68H(6=?
M=VYD+FU?<%=I9&=E="D@9U]W;F0N0W)E871E*"D[#0H@"7T-"B`-"BL)+R\@
M0V%T8VAA;&P-"B`):68H(6=?=VYD+FU?<%=I9&=E="D@9U]W;F0N0W)E871E
M*"D[#0HK(VEF(#$-"BL)+R\@1V5T('=I9&=E="!H86YD;&5S#0HK"4=T:U=I
M9&=E="`J=')E979I97<@/2!L;V]K=7!?=VED9V5T*&=?=VYD+FU?<%=I9&=E
M="P@(G1R965V:65W,2(I.PT**PE'=&M7:61G970@*G1E>'1V:65W(#T@;&]O
M:W5P7W=I9&=E="AG7W=N9"YM7W!7:61G970L(")T97AT=FEE=S$B*3L-"BL)
M+R\@1W1K5VED9V5T("IL86)E;#$@("`](&QO;VMU<%]W:61G970H9U]W;F0N
M;5]P5VED9V5T+"`B;&%B96PQ(BD[#0HK#0HK"2\O(",C(R!S970@8W5S=&]M
M($=522!C;VQO<G,-"BL)<W1D.CIS=')I;F<@<W1R0V]L;W(L('-T<D-O;&]R
M,3L-"BL)9U]O8FI);FDN1V5T5F%L=64H(D1I<W!L87DB+"`B5&5X=$-O;&]R
M(BP@<W1R0V]L;W(L("(B*3L-"BL)9U]O8FI);FDN1V5T5F%L=64H(D1I<W!L
M87DB+"`B0F%C:V=R;W5N9$-O;&]R(BP@<W1R0V]L;W(Q+"`B(BD[#0HK"6EF
M*'-T<D-O;&]R+G-I>F4H*2`^(#`I#0HK"7L-"BL)"4=D:T-O;&]R(&-O;&]R
M.PT**PD)9V1K7V-O;&]R7W!A<G-E("AS=')#;VQO<BYC7W-T<B@I+"`F8V]L
M;W(I.PT**PD)9W1K7W=I9&=E=%]M;V1I9GE?=&5X="A'5$M?5TE$1T54*'1E
M>'1V:65W*2P@1U1+7U-4051%7TY/4DU!3"P@)F-O;&]R*3L-"BL)"6=T:U]W
M:61G971?;6]D:69Y7W1E>'0H1U1+7U=)1$=%5"AT<F5E=FEE=RDL($=42U]3
M5$%415].3U)-04PL("9C;VQO<BD[#0HK"7T-"BL):68H<W1R0V]L;W(Q+G-I
M>F4H*2`^(#`I#0HK"7L-"BL)"4=D:T-O;&]R(&-O;&]R,3L-"BL)"6=D:U]C
M;VQO<E]P87)S92`H<W1R0V]L;W(Q+F-?<W1R*"DL("9C;VQO<C$I.PT**PT*
M*PD)9W1K7W=I9&=E=%]M;V1I9GE?8F%S92A'5$M?5TE$1T54*'1E>'1V:65W
M*2P@1U1+7U-4051%7TY/4DU!3"P@)F-O;&]R,2D[#0HK"0DO+R!G=&M?=VED
M9V5T7VUO9&EF>5]B87-E*$=42U]7241'150H=&5X='9I97<I+"!'5$M?4U1!
M5$5?04-4259%+"`F8V]L;W(Q*3L-"BL)"2\O(&=T:U]W:61G971?;6]D:69Y
M7V)A<V4H1U1+7U=)1$=%5"AT97AT=FEE=RDL($=42U]35$%415]04D5,24=(
M5"P@)F-O;&]R,2D[#0HK"0DO+R!G=&M?=VED9V5T7VUO9&EF>5]B87-E*$=4
M2U]7241'150H=&5X='9I97<I+"!'5$M?4U1!5$5?4T5,14-4140L("9C;VQO
M<C$I.PT**PD)9W1K7W=I9&=E=%]M;V1I9GE?8F%S92A'5$M?5TE$1T54*'1E
M>'1V:65W*2P@1U1+7U-4051%7TE.4T5.4TE4259%+"`F8V]L;W(Q*3L-"BL-
M"BL)"6=T:U]W:61G971?;6]D:69Y7V)A<V4H1U1+7U=)1$=%5"AT<F5E=FEE
M=RDL($=42U]35$%415].3U)-04PL("9C;VQO<C$I.PT**PD)+R\@9W1K7W=I
M9&=E=%]M;V1I9GE?8F%S92A'5$M?5TE$1T54*'1R965V:65W*2P@1U1+7U-4
M051%7T%#5$E612P@)F-O;&]R,2D[#0HK"0DO+R!G=&M?=VED9V5T7VUO9&EF
M>5]B87-E*$=42U]7241'150H=')E979I97<I+"!'5$M?4U1!5$5?4%)%3$E'
M2%0L("9C;VQO<C$I.PT**PD)+R\@9W1K7W=I9&=E=%]M;V1I9GE?8F%S92A'
M5$M?5TE$1T54*'1R965V:65W*2P@1U1+7U-4051%7U-%3$5#5$5$+"`F8V]L
M;W(Q*3L-"BL)"6=T:U]W:61G971?;6]D:69Y7V)A<V4H1U1+7U=)1$=%5"AT
M<F5E=FEE=RDL($=42U]35$%415])3E-%3E-)5$E612P@)F-O;&]R,2D[#0H@
M#0HK"0E2969R97-H5&5X=%9I97=#87)E=$-O;&]R*&-O;&]R,2D[#0HK"7T-
M"BLC96YD:68-"B`)0VAE8VM#<F%S:$QO9T9I;&5S*"D[#0H@#0H@"4]P3&ES
M=$QA;F<@*G!/<%1H<F5A9"`](&YE=R!/<$QI<W1,86YG.PT*9&EF9B`M=7).
M(&YO=&5C87-E+3$N.2XX+F]R:6<O<W)C+TUA:6Y7;F0N8W!P(&YO=&5C87-E
M+3$N.2XX+W-R8R]-86EN5VYD+F-P<`HM+2T@;F]T96-A<V4M,2XY+C@N;W)I
M9R]S<F,O36%I;E=N9"YC<'`),C`P."TQ,BTP."`Q,SHQ,SHQ-BXP,#`P,#`P
M,#`@*S`P,#`**RLK(&YO=&5C87-E+3$N.2XX+W-R8R]-86EN5VYD+F-P<`DR
M,#$P+3`Q+3$R(#$Y.C`Q.C,X+C`P,#`P,#`P,"`K,#`P,`I`0"`M,S<Y+#<@
M*S,W.2PX($!`"B`)"5)E9G)E<VA497AT5FEE=T-A<F5T0V]L;W(H8V]L;W(Q
M*3L-"B`-"B`)"6=?<F=B5&5X=%9I97=":T-O;&]R(#T@8V]L;W(Q.PT*+0T*
M*R-I9B`P#0HK"0DO+R`C(R,@07!P87)E;G1L>2!N;R!L;VYG97(@;F5E9&5D
M("A';F]M92`R+C(T*2X-"B`)"2\O9FEX(&9O<B!'5$L@8G5G("T@=')E92!V
M:65W(&QO<V5S(&)A8VMG<F]U;F0@8V]L;W(-"B`)"7-T871I8R!C;VYS="!C
M:&%R(&-U<G-O<E]C;VQO<E]R8UM=(#T-"B`)"0DB<W1Y;&4@7")A86%<(EQN
M(@T*0$`@+30P,"PV("LT,#$L-R!`0`H@"0EG=&M?=VED9V5T7W-E=%]N86UE
M*'1R965V:65W+"`B86%A(BD[#0H@"0EG=&M?=VED9V5T7W)E<V5T7W)C7W-T
M>6QE<R`H=')E979I97<I.PT*(`D)9U]F<F5E("AR8U]T96UP*3L-"BLC96YD
L:68-"B`@(`E]#0H@#0H@"6EF*&=?8D1R87=497AT=FEE=T5X<&]S92E[#0H`
`
end

====================================================================


Reproducible: Always

Steps to Reproduce:
1.Change Notecase background colors.
2.Shutdown Notecase.
3.Restart Notecase and the tree window will show the new color,
  and the text window won't.
4.Refresh the color settings and both windows will show the new color.
Actual Results:  
See above.

Expected Results:  
See above

See above
Comment 1 Patrick Lauer gentoo-dev 2010-01-25 11:59:54 UTC
Please don't put base64-encoded patches inline. There's a "Create a New Attachment" field specifically for that, and we prefer patches as uncompressed plain text.
Comment 2 Raúl Porcel (RETIRED) gentoo-dev 2010-12-05 16:57:15 UTC
Attach a valid patch, please