Bug 302134 – app-admin/eselect-esd-20091106 needs trivial update

• Status: RESOLVED FIXED
• Product: Gentoo/Alt

[Description Greg Turner 2010-01-25 04:16:32 UTC]

eselect-esd-20091106 fails to unpack (patch failure)

Reproducible: Always

Steps to Reproduce:
1. emerge eselect-esd

Actual Results:  
failure

Expected Results:  
success

patches to be enclosed.

[Comment 1 Greg Turner 2010-01-25 04:17:20 UTC]

Created attachment 217364 [details, diff]
updated version of prefix patch

[Comment 2 Greg Turner 2010-01-25 04:17:53 UTC]

Created attachment 217365 [details]
Patch to ebuild to utilize other patch

[Comment 3 Fabian Groffen 2010-01-26 19:03:51 UTC]

thanks, patch added.

[Comment 4 Ulrich Müller 2010-01-27 05:44:17 UTC]

(In reply to comment #1)
> Created an attachment (id=217364) [details]
> updated version of prefix patch

> +ROOT="@GENTOO_PORTAGE_EPREFIX@"${ROOT}

This doesn't look right. Shouldn't the prefix come _after_ ROOT?

Besides, >=eselect-1.2 proper defines EPREFIX and EROOT variables, so modules should just use them, instead of defining their own.

[Comment 5 Fabian Groffen 2010-01-27 11:58:43 UTC]

braindamage

prolly should fix this one properly this time indeed

[Comment 6 Fabian Groffen 2010-01-27 20:25:57 UTC]

@sound: please consider the to be attached patch

[Comment 7 Fabian Groffen 2010-01-27 20:27:46 UTC]

Created attachment 217639 [details, diff]
prefix patch

[Comment 8 Samuli Suominen (RETIRED) 2010-01-27 20:38:24 UTC]

(In reply to comment #6)
> @sound: please consider the to be attached patch
> 

I trust you. Feel free to commit.

[Comment 9 Fabian Groffen 2010-01-27 20:40:24 UTC]

it's in your source repos I presume, so I frankly prefer you to commit it yourself ;)

[Comment 10 Ulrich Müller 2010-01-27 21:32:58 UTC]

(In reply to comment #9)
> it's in your source repos I presume, so I frankly prefer you to commit it
> yourself ;)

It's in the eselect svn repo. Committed (and fixed some quotes).
@sound: Shall I make a release for you? :-)

[Comment 11 Ulrich Müller 2010-01-30 18:17:48 UTC]

Bumped and prefix keywords added.