Bug 301941 – app-crypt/gnupg: pcsc-lite and openct USE flags should be conditional to smartcard USE flag

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Diego Elio Pettenò (RETIRED) 2010-01-23 15:23:07 UTC]

I guess I could just commit that myself if you gave me the go, but in general, there are two approaches:

 * you can make the openct and pcsc-lite dependencies conditional to the smartcard USE flag to be enabled, and then add a pkg_setup warning telling the user that there is no point into enabling the two if smartcard is disabled;
 * you can have any of the three USE flags to enable scdaemon (maybe adding a warning if pcsc-lite or opect are enabled and smartcard is not).

I like the latter approach better as it seems more “what the users want”…

[Comment 1 Dane Smith (RETIRED) 2010-07-19 19:20:54 UTC]

Created attachment 239429 [details]
Ebuild for gnupg

I went with option #2. It will not warn in pkg_setup if user has openct or pcsc-lite w/o having smartcard. It will also set --enable-scdaemon if any of the three are set.

Diff to follow.

[Comment 2 Dane Smith (RETIRED) 2010-07-19 19:21:19 UTC]

Created attachment 239431 [details]
Diff from gnupg-2.0.15.ebuild

[Comment 3 Dane Smith (RETIRED) 2010-07-19 19:21:47 UTC]

(In reply to comment #1)
> Created an attachment (id=239429) [details]
> Ebuild for gnupg
> 
> I went with option #2. It will not warn in pkg_setup if user has openct or
> pcsc-lite w/o having smartcard. It will also set --enable-scdaemon if any of
> the three are set.
> 
> Diff to follow.
> 


That should it *will* warn in pkg_setup.

[Comment 4 Dane Smith (RETIRED) 2010-08-11 01:19:44 UTC]

Created attachment 242367 [details]
Diff from gnupg-2.0.15.ebuild

Fixed a typo in my diff that I just happened to catch.

[Comment 5 Dane Smith (RETIRED) 2010-08-11 01:20:54 UTC]

Created attachment 242369 [details]
Corrected full ebuild

[Comment 6 Robin Johnson 2010-10-19 01:42:20 UTC]

Added to 2.0.16-r2.