Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 301279 - php-fpm support for app-admin/php-toolkit
Summary: php-fpm support for app-admin/php-toolkit
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: PHP Bugs
Depends on:
Blocks: 208155
  Show dependency tree
Reported: 2010-01-17 13:55 UTC by Denis Seleznyov
Modified: 2010-09-11 12:44 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Trivial add of new binary support (php-toolkit-fpm.patch,1.55 KB, patch)
2010-01-17 13:57 UTC, Denis Seleznyov
Details | Diff
test ebuild (php-toolkit-1.0.2.ebuild,965 bytes, text/plain)
2010-01-18 11:30 UTC, Denis Seleznyov

Note You need to log in before you can comment on or make changes to this bug.
Description Denis Seleznyov 2010-01-17 13:55:08 UTC
php-fpm is not yet standard part of php, but this project is quite popular across gentoo users.
For a long time, it was running as 'php-cgi --fpm', but when added to official php svn tree, binary name was changed to 'php-fpm'

This change will be included in php-5.3.3, or (hopefully) 5.3.2

Please add support for additional binary.

Reproducible: Always
Comment 1 Denis Seleznyov 2010-01-17 13:57:10 UTC
Created attachment 216733 [details, diff]
Trivial add of new binary support
Comment 2 Denis Seleznyov 2010-01-18 11:30:20 UTC
Created attachment 216797 [details]
test ebuild

Added ebuild for quick feature preview opportunity.
Comment 3 Mark Kiami 2010-02-07 15:21:29 UTC
I have installed php-toolkit-1.0.2.ebuild, then the usual php-5.2.12.ebuild from bug 208155. As mentioned the binary 'php-cgi --fpm' changed to 'php-fpm', but the /etc/init.d/php-fpm still had :

        start-stop-daemon --start --pidfile=/var/run/ \
               --exec /usr/bin/php-cgi -- --fpm

I have manually edited the file /etc/init.d/php-fpm file to:

        start-stop-daemon --start --pidfile=/var/run/ \
               --exec /usr/bin/php-fpm

Shouldn't this file be updated automatically by the new ebuild?

Thanks and regards

Comment 4 Denis Seleznyov 2010-02-07 15:36:35 UTC
(In reply to comment #3)
> I have manually edited the file /etc/init.d/php-fpm file ...
> Shouldn't this file be updated automatically by the new ebuild?
Please make sure you updated php-fpm.init file to attachment #212634 [details] from bug #208155
Then make sure you ran dispatch-conf
Also, php-toolkit has nothing to do with this problem, please comment bug #208155 if you have some improvement.
Comment 5 Matti Bickel (RETIRED) gentoo-dev 2010-06-19 16:39:49 UTC
Patch looks good to me. I'll see about getting this included in the next version bump of php-toolkit.
Comment 6 Denis Seleznyov 2010-09-10 12:07:55 UTC
As far as I understand, php-toolkit is not used anymore.
Comment 7 Matti Bickel (RETIRED) gentoo-dev 2010-09-11 12:44:14 UTC
Yep, it's going away in favor of a new eselect module (which will support fpm)...