Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 300657 - app-misc/realpath build fails on uclibc without nls
Summary: app-misc/realpath build fails on uclibc without nls
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: x86 Linux
: High normal (vote)
Assignee: Gentoo Shell Tools project
URL:
Whiteboard:
Keywords:
: 319131 (view as bug list)
Depends on: 308477
Blocks:
  Show dependency tree
 
Reported: 2010-01-12 03:25 UTC by Gianluigi Tiesi
Modified: 2010-06-15 20:04 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
modified ebuild script (realpath-1.15.ebuild,1.52 KB, patch)
2010-01-12 03:27 UTC, Gianluigi Tiesi 		Details | Diff
this patch will rip out locale stuff if not nls (realpath-1.15-nonls.patch,583 bytes, patch)
2010-01-12 03:27 UTC, Gianluigi Tiesi 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gianluigi Tiesi 2010-01-12 03:25:46 UTC 
realpath is a requisite for getoolkit and it fails build on my uclibc without nls
the ebuild also has src_prepare part that is not evaluated and two patches are outdated, I've fixed the ebuild and added a patch.
I tried a patch with ifdefs but finally is more easy to completely wipe locale stuff when nls is not specified (small patch)

I'll attach files

Reproducible: Always
Comment 1 Gianluigi Tiesi 2010-01-12 03:27:27 UTC 
Created attachment 216157 [details, diff]
modified ebuild script
Comment 2 Gianluigi Tiesi 2010-01-12 03:27:52 UTC 
Created attachment 216159 [details, diff]
this patch will rip out locale stuff if not nls
Comment 3 Anthony Basile gentoo-dev 2010-01-29 03:13:38 UTC 
I tested the ebuild and patch on mips-uclibc, x86-uclibc and x86_64-uclibc and it worked.  I recommend putting it on the mirrors.

Just one very minor point: check the indentation of the "else" in src_unpack().
Comment 4 Gianluigi Tiesi 2010-01-29 04:01:26 UTC 
spaces vs tabs, I use expandtab and I haven't noticed the ebuild was using tabs instead of spaces
Comment 5 Justin Lecher (RETIRED) gentoo-dev 2010-04-30 17:11:07 UTC 
+*realpath-1.15-r1 (30 Apr 2010)
+
+  30 Apr 2010; Justin Lecher <jlec@gentoo.org> +realpath-1.15-r1.ebuild,
+  +files/realpath-1.15-nonls.patch:
+  Fix for #300657, thanks Gianluigi Tiesi for providing the patches
+
Comment 6 SpanKY gentoo-dev 2010-06-15 20:04:36 UTC 
*** Bug 319131 has been marked as a duplicate of this bug. ***