Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 300360 - net-libs/xulrunner 1.9.1.7 fails when applying patches due to new epatch not handling EPATCH_EXCLUDE correctly
Summary: net-libs/xulrunner 1.9.1.7 fails when applying patches due to new epatch not ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: High normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
: 300185 300383 300416 300424 300435 300442 300479 300485 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-01-10 03:11 UTC by Kenton Groombridge
Modified: 2010-01-10 22:02 UTC (History)
14 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Failed patch output. (136-fix_ftbfs_with_cairo_fb.patch.out,4.25 KB, text/plain)
2010-01-10 12:04 UTC, Nico Schlömer
Details
xulrunner-1.9.1.7.ebuild.patch (xulrunner-1.9.1.7.ebuild.patch,385 bytes, patch)
2010-01-10 13:30 UTC, Ben de Groot (RETIRED)
Details | Diff
Fixes eutils to break out of the right loop (eutils.patch,532 bytes, patch)
2010-01-10 15:03 UTC, Maurice van der Pot (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenton Groombridge 2010-01-10 03:11:21 UTC
When performing normal test updates tonight, xulrunner failed when applying patches.  It looked like I had an imcomplete sync, so I waited several hours and tried again with the same fail.

Reproducible: Always

Steps to Reproduce:
1. emerge --sync;emerge -DNvu world

Actual Results:  
xulrunner fails when applying patches with the following:

 * Applying various patches (bugfixes/updates) ...                                                                                 
 *   001-xul_gentoo_install_dirs.patch ...                                                                                    [ ok ]
 *   065-bzXXX_pc_honour_system_nspr_nss-gentoo_fixed.patch ...                                                               [ ok ]
 *   066-fix-includedir-mozilla-js.patch ...                                                                                  [ ok ]
 *   067-fix-includedir-mozilla-plugin.patch ...                                                                              [ ok ]
 *   102-dont_install_so_in_dev.patch ...                                                                                     [ ok ]
 *   104-protect_tests_by_ifdefs.patch ...                                                                                    [ ok ]
 *   108-bzXXX_no_zlib_export_if_native.patch ...                                                                             [ ok ]
 *   112-bz466923_att350251_password_prompt_branding_fallback.patch ...                                                       [ ok ]
 *   118-bz467766_att351173-dont-reset-user-prefs-on-upgrade.patch ...                                                        [ ok ]
 *   135-xulrunner-1.9.1.1-nptypes.h.patch ...                                                                                [ ok ]
 * ERROR: net-libs/xulrunner-1.9.1.7 failed:                                                                                        
 *   eshopts_{push,pop}: unbalanced pair                                                                                            
 *                                                                                                                                  
 * Call stack:                                                                                                                      
 *     ebuild.sh, line   54:  Called src_prepare                                                                                    
 *   environment, line 6217:  Called epatch '/var/tmp/portage/net-libs/xulrunner-1.9.1.7/work'                                      
 *   environment, line 2220:  Called eshopts_pop                                                                                    
 *   environment, line 2332:  Called die                                                                                            
 * The specific snippet of code:                                                                                                    
 *       [[ ${i} -eq -1 ]] && die "eshopts_{push,pop}: unbalanced pair";                                                            
 *                                                                                                                                  
 * If you need support, post the output of 'emerge --info =net-libs/xulrunner-1.9.1.7',                                             
 * the complete build log and the output of 'emerge -pqv =net-libs/xulrunner-1.9.1.7'.                                              
!!! When you file a bug report, please include the following information:                                                           
GENTOO_VM=sun-jdk-1.6  CLASSPATH="" JAVA_HOME="/opt/sun-jdk-1.6.0.17"                                                               
JAVACFLAGS="-source 1.4 -target 1.4" COMPILER=""                                                                                    
and of course, the output of emerge --info                                                                                          
 * The complete build log is located at '/var/tmp/portage/net-libs/xulrunner-1.9.1.7/temp/build.log'.                               
 * The ebuild environment file is located at '/var/tmp/portage/net-libs/xulrunner-1.9.1.7/temp/environment'.                        
 * S: '/var/tmp/portage/net-libs/xulrunner-1.9.1.7/work/mozilla-1.9.1'                                                              

>>> Failed to emerge net-libs/xulrunner-1.9.1.7, Log file:

>>>  '/var/tmp/portage/net-libs/xulrunner-1.9.1.7/temp/build.log'

 * Messages for package net-libs/xulrunner-1.9.1.7:

 * ERROR: net-libs/xulrunner-1.9.1.7 failed:
 *   eshopts_{push,pop}: unbalanced pair    
 *
 * Call stack:
 *     ebuild.sh, line   54:  Called src_prepare
 *   environment, line 6217:  Called epatch '/var/tmp/portage/net-libs/xulrunner-1.9.1.7/work'
 *   environment, line 2220:  Called eshopts_pop
 *   environment, line 2332:  Called die
 * The specific snippet of code:
 *       [[ ${i} -eq -1 ]] && die "eshopts_{push,pop}: unbalanced pair";
 *
 * If you need support, post the output of 'emerge --info =net-libs/xulrunner-1.9.1.7',
 * the complete build log and the output of 'emerge -pqv =net-libs/xulrunner-1.9.1.7'.
 * The complete build log is located at '/var/tmp/portage/net-libs/xulrunner-1.9.1.7/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/net-libs/xulrunner-1.9.1.7/temp/environment'.
 * S: '/var/tmp/portage/net-libs/xulrunner-1.9.1.7/work/mozilla-1.9.1'


Expected Results:  
xulrunner should build successfully.

Portage 2.1.7.16 (default/linux/amd64/10.0/desktop, gcc-4.4.2, glibc-2.11-r1, 2.6.32-zen4 x86_64)
=================================================================
System uname: Linux-2.6.32-zen4-x86_64-AMD_Phenom-tm-_9850_Quad-Core_Processor-with-gentoo-2.0.1
Timestamp of tree: Sun, 10 Jan 2010 03:00:01 +0000
app-shells/bash:     4.0_p35
dev-java/java-config: 2.1.10
dev-lang/python:     2.6.4, 3.1.1-r1
dev-util/cmake:      2.8.0
sys-apps/baselayout: 2.0.1
sys-apps/openrc:     0.6.0
sys-apps/sandbox:    2.2
sys-devel/autoconf:  2.13, 2.65
sys-devel/automake:  1.9.6-r2, 1.10.3, 1.11.1
sys-devel/binutils:  2.20
sys-devel/gcc-config: 1.4.1
sys-devel/libtool:   2.2.6b
virtual/os-headers:  2.6.30-r1
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="* -@EULA Nero-EULA-US dlj-1.1"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=amdfam10 -mtune=amdfam10 -msse3 -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/X11/xkb /usr/share/config /var/lib/hsqldb"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-march=amdfam10 -mtune=amdfam10 -msse3 -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="assume-digests distlocks fixpackages news parallel-fetch protect-owned sandbox sfperms strict unmerge-logs unmerge-orphans userfetch"
GENTOO_MIRRORS="ftp://gentoo.mirrors.pair.com/ http://open-systems.ufl.edu/mirrors/gentoo http://130.208.16.26/pub/gentoo/ http://130.208.16.31/pub/gentoo/ ftp://91.121.125.139/gentoo-distfiles/"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1"
LINGUAS="en en_US"
MAKEOPTS="-j5"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_EXTRA_OPTS="--timeout=120"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage/layman/Spring /usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="3dnow 3dnowext S3TC X a52 aac acpi aften alsa amarok amd64 amrnb audiofile bash-completion berkdb binary-drivers bzip2 cairo cddb cdparanoia cdr cdrom consolekit cracklib crypt css cups curl cxx dbus dri dts dv dvd dvdr eds emoticon encode expat extras fame ffmpeg fftw firefox flac foomaticdb gdbm gif gimp glibc-omitfp glitz glut gnome gnutls graphite gstreamer gtk gzip hal iconv ieee1394 imagemagick imlib iproute2 java javascript joystick jpeg jpeg2k kde kipi lame ldap libnotify libvisual live lm_sensors logitech-mouse lzo mad mikmod mjpeg mmx mmxext mng modules mp2 mp3 mp4 mpeg mplayer multilib musicbrainz mysql ncurses network nls normalize nptl nptlonly nsplugin nspr nvidia offensive ogg openal opengl openmp pam pango pcre pdf perl physfs png ppds python qt3 qt3support qt4 quicktime rar readline rtc samba sasl scanner sdl smartcard sound spell sse sse2 sse3 ssl startup-notification subtitles svg svgz sysfs syslog tcpd templates theora threadsafe thunar tiff transcode truetype unicode unzip urandom usb userlocales utempter v4l2 vcd vdpau videos visualization vorbis wav wifi wma wmf x264 xcomposite xine xml xorg xpm xscreensaver xulrunner xv xvid xvmc zip zlib" ALSA_CARDS="emu10k1" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CAMERAS="canon ptp2" DVB_CARDS="dvb_usb_dib0700" ELIBC="glibc" INPUT_DEVICES="keyboard evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="en en_US" RUBY_TARGETS="ruby18" SANE_BACKENDS="epson" USERLAND="GNU" VIDEO_CARDS="nvidia"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, FFLAGS, INSTALL_MASK, LC_ALL, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS
Comment 1 Nico Schlömer 2010-01-10 04:17:42 UTC
Same here with xulrunner-1.9.1.7

======================= *snip* =======================
 * ERROR: net-libs/xulrunner-1.9.1.6 failed.
 * Call stack:
 *               ebuild.sh, line   49:  Called src_prepare
 *             environment, line 6101:  Called epatch '/var/tmp/portage/net-libs/xulrunner-1.9.1.6/work'
 *             environment, line 2122:  Called eshopts_pop
 *             environment, line 2234:  Called die
 * The specific snippet of code:
 *       [[ ${i} -eq -1 ]] && die "eshopts_{push,pop}: unbalanced pair";
 *  The die message:
 *   eshopts_{push,pop}: unbalanced pair
======================= *snap* =======================
Comment 2 Philip Webb 2010-01-10 04:59:39 UTC
Same here with 1.9.1.7
Comment 3 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2010-01-10 05:20:39 UTC
All - please stop with the "me too" comments. Thanks.

Assigning to the mozilla team.

Adding CC to eutils.eclass maintainers. I have confirmed that there is no issue when using Revision 1.324 of the eclass. Maybe there is a problem with the commit?
Comment 5 Nico Schlömer 2010-01-10 12:04:11 UTC
Created attachment 215921 [details]
Failed patch output.

Well, now I get

=============================== *snip* ===============================
 *   136-fix_ftbfs_with_cairo_fb.patch ...

 * Failed Patch: 136-fix_ftbfs_with_cairo_fb.patch !
 *  ( /var/tmp/portage/net-libs/xulrunner-1.9.1.7/work/136-fix_ftbfs_with_cairo_fb.patch )
=============================== *snap* ===============================

Cheers,
Nico
Comment 6 Ben de Groot (RETIRED) gentoo-dev 2010-01-10 13:25:10 UTC
*** Bug 300383 has been marked as a duplicate of this bug. ***
Comment 7 Ben de Groot (RETIRED) gentoo-dev 2010-01-10 13:27:18 UTC
This is still a problem. Even with the 1.326 revision of eutils.eclass, 136-fix_ftbfs_with_cairo_fb.patch still fails to be excluded, resulting in a die because it fails to apply.
Comment 8 Ben de Groot (RETIRED) gentoo-dev 2010-01-10 13:30:37 UTC
Created attachment 215930 [details, diff]
xulrunner-1.9.1.7.ebuild.patch

This patch is a workaround. It fixes this ebuild, but the eclass still needs to be fixed.
Comment 9 Ben de Groot (RETIRED) gentoo-dev 2010-01-10 13:56:31 UTC
*** Bug 300416 has been marked as a duplicate of this bug. ***
Comment 10 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2010-01-10 14:15:46 UTC
*** Bug 300424 has been marked as a duplicate of this bug. ***
Comment 11 Maurice van der Pot (RETIRED) gentoo-dev 2010-01-10 15:03:21 UTC
Created attachment 215964 [details, diff]
Fixes eutils to break out of the right loop

(In reply to comment #4)

Spanky, the continue was intended to break out the outer loop instead of the inner, so the eshopts_pop before continue was correct. 
What was missing was "2" after continue to break out of both loops.

I attached a patch that applies to current cvs. It undoes the previous fix and adds a parameter to continue.
Comment 12 Jon Gerdes 2010-01-10 15:04:23 UTC
(In reply to comment #8)
> Created an attachment (id=215930) [details]
> xulrunner-1.9.1.7.ebuild.patch
> 
> This patch is a workaround. It fixes this ebuild, but the eclass still needs to
> be fixed.
> 

Thanks a lot for that.  This is a new machine and this was really starting to annoy me ...

Workaround works for me 8)
Comment 13 Tomáš Chvátal (RETIRED) gentoo-dev 2010-01-10 15:59:32 UTC
Done, thx for the patch. Much better than my hack to fix it :]
Comment 14 Jory A. Pratt gentoo-dev 2010-01-10 19:56:16 UTC
*** Bug 300442 has been marked as a duplicate of this bug. ***
Comment 15 Jory A. Pratt gentoo-dev 2010-01-10 19:56:24 UTC
*** Bug 300185 has been marked as a duplicate of this bug. ***
Comment 16 Jory A. Pratt gentoo-dev 2010-01-10 20:07:23 UTC
*** Bug 300479 has been marked as a duplicate of this bug. ***
Comment 17 SpanKY gentoo-dev 2010-01-10 21:28:18 UTC
*** Bug 300435 has been marked as a duplicate of this bug. ***
Comment 18 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2010-01-10 22:02:45 UTC
*** Bug 300485 has been marked as a duplicate of this bug. ***