Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 300155 - ebuild request: media-sound/moc-2.5.0_alpha4-r1 turns on musepack support
Summary: ebuild request: media-sound/moc-2.5.0_alpha4-r1 turns on musepack support
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Linux bug wranglers
URL: http://moc.daper.net/
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-08 12:03 UTC by Hack_leberry Finn
Modified: 2010-01-09 12:16 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
new ebuild (moc-2.5.0_alpha4-r1.ebuild,2.00 KB, text/plain)
2010-01-08 12:04 UTC, Hack_leberry Finn
Details
patch (moc-2.5.0_alpha4-libmpcdecsv7.patch,1.32 KB, text/plain)
2010-01-08 12:05 UTC, Hack_leberry Finn
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Hack_leberry Finn 2010-01-08 12:03:33 UTC
moc-2.5.0_alpha4.ebuild doesn't support musepack codec, so here is new (rev. 1) ebuild and patch which brings support for "mpc" files. I have tested it only on x86 platform but this patch is very similar to its "alpha3" version, so i suppose that it will work on other platforms.
Comment 1 Hack_leberry Finn 2010-01-08 12:04:35 UTC
Created attachment 215635 [details]
new ebuild
Comment 2 Hack_leberry Finn 2010-01-08 12:05:06 UTC
Created attachment 215636 [details]
patch
Comment 3 Samuli Suominen (RETIRED) gentoo-dev 2010-01-08 12:14:54 UTC
Closing is INVALID, the patch is only bringing in the dead transitional library. The new libmpcdec is in media-sound/musepack-tools, with SV8 format, and new API.
Comment 4 Hack_leberry Finn 2010-01-08 12:59:58 UTC
(In reply to comment #3)
> Closing is INVALID, the patch is only bringing in the dead transitional
> library. The new libmpcdec is in media-sound/musepack-tools, with SV8 format,
> and new API.
> 

That's right, but I've no SV8 format files. :) So this was my solution, for listening some of my files. Maybe it would be smart to make flag "musepack7" and "musepack8" in that case, instead one "musepack" (like with "qt4" and "qt3" flags). 
Comment 5 Samuli Suominen (RETIRED) gentoo-dev 2010-01-08 13:47:57 UTC
(In reply to comment #4)
> (In reply to comment #3)
> > Closing is INVALID, the patch is only bringing in the dead transitional
> > library. The new libmpcdec is in media-sound/musepack-tools, with SV8 format,
> > and new API.
> > 
> 
> That's right, but I've no SV8 format files. :) So this was my solution, for
> listening some of my files. Maybe it would be smart to make flag "musepack7"
> and "musepack8" in that case, instead one "musepack" (like with "qt4" and "qt3"
> flags). 
> 

libmpcdecsv7 will be masked for removal in a week or two, only waiting for arch teams to test new xine-lib to stable with the sv8 support

so it needs to support the new API, or nothing, note that the new API is perfectly capable of decoding also SV7 files, so that's no excuse of not supporting it
Comment 6 Hack_leberry Finn 2010-01-08 14:23:34 UTC
(In reply to comment #5)
> 
> libmpcdecsv7 will be masked for removal in a week or two, only waiting for arch
> teams to test new xine-lib to stable with the sv8 support
> 
> so it needs to support the new API, or nothing, note that the new API is
> perfectly capable of decoding also SV7 files, so that's no excuse of not
> supporting it
> 

:) OK. If you say so. I have written to Damian Pietras (author of moc), asking if he was compiling moc with musepack sv8 version. Because I think He doesn't, and that's why problem occured. If He doesn't maybe it will be good case for leaving libmpcdecsv7 still in tree.
 
Comment 7 Samuli Suominen (RETIRED) gentoo-dev 2010-01-08 14:43:41 UTC
(In reply to comment #6)
> and that's why problem occured. If He doesn't maybe it will be good case for
> leaving libmpcdecsv7 still in tree.

No, that's why this is marked as INVALID, as libmpcdecsv7 doesn't even compile in ~arch anymore, with >=autoconf-2.65, and it won't be fixed.

The _only_ way to keep Musepack support in MOC is to add the SV8 support.
Comment 8 Hack_leberry Finn 2010-01-08 16:11:01 UTC
(In reply to comment #7)
> 
> No, that's why this is marked as INVALID, as libmpcdecsv7 doesn't even compile
> in ~arch anymore, with >=autoconf-2.65, and it won't be fixed.
> 
> The _only_ way to keep Musepack support in MOC is to add the SV8 support.
> 

:) My autoconf is 2.64 (I had to use this "~" package, because of other dependencies), so I didn't have problem with libmpcdecsv7. This solution as You wrote, is _invalid_if_you_need_support_of_sv8_version_. When somebody use <=autoconf-2.64 and libmpcdecsv7 this patch will work (until he will have libmpcdecsv7 in system). So _this_solution_should_never_be_put_in_main_tree_, but may be helpful for someone. When Damian Pietras write to me I will post his answer. Then it will be known, how many work musepack sv8 support in moc will need, or if it is possible in general.
Comment 9 Hack_leberry Finn 2010-01-09 12:16:24 UTC
Damian Pietras answer (in polish):

Nie probowalem kompilacji z ta wersja. Widze, ze patch zmienia sciezki i
nazy plikow biblioteki na mpcdecsv7, czy jest to zmiana tylko w gentoo?
Sciagnalem zrodla biblioteki i nie wyglada na to, ze tam tak sie nazywa.

This means:

I didn't try compilation with this version [sv8]. I see, that patch changed paths and filenames of library to mpcdecsv7. Is this change made only in gentoo? I have downloaded library sources and I did not found names like this it there.

So, MOC is not support musepack sv8 version, and some general works are needed to make this. Status is still the same.