Bug 297134 – net-analyzer/rrdtool installs Perl modules into site-dir (should go in vendor-dir)

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Diego Elio Pettenò (RETIRED) 2009-12-16 10:03:10 UTC]

/usr/lib/perl5/site_perl/5.8.8
/usr/lib/perl5/site_perl/5.8.8/RRDp.pm
/usr/lib/perl5/site_perl/5.8.8/i686-linux
/usr/lib/perl5/site_perl/5.8.8/i686-linux/auto
/usr/lib/perl5/site_perl/5.8.8/i686-linux/auto/RRDp
/usr/lib/perl5/site_perl/5.8.8/i686-linux/auto/RRDp/.packlist
/usr/lib/perl5/site_perl/5.8.8/i686-linux/auto/RRDs
/usr/lib/perl5/site_perl/5.8.8/i686-linux/auto/RRDs/RRDs.so
/usr/lib/perl5/site_perl/5.8.8/i686-linux/auto/RRDs/.packlist
/usr/lib/perl5/site_perl/5.8.8/i686-linux/auto/RRDs/RRDs.bs
/usr/lib/perl5/site_perl/5.8.8/i686-linux/RRDs.pm

[Comment 1 David Abbott (RETIRED) 2009-12-28 02:11:43 UTC]

Created attachment 214365 [details, diff]
rrdtool-1.3.8-PERLVENDOR.patch

/usr/lib/perl5/vendor_perl/5.8.8/i686-linux/RRDs.pm
/usr/lib/perl5/vendor_perl/5.8.8/i686-linux/auto/RRDp/.packlist
/usr/lib/perl5/vendor_perl/5.8.8/i686-linux/auto/RRDs/.packlist
/usr/lib/perl5/vendor_perl/5.8.8/i686-linux/auto/RRDs/RRDs.bs
/usr/lib/perl5/vendor_perl/5.8.8/i686-linux/auto/RRDs/RRDs.so
/usr/lib/perl5/vendor_perl/5.8.8/RRDp.pm

[Comment 2 Torsten Veller (RETIRED) 2010-05-25 09:10:58 UTC]

Created attachment 232851 [details, diff]
perl patch

Installs modules to vendor_perl.
Does not install unnecessary '.packlist's.
Drops the perl-module_pkg_* calls. They are not needed.

[Comment 3 Jeroen Roovers (RETIRED) 2010-05-26 19:07:55 UTC]

Thank you. I was ready to put that in the tree but the patch reverted some of the latest changes, so only these were left. Can you confirm that this is how it should look against CVS rev 1.5?


Index: rrdtool-1.4.2.ebuild
===================================================================
RCS file: /var/cvsroot/gentoo-x86/net-analyzer/rrdtool/rrdtool-1.4.2.ebuild,v
retrieving revision 1.5
diff -u -B -r1.5 rrdtool-1.4.2.ebuild
--- rrdtool-1.4.2.ebuild        26 May 2010 17:03:56 -0000      1.5
+++ rrdtool-1.4.2.ebuild        26 May 2010 19:06:17 -0000
@@ -53,6 +53,7 @@
                $(use_enable ruby ruby-site-install) \
                $(use_enable perl) \
                $(use_enable perl perl-site-install) \
+               --with-perl-options=INSTALLDIRS=vendor \
                $(use_enable tcl) \
                $(use_with tcl tcllib "${EPREFIX}"/usr/$(get_libdir)) \
                $(use_enable python)
@@ -65,7 +66,10 @@
                rm -rf "${ED}"usr/share/doc/${PF}/{html,txt}
        fi
 
-       use perl && perl_delete_localpod
+       if use perl ; then
+               fixlocalpod
+               perl_delete_packlist
+       fi
 
        dodoc CHANGES CONTRIBUTORS NEWS README THREADS TODO
 }

[Comment 4 Torsten Veller (RETIRED) 2010-05-26 20:06:02 UTC]

(In reply to comment #3)
> Can you confirm that this is how it should look against CVS rev 1.5?

Yes. But you can s/fixlocalpod/perl_delete_localpod/ like this:

> -       use perl && perl_delete_localpod
> +       if use perl ; then
> +               fixlocalpod
                  perl_delete_localpod

Thanks.

[Comment 5 Jeroen Roovers (RETIRED) 2010-05-26 20:12:23 UTC]

(In reply to comment #4)
> (In reply to comment #3)
> > Can you confirm that this is how it should look against CVS rev 1.5?
> 
> Yes. But you can s/fixlocalpod/perl_delete_localpod/ like this:
> 
> > -       use perl && perl_delete_localpod
> > +       if use perl ; then
> > +               fixlocalpod
>                   perl_delete_localpod

That looks confusing. You mean, without perl_delete_localpod? Feel free to commit the changes yourself.

[Comment 6 Torsten Veller (RETIRED) 2010-05-26 20:30:02 UTC]

Done.