295199 – sci-biology/fasttree: fails with forced --as-needed

Bug 295199 - sci-biology/fasttree: fails with forced --as-needed

Summary: sci-biology/fasttree: fails with forced --as-needed

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	High QA (vote)
Assignee:	Andrey Kislyuk (RETIRED)

URL:	http://www.gentoo.org/proj/en/qa/asne...
Whiteboard:
Keywords:	InVCS

Depends on:
Blocks:	as-needed
	Show dependency tree

Reported:	2009-11-30 15:44 UTC by Diego Elio Pettenò (RETIRED)
Modified:	2010-06-20 18:21 UTC (History)
CC List:	3 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Build log (fasttree-2.0.1:20091130-154143.log,5.43 KB, text/plain) 2009-11-30 15:45 UTC, Diego Elio Pettenò (RETIRED)	Details
adding epatch to ebuild (fasttree-2.0.1.diff,640 bytes, patch) 2009-12-06 18:45 UTC, Kacper Kowalik (Xarthisius) (RETIRED)	Details \| Diff
fixing as-needed issues (fasttree-2.0.1-as-needed.patch,386 bytes, text/plain) 2009-12-06 18:47 UTC, Kacper Kowalik (Xarthisius) (RETIRED)	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2009-11-30 15:44:44 UTC

I'm reporting this bug because the package in summary fails to build when forcing --as-needed on through spec files (check out http://blog.flameeyes.eu/2008/11/14/problems-and-mitigation-strategies-for-as-needed for details).

Please note that this bug _might_ apply to -Wl,--as-needed in LDFLAGS as well; in both cases it should be fixed. Also, if this is due to the package in question not respecting user-defined LDFLAGS, you should get to fix that too.

Check the attached build log.

Thanks,
Diego

Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev

2009-11-30 15:45:09 UTC

Created attachment 211592 [details]
Build log

Comment 2 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev

2009-12-06 18:45:19 UTC

Created attachment 212256 [details, diff]
adding epatch to ebuild

Comment 3 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev

2009-12-06 18:47:54 UTC

Created attachment 212258 [details]
fixing as-needed issues

I guess we should also get rid off CFLAGS set by hand in Makefile, but it's for maintainer to decide.

Comment 4 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev

2010-06-20 18:21:00 UTC

+  20 Jun 2010; Kacper Kowalik <xarthisius@gentoo.org> fasttree-2.0.1.ebuild,
+  +files/fasttree-2.0.1-asneeded.patch:
+  Respect FLAGS and fix as-needed issues wrt bug 295199. Thanks Diego for
+  reporting.
+