294396 – media-sound/milkytracker: fails with forced --as-needed

Bug 294396 - media-sound/milkytracker: fails with forced --as-needed

Summary: media-sound/milkytracker: fails with forced --as-needed

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	High QA (vote)
Assignee:	Gentoo Sound Team

URL:	http://www.gentoo.org/proj/en/qa/asne...
Whiteboard:
Keywords:

Depends on:
Blocks:	as-needed
	Show dependency tree

Reported:	2009-11-24 11:39 UTC by Diego Elio Pettenò (RETIRED)
Modified:	2010-02-06 13:17 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Build log (milkytracker-0.90.80:20091124-110331.log,96.02 KB, text/plain) 2009-11-24 11:39 UTC, Diego Elio Pettenò (RETIRED)	Details
fixing as-needed issues (milkytracker-0.90.80-external_zlib.diff,646 bytes, patch) 2010-01-15 17:30 UTC, Kacper Kowalik (Xarthisius) (RETIRED)	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2009-11-24 11:39:01 UTC

I'm reporting this bug because the package in summary fails to build when forcing --as-needed on through spec files (check out http://blog.flameeyes.eu/2008/11/14/problems-and-mitigation-strategies-for-as-needed for details).

Please note that this bug _might_ apply to -Wl,--as-needed in LDFLAGS as well; in both cases it should be fixed. Also, if this is due to the package in question not respecting user-defined LDFLAGS, you should get to fix that too.

Check the attached build log.

Thanks,
Diego

Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev

2009-11-24 11:39:34 UTC

Created attachment 211051 [details]
Build log

Comment 2 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev

2010-01-15 17:30:05 UTC

Created attachment 216619 [details, diff]
fixing as-needed issues

It was an error in external_zlib.patch that introduced the issue.

Comment 3 Samuli Suominen (RETIRED) gentoo-dev

2010-02-06 13:17:57 UTC

(In reply to comment #2)
> Created an attachment (id=216619) [details]
> fixing as-needed issues
> 
> It was an error in external_zlib.patch that introduced the issue. 
> 

oops, my fault :)

+  06 Feb 2010; Samuli Suominen <ssuominen@gentoo.org>
+  files/milkytracker-0.90.80-external_zlib.patch:
+  Fix building with -Wl,--as-needed wrt #294396 by Kacper Kowalik.