Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 291060 - patch for dev-util/colorgcc-1.3.2-r4: correctly process "note" gcc messages and split "intro" filename and message
Summary: patch for dev-util/colorgcc-1.3.2-r4: correctly process "note" gcc messages a...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Shell Tools Herd Bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-29 19:59 UTC by Cyril42e
Modified: 2009-12-25 03:20 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
adds correct "note" and "intro" messages processing (colorgcc.patch,1.88 KB, patch)
2009-10-29 20:03 UTC, Cyril42e
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cyril42e 2009-10-29 19:59:34 UTC
Recent versions of gcc have a "note" type of message, which is a complement to "error" or "warning" messages, but which is currently processed the same way than "error" (with the same colors). Consequently the "error" color can appear with a "warning", without any "error".

Moreover "intro" text is composed of a filename and a message, but it is currently not possible to use different color for filename and message.

My patch adds the following parameters:
+noteFileNameColor
+noteNumberColor
+noteMessageColor
-introColor
+introFileNameColor
+introMessageColor
and process them correctly.



Reproducible: Always

Steps to Reproduce:
/usr/include/boost-1_35/boost/date_time/constrained_value.hpp: In static member function 'static ymd_type_ boost::date_time::gregorian_calendar_base...':

/usr/include/boost-1_35/boost/date_time/constrained_value.hpp:64: warning: 'year.boost::gregorian::greg_year::<anonymous>.boost::CV::constrained_value<boost::CV::simple_exception_policy<short unsigned int, 1400u, 10000u, boost::gregorian::bad_year> >::value_' may be used uninitialized in this function

/usr/include/boost-1_35/boost/date_time/gregorian_calendar.ipp:122: note: 'year.boost::gregorian::greg_year::<anonymous>.boost::CV::constrained_value<boost::CV::simple_exception_policy<short unsigned int, 1400u, 10000u, boost::gregorian::bad_year> >::value_' was declared here


Actual Results:  
<IntroColor>
/usr/include/boost-1_35/boost/date_time/constrained_value.hpp: In static member function 'static ymd_type_ boost::date_time::gregorian_calendar_base...':
</IntroColor>

<WarningColors>
/usr/include/boost-1_35/boost/date_time/constrained_value.hpp:64: warning: 'year.boost::gregorian::greg_year::<anonymous>.boost::CV::constrained_value<boost::CV::simple_exception_policy<short unsigned int, 1400u, 10000u, boost::gregorian::bad_year> >::value_' may be used uninitialized in this function
</WarningColors>

<ErrorColors>
/usr/include/boost-1_35/boost/date_time/gregorian_calendar.ipp:122: note: 'year.boost::gregorian::greg_year::<anonymous>.boost::CV::constrained_value<boost::CV::simple_exception_policy<short unsigned int, 1400u, 10000u, boost::gregorian::bad_year> >::value_' was declared here
</ErrorColors>


Expected Results:  
<IntroFileNameColor>
/usr/include/boost-1_35/boost/date_time/constrained_value.hpp: </IntroFileNameColor><IntroMessageColor>In static member function 'static ymd_type_ boost::date_time::gregorian_calendar_base...':
</IntroMessageColor>

<WarningColors>
/usr/include/boost-1_35/boost/date_time/constrained_value.hpp:64: warning: 'year.boost::gregorian::greg_year::<anonymous>.boost::CV::constrained_value<boost::CV::simple_exception_policy<short unsigned int, 1400u, 10000u, boost::gregorian::bad_year> >::value_' may be used uninitialized in this function
</WarningColors>

<NoteColors>
/usr/include/boost-1_35/boost/date_time/gregorian_calendar.ipp:122: note: 'year.boost::gregorian::greg_year::<anonymous>.boost::CV::constrained_value<boost::CV::simple_exception_policy<short unsigned int, 1400u, 10000u, boost::gregorian::bad_year> >::value_' was declared here
</NoteColors>
Comment 1 Cyril42e 2009-10-29 20:03:26 UTC
Created attachment 208667 [details, diff]
adds correct "note" and "intro" messages processing
Comment 2 Jeremy Olexa (darkside) (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2009-12-25 03:20:03 UTC
added to -r5, thanks!