Bug 286166 – xfce-base/xfdesktop-4.6.1-r1[thunar]: desktop icons all overlap in the top left corner

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Hendrik Leppkes 2009-09-24 05:57:50 UTC]

Since the update to 4.6.1-r1 all desktop icons sit on one spot in the top left corner of the screen when using the thunar integration in xfdesktop.

Downgrading back to 4.6.1 fixes the issue.

Reproducible: Always

Steps to Reproduce:
1. Upgrade to xfdesktop 4.6.1-r1 with thunar useflag
2. Set "Icon Type" to "File/Launcher Icons" in the Desktop Settings->Appearance


Actual Results:  
All icons sit in one place and overlap, unable to drag them around.

Expected Results:  
The icons should all have their individual positions on the screen like before the update.

[Comment 1 Hendrik Leppkes 2009-09-24 05:58:44 UTC]

Created attachment 205080 [details]
Screenshot of the broken icon placement in 4.6.1-r1

Attached a screenshot of the icon placement in 4.6.1 and 4.6.1-r1 to show the bug.

[Comment 2 Samuli Suominen (RETIRED) 2009-09-24 17:50:37 UTC]

I've masked it for now. It's either a bug in the patch OR latest xfce4-dev-tools broke the eautoreconf someway for it. Will be fixed.

[Comment 3 Jeremy Olexa (darkside) (RETIRED) 2009-09-24 17:55:02 UTC]

(In reply to comment #2)
> I've masked it for now. It's either a bug in the patch OR latest
> xfce4-dev-tools broke the eautoreconf someway for it. Will be fixed.
> 

It would be easy to rule out the latter. Test xfdesktop-4.6.1-r1 with xfce4-dev-tools-4.7.0 instead of 4.7.2

[Comment 4 Hendrik Leppkes 2009-09-24 18:17:38 UTC]

(In reply to comment #3)
> It would be easy to rule out the latter. Test xfdesktop-4.6.1-r1 with
> xfce4-dev-tools-4.7.0 instead of 4.7.2

I can confirm, that the bug only exists with xfce4-dev-tools-4.7.2. 
After a downgrade to 4.7.0, xfdesktop-4.6.1-r1 works properly again.

[Comment 5 Samuli Suominen (RETIRED) 2009-09-25 08:29:50 UTC]

Created attachment 205188 [details, diff]
Difference between 4.7.0 and 4.7.2

This is a difference between xfdesktop 4.6.1 with dev-tools 4.7.0 and 4.7.2 after autoreconf.

[Comment 6 Samuli Suominen (RETIRED) 2009-09-25 08:40:01 UTC]

New test case:

- Use xfce4-dev-tools-4.7.0
- Add -fvisibility=hidden to CFLAGS and CXXFLAGS
- Recompile

Do you get the same overlapping as with 4.7.2?

[Comment 7 Hendrik Leppkes 2009-09-25 09:16:38 UTC]

(In reply to comment #6)
> New test case:
> 
> - Use xfce4-dev-tools-4.7.0
> - Add -fvisibility=hidden to CFLAGS and CXXFLAGS
> - Recompile
> 
> Do you get the same overlapping as with 4.7.2?
> 

No, everything is fine.

[Comment 8 Samuli Suominen (RETIRED) 2009-09-25 09:28:10 UTC]

Oh, the previous test was missing something.

CXXFLAGS="-fvisibility=hidden"
CFLAGS="-fvisibility=hidden"
CPPFLAGS="-DHAVE_GNUC_VISIBILITY"

And here's another one:

CPPFLAGS="-DG_DISABLE_CAST_CHECKS -DG_DISABLE_ASSERT -DG_DISABLE_CHECKS"

One of these should narrow the problem down...

[Comment 9 Hendrik Leppkes 2009-09-25 09:43:05 UTC]

(In reply to comment #8)
> Oh, the previous test was missing something.
> 
> CXXFLAGS="-fvisibility=hidden"
> CFLAGS="-fvisibility=hidden"
> CPPFLAGS="-DHAVE_GNUC_VISIBILITY"
> 
> And here's another one:
> 
> CPPFLAGS="-DG_DISABLE_CAST_CHECKS -DG_DISABLE_ASSERT -DG_DISABLE_CHECKS"
> 
> One of these should narrow the problem down...
> 

The second one causes the issue, the first one is still fine.

[Comment 10 Samuli Suominen (RETIRED) 2009-09-25 10:21:41 UTC]

Thanks for testing!

Reported to upstream: http://bugzilla.xfce.org/show_bug.cgi?id=5791

[Comment 11 Samuli Suominen (RETIRED) 2009-09-27 16:16:20 UTC]

  27 Sep 2009; Samuli Suominen <[e-mail]>
  xfdesktop-4.6.1-r1.ebuild, +files/xfdesktop-4.6.1-assert.patch:
  Fix assert handling wrt upstream #5791. Thanks to Alexis Ballier.

It's unmasked now.