Bug 283556 – [PATCH] app-text/xdvik-22.84.14-r1 compilation error

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description marbacz 2009-09-02 20:44:32 UTC]

There is a bug in app-text/xdvik, causing compilation error with glibc-2.10, gcc-4.4 and -O3 (at -O2 it compiles but it can fail at runtime). Attached patch fixes this.

x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H  -I. -I. -I.. -I./.. -W -Wall -Wunused  -I/usr/include/kpathsea -DPS_GS  -I./gui   -O3 -march=native -pipe  -c x_util.c -o x_util.o                                                                   
In file included from /usr/include/fcntl.h:217,                                                                                                                                                                                                                
                 from /usr/include/sys/file.h:25,                                                                                                                                                                                                              
                 from util.c:33:                                                                                                                                                                                                                               
In function ‘open’,                                                                                                                                                                                                                                            
    inlined from ‘T.143’ at util.c:276,                                                                                                                                                                                                                        
    inlined from ‘xdvi_temp_fd’ at util.c:869:                                                                                                                                                                                                                 
/usr/include/bits/fcntl2.h:51: error: call to ‘__open_missing_mode’ declared with attribute error: open with O_CREAT in second argument needs 3 arguments

[Comment 1 marbacz 2009-09-02 20:45:13 UTC]

Created attachment 203014 [details, diff]
Fix

[Comment 2 Petr Zima 2009-09-19 09:04:26 UTC]

Confirming this bug with the same configuration (glibc-2.10.1, gcc-4.4.1 -O3) on ~x86.

The patch fixes it, thanks!

[Comment 3 Alexis Ballier 2009-10-03 09:32:40 UTC]

applied in .16, thanks. Please dont forget to send it upstream.