Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 280153 - [new ebuild] net-im/kopete-facebook-0.1.3
Summary: [new ebuild] net-im/kopete-facebook-0.1.3
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo KDE team
URL: https://bugs.kde.org/show_bug.cgi?id=...
Whiteboard:
Keywords:
Depends on: 278859
Blocks:
  Show dependency tree
 
Reported: 2009-08-03 09:43 UTC by Dennis Schridde
Modified: 2009-10-14 23:38 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild (kopete-facebook-0.1.3.ebuild,625 bytes, text/plain)
2009-08-03 09:43 UTC, Dennis Schridde
Details
ebuild (kopete-facebook-0.1.3.ebuild,620 bytes, text/plain)
2009-08-03 09:44 UTC, Dennis Schridde
Details
patch for --as-needed (kopete-facebook-0.1.3-as-needed.patch,661 bytes, patch)
2009-08-03 09:45 UTC, Dennis Schridde
Details | Diff
updated ebuild (kopete-facebook-0.1.3.ebuild,620 bytes, text/plain)
2009-09-16 14:25 UTC, Fabio Correa
Details
Updated patch (kopete-facebook-0.1.3-as-needed.patch,281 bytes, text/plain)
2009-09-16 14:26 UTC, Fabio Correa
Details
Simple GIT ebuild (kopete-facebook-9999.ebuild,799 bytes, text/plain)
2009-09-29 13:30 UTC, Fabio Correa
Details
Updated ebuild as with new S= as emerge fails as-is (kopete-facebook-0.1.3.ebuild,832 bytes, text/plain)
2009-10-11 05:17 UTC, Aaron X
Details
folder-independent ebuild (kopete-facebook-0.1.3.ebuild,806 bytes, text/plain)
2009-10-14 12:31 UTC, Fabio Correa
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dennis Schridde 2009-08-03 09:43:22 UTC
Adds an ebuild for the kopete plugin discussed in https://bugs.kde.org/show_bug.cgi?id=161986

Reproducible: Always
Comment 1 Dennis Schridde 2009-08-03 09:43:51 UTC
Created attachment 200002 [details]
ebuild
Comment 2 Dennis Schridde 2009-08-03 09:44:54 UTC
Created attachment 200003 [details]
ebuild
Comment 3 Dennis Schridde 2009-08-03 09:45:19 UTC
Created attachment 200005 [details, diff]
patch for --as-needed
Comment 4 Theo Chatzimichos (RETIRED) archtester gentoo-dev Security 2009-08-04 06:40:03 UTC
I've already tried that with a live ebuild yesterday and it seemed pretty useless. The bugs i encountered are pretty well known upstream. I guess it will be better to wait till it becomes more useable. Thanks for the patch though.
As a side note, in the upstream bug you have reported 3 different bugs. This makes it difficult for the upstream developers to aggregate the bugs and solve them accordingly. Please consider openning different bug reports for each issue (the as-needed patch, the crash and the buddy list problem). Thank you
Comment 5 Dennis Schridde 2009-08-04 07:16:27 UTC
(In reply to comment #4)
> I guess it will be better to wait till it becomes more useable.
Yes, probably. But the Gentoo Bugzilla seemed to be a more appropriate location for the ebuild, thus I added it here.

> As a side note, in the upstream bug you have reported 3 different bugs.
> This makes it difficult for the upstream developers to aggregate the bugs
> and solve them accordingly.
For regular KDE software I would do this, but the kopete-facebook plugin is no KDE software (yet) and the maintainer has no own backtracker. So I am "abusing" KDE Bugzilla anyway, and therefore would like to keep the impact to a minimum.
Comment 6 Theo Chatzimichos (RETIRED) archtester gentoo-dev Security 2009-08-05 13:24:11 UTC
i added a live ebuild and 0.1.3 release in kde-testing, and added a facebook flag in overlay kopete ebuilds. I'll move it in tree when it becomes useable enough. Thanks
Comment 7 Fabio Correa 2009-09-16 14:25:19 UTC
Created attachment 204329 [details]
updated ebuild

Hello, great work with kopete-facebook. The proposed ebuild updates the source directory to reflect the latest change to the release tarball.
Comment 8 Fabio Correa 2009-09-16 14:26:03 UTC
Created attachment 204331 [details]
Updated patch

The proposed patch updates the source directory to reflect the latest change to the release tarball.
Comment 9 Fabio Correa 2009-09-29 13:30:42 UTC
Created attachment 205583 [details]
Simple GIT ebuild

A simple ebuild for the bold user. It grabs the latest GIT image and compiles it. I tested it on my x86 box.
Comment 10 George 2009-10-10 00:04:56 UTC
The kopete-facebook-0.1.3-as-needed.patch fails to apply in the ebuild in the portage tree.
Comment 11 Aaron X 2009-10-11 05:17:43 UTC
Created attachment 206729 [details]
Updated ebuild as with new S= as emerge fails as-is

emerge fails as tries to change to incorrect work directory
Comment 12 hirakendu 2009-10-12 10:04:06 UTC
As mentioned by #10 and #11, the workdir name takes only some part of the long name actually specified in the ebuild. Is it filesystem dependent? (In which case, something more needs to be done than just changing workdir variable ${S}.)

(To be honest, pretty disappointed by this ebuild hitting the main portage tree. Granted that the facebook USE flag in kopete is optional. But I felt that the ebuild has not been adequately tested. May be I am biased by my indifference to social networking websites :). In any case, thanks for the effort.)
Comment 13 Samuli Suominen (RETIRED) gentoo-dev 2009-10-14 11:59:02 UTC
0.1.3 is in portage, and I've fixed the MY_PN line. sync in a hour, and try.
Comment 14 Fabio Correa 2009-10-14 12:31:23 UTC
Created attachment 207078 [details]
folder-independent ebuild

Every time dmacvicar changes the directory name, the ebuild has to be updated. Hereby I propose an ebuild which strips dmacvicar's directory name when unpacking; this will save some overhead to the maintainers.

However, this ebuild might not be portable; please test and comment.

Any hope the GIT ebuild at comment #9 will hit the tree as well?

--- kopete-facebook-0.1.3.ebuild.orig   2009-10-14 07:06:10.407104208 -0500
+++ kopete-facebook-0.1.3.ebuild        2009-10-14 07:23:43.177103931 -0500
@@ -5,11 +5,9 @@
 EAPI=2
 inherit kde4-base

-MY_PN="dmacvicar-kopete-facebook-ffc26f6"
-
 DESCRIPTION="Facebook Chat support for Kopete"
 HOMEPAGE="http://duncan.mac-vicar.com/blog/archives/tag/facebook"
-SRC_URI="http://github.com/dmacvicar/kopete-facebook/tarball/release_0_1_3 -> ${MY_PN}.tar.gz"
+SRC_URI="http://github.com/dmacvicar/kopete-facebook/tarball/release_0_1_3 -> ${P}.tar.gz"

 LICENSE="GPL-2"
 KEYWORDS="~amd64 ~x86"
@@ -26,4 +24,7 @@

 PATCHES=( "${FILESDIR}/${PN}-as-needed.patch" )

-S=${WORKDIR}/${MY_PN}
+src_unpack() {
+       mkdir $S
+       tar -C $S --strip-components=1 --no-same-owner -xf ${DISTDIR}/${A}
+}
Comment 15 Aaron X 2009-10-14 23:38:19 UTC
Tested and works fine... (not sure about the reference to portability, I am fairly new to the Gentoo way of doing things!).

Would like to see the git ebuild committed as well, especially as it seems there is still some development to go on this package upstream.