Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 278047 - Wrong xfconf channel/option in xfprint-manager-4.6.1 main.c. Not see CUPS printers.
Summary: Wrong xfconf channel/option in xfprint-manager-4.6.1 main.c. Not see CUPS pri...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Printing (show other bugs)
Hardware: AMD64 Linux
: High normal (vote)
Assignee: XFCE Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-16 13:10 UTC by cache
Modified: 2010-05-12 20:34 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
working patch (main.diff,560 bytes, patch)
2009-07-16 13:17 UTC, cache
Details | Diff
xfprint-manager/main.c patch to show cups printers (xfconf_channel_fix.diff,1.10 KB, patch)
2010-02-26 09:45 UTC, Bailey Kong
Details | Diff
ebuild that applies patch (xfprint-4.6.1-r1.ebuild,1.10 KB, text/plain)
2010-02-26 09:46 UTC, Bailey Kong
Details

Note You need to log in before you can comment on or make changes to this bug.
Description cache 2009-07-16 13:10:40 UTC
Sorry for ugly English.

I have gentoo amd64 with xfce desktop. xfprint-manager-4.6.1 don't display any printers while cups system working fine. Selecting printing with xfprint-settings seems no effect. While starting xfprint-manager printing to console this message:

(xfprint4-manager:25410): WARNING **: xfprint: XfPrint/system is not set

As I discover this error appears because of using wrong property in xfprint-manager's main.c. As right property is "/xfprint/printing-system" xfprint-manager uses "/xfprint/system". After changing property name I have this message:

(xfprint4-manager:3513): WARNING **: Unable to load printing system module cups_plugin.so

but all working OK. I attach patch which fix this problem.

Reproducible: Always

Steps to Reproduce:
1. Install CUPS
2. Add printer via CUPS web interface.
3. Install net-print/xfprint-4.6.1
4. Run xfprint-manager
Actual Results:  
Empty window

Expected Results:  
List of CUPS printers

43a44
> #define PROP_PRINTING_SYSTEM  "/printing-system"
69,70c70,71
<     if (xfconf_channel_has_property (channel, "/XfPrint/system")) {
<       const gchar *system_name = xfconf_channel_get_string (channel, "/XfPrint/system", "none");
---
>     if (xfconf_channel_has_property (channel, PROP_PRINTING_SYSTEM)) {
>       const gchar *system_name = xfconf_channel_get_string (channel, PROP_PRINTING_SYSTEM, "none");
77c78
<       g_warning ("%s: XfPrint/system is not set", PACKAGE);
---
>       g_warning ("%s: xfprint/printing-system is not set", PACKAGE);
Comment 1 cache 2009-07-16 13:17:35 UTC
Created attachment 198179 [details, diff]
working patch
Comment 2 nm (RETIRED) gentoo-dev 2010-02-14 19:11:21 UTC
Reassigning to the Xfce team, since they maintain the package in question. They're the ones who can add this as an epatch to ${FILESDIR}.

It's also filed upstream:

http://bugzilla.xfce.org/show_bug.cgi?id=6089

(FWIW, I can confirm the bug on my boxes.)
Comment 3 Bailey Kong 2010-02-26 09:45:38 UTC
Created attachment 221267 [details, diff]
xfprint-manager/main.c patch to show cups printers

Same patch, but this one will actually apply.
Comment 4 Bailey Kong 2010-02-26 09:46:24 UTC
Created attachment 221269 [details]
ebuild that applies patch
Comment 5 Axel Dyks 2010-04-27 08:32:16 UTC
(In reply to comment #4)
> Created an attachment (id=221269) [details]
> ebuild that applies patch
> 
Can confirm both the bug and that the patch/updated ebuild fixes the problem.
I actually wonder, if xfce users are expected to live without a working
print manager for such a long time and both upstream as well as gentoo
xfce team seem to not care.  
Comment 6 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2010-05-12 20:34:49 UTC
+*xfprint-4.6.1-r1 (12 May 2010)
+
+  12 May 2010; Jeremy Olexa <darkside@gentoo.org> +xfprint-4.6.1-r1.ebuild,
+  +files/xfprint-4.6.1-xfconf_channel_fix.diff:
+  Revision bump with patch to fix CUPS issue. Gentoo bug 278047, patch by
+  Bailey Kong

No CUPS to test. I hope it works, compile tested fine.