Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 276302 - app-i18n/fcitx: fails with forced --as-needed
Summary: app-i18n/fcitx: fails with forced --as-needed
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High QA (vote)
Assignee: CJK Team
URL: http://www.gentoo.org/proj/en/qa/asne...
Whiteboard:
Keywords:
Depends on:
Blocks: as-needed
  Show dependency tree
 
Reported: 2009-07-02 21:52 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2010-02-06 15:36 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Build log (fcitx-3.6.0_rc:20090702-213758.log,27.47 KB, text/plain)
2009-07-02 21:52 UTC, Diego Elio Pettenò (RETIRED) 		Details
adding patch to ebuild, running autotools, adding missing depends (fcitx-3.6.2.diff,723 bytes, patch)
2010-01-09 18:33 UTC, Kacper Kowalik (Xarthisius) (RETIRED) 		Details | Diff
fixing as-needed issues (fcitx-3.6.2-as-needed.patch,986 bytes, patch)
2010-01-09 18:34 UTC, Kacper Kowalik (Xarthisius) (RETIRED) 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2009-07-02 21:52:32 UTC 
I'm reporting this bug because the package in summary fails to build when forcing --as-needed on through spec files (check out http://blog.flameeyes.eu/2008/11/14/problems-and-mitigation-strategies-for-as-needed for details).

Please note that this bug _might_ apply to -Wl,--as-needed in LDFLAGS as well; in both cases it should be fixed. Also, if this is due to the package in question not respecting user-defined LDFLAGS, you should get to fix that too.

Check the attached build log.

Thanks,
Diego
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2009-07-02 21:52:54 UTC 
Created attachment 196450 [details]
Build log
Comment 2 MATSUU Takuto (RETIRED) gentoo-dev 2009-11-07 07:07:51 UTC 
fixed in fcitx-3.6.2.
Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev 2009-11-25 17:55:17 UTC 
Err no you didn't. You worked it around with --no-as-needed, which is not a fix and still fails with forced --as-needed anyway.

The problem is that the package passes -lXpm in LDFLAGS rather than in LIBADD.
Comment 4 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev 2010-01-09 18:33:38 UTC 
Created attachment 215844 [details, diff]
adding patch to ebuild, running autotools, adding missing depends

I've removed flag-o-matic since it's no longer needed. Added two libs to DEPENDS.
Comment 5 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev 2010-01-09 18:34:45 UTC 
Created attachment 215845 [details, diff]
fixing as-needed issues

additionally I've removed optimalization flags from AM_CFLAGS in order to fully respect CFLAGS
Comment 6 Samuli Suominen (RETIRED) gentoo-dev 2010-02-06 15:36:49 UTC 
+  06 Feb 2010; Samuli Suominen <ssuominen@gentoo.org> fcitx-3.6.2.ebuild,
+  +files/fcitx-3.6.2-asneeded.patch:
+  Fix building with -Wl,--as-needed wrt #276302 by Kacper Kowalik.