Bug 274742 – Invalid repoman warning about quoting with custom ${dir} unquoted and used in e.g. exeinto

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Samuli Suominen (RETIRED) 2009-06-19 20:03:38 UTC]

ssuominen@unique ~/gentoo-x86/media-sound/teamspeak2-client-bin $ repoman full

RepoMan scours the neighborhood...
  ebuild.minorsyn               5
   media-sound/teamspeak2-client-bin/teamspeak2-client-bin-2.0.32.60-r3.ebuild: Unquoted Variable on line: 38
   media-sound/teamspeak2-client-bin/teamspeak2-client-bin-2.0.32.60-r3.ebuild: Unquoted Variable on line: 41
   media-sound/teamspeak2-client-bin/teamspeak2-client-bin-2.0.32.60-r3.ebuild: Unquoted Variable on line: 44
   media-sound/teamspeak2-client-bin/teamspeak2-client-bin-2.0.32.60-r3.ebuild: Unquoted Variable on line: 45
   media-sound/teamspeak2-client-bin/teamspeak2-client-bin-2.0.32.60-r3.ebuild: Unquoted Variable on line: 59

Dunno, I'll attach the failing ebuild here as well for review and try to sort it out in tree.

[Comment 1 Samuli Suominen (RETIRED) 2009-06-19 20:04:48 UTC]

Created attachment 195204 [details]
funky ebuild

I'll likely end up closing this after sorting it out in tree, let's see..

[Comment 2 Samuli Suominen (RETIRED) 2009-06-19 20:08:36 UTC]

Renamed the ${dir} to ${dest} and declared it local in src_install() and the warnings are gone.

Beats me?!

[Comment 3 Arfrever Frehtes Taifersar Arahesis (RETIRED) 2009-06-20 14:34:57 UTC]

pym/repoman/checks.py contains:

class EbuildQuote(LineCheck):
        """Ensure ebuilds have valid quoting around things like D,FILESDIR, etc..."""

        repoman_check_name = 'ebuild.minorsyn'
        _message_commands = ["die", "echo", "eerror",
                "einfo", "elog", "eqawarn", "ewarn"]
        _message_re = re.compile(r'\s(' + "|".join(_message_commands) + \
                r')\s+"[^"]*"\s*$')
        _ignored_commands = ["local", "export"] + _message_commands
        ignore_line = re.compile(r'(^$)|(^\s*#.*)|(^\s*\w+=.*)' + \
                r'|(^\s*(' + "|".join(_ignored_commands) + r')\s+)')
        var_names = ["D", "DISTDIR", "FILESDIR", "S", "T", "ROOT", "WORKDIR"]

        # variables for games.eclass
        var_names += ["Ddir", "dir", "GAMES_PREFIX_OPT", "GAMES_DATADIR",
                "GAMES_DATADIR_BASE", "GAMES_SYSCONFDIR", "GAMES_STATEDIR",
                "GAMES_LOGDIR", "GAMES_BINDIR"]

[Comment 4 Samuli Suominen (RETIRED) 2009-06-21 01:04:49 UTC]

(In reply to comment #3)
> pym/repoman/checks.py contains:
>         var_names += ["Ddir", "dir",

I've removed locally the dir and Ddir from the checks.py and the problem is gone,
do we really need to check quoting for such generic variables?

[Comment 5 Zac Medico 2009-06-21 01:52:33 UTC]

(In reply to comment #4)
> do we really need to check quoting for such generic variables?

No. I've removed that one in svn r13659.

[Comment 6 Samuli Suominen (RETIRED) 2009-06-21 19:59:01 UTC]

(In reply to comment #5)
> (In reply to comment #4)
> > do we really need to check quoting for such generic variables?
> 
> No. I've removed that one in svn r13659.
> 

Thanks

[Comment 7 Zac Medico 2009-08-03 23:06:45 UTC]

This is fixed in 2.2_rc34.

[Comment 8 Zac Medico 2009-10-11 00:49:11 UTC]

This is fixed in 2.1.7.