Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 273151 - Version bump: media-sound/decibel-audio-player-1.00-r1
Summary: Version bump: media-sound/decibel-audio-player-1.00-r1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Sound Team
URL: http://decibel.silent-blade.org/
Whiteboard:
Keywords:
Depends on:
Blocks: 273113
  Show dependency tree
 
Reported: 2009-06-08 08:34 UTC by nm (RETIRED)
Modified: 2009-07-16 20:50 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
decibel.diff (decibel.diff,1.51 KB, patch)
2009-07-15 04:21 UTC, nm (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description nm (RETIRED) gentoo-dev 2009-06-08 08:34:48 UTC
Hmm. Originally I wanted to stabilize 1.00, as reported in bug #273113. However, I've determined that new dependencies are necessary.

Attached is the ebuild with the new stuff: it renames the "gnome" flag to "gnome-keyring", since its only purpose is to enable integration with gnome-keyring for Last.fm passwords. I have already updated the guide with the description of the optional keyring support.

This optional USE flag does *not* require gnome-python-desktop, which is deprecated. Instead, it needs only gnome-keyring-python. I tested this and it works just fine on my Xfce systems. This eliminates all the Gnome dependencies that were brought in by the old g-p-d metapackage.

Functionally, it is *identical* to the old gnome-python-desktop code. g-k-p doesn't have all the extra unused code, is all. :)

So, can I get an -r1 version with the proper USE flag changes, and get *that* stabilized instead? Thanks!

(Should the arch teams be CCed, too?)
Comment 1 Alexis Ballier gentoo-dev 2009-06-08 08:42:13 UTC
(In reply to comment #0)
> So, can I get an -r1 version with the proper USE flag changes, and get *that*
> stabilized instead? Thanks!

I'd prefer not going with a -r1 only for an useflag renaming; modify it in place.
Also I'll need a metadata.xml entry for the description :)
Comment 2 nm (RETIRED) gentoo-dev 2009-06-08 09:24:12 UTC
(In reply to comment #1)
> I'd prefer not going with a -r1 only for an useflag renaming; modify it in
> place.

Sure; whichever you think is appropriate.

> Also I'll need a metadata.xml entry for the description :)

gnome-keyring is a global USE flag, so its description is already in use.desc.

If you really feel that an additional explanation for this global flag is necessary in metadata.xml, use this from my Decibel guide:

"Stores your Last.fm password using gnome-keyring"

. . . but personally I think the description in use.desc is just fine. :)

Comment 3 Alexis Ballier gentoo-dev 2009-06-08 09:56:42 UTC
(In reply to comment #2)
> > Also I'll need a metadata.xml entry for the description :)
> 
> gnome-keyring is a global USE flag, so its description is already in use.desc.
> 
> If you really feel that an additional explanation for this global flag is
> necessary in metadata.xml, use this from my Decibel guide:
> 
> "Stores your Last.fm password using gnome-keyring"
> 
> . . . but personally I think the description in use.desc is just fine. :)

I'll probably add this because it doesn't hurt since I would probably wonder what gnome-keyring has to do with an audio player if it were the first time I see that.

Could you please attach/send me a diff ?
Comment 4 nm (RETIRED) gentoo-dev 2009-07-15 04:21:42 UTC
Created attachment 197992 [details, diff]
decibel.diff

This'll work as a change to the latest decibel ebuild. I originally thought that it'd require an -r1 revbump, but if you'd like to do it in-place, I have no issues. See my earlier comments for the metadata.xml stuff.
Comment 5 Alexis Ballier gentoo-dev 2009-07-16 20:50:57 UTC
applied, thanks